From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4576C54E5D for ; Tue, 19 Mar 2024 14:05:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E2B36B0087; Tue, 19 Mar 2024 10:05:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36B846B0088; Tue, 19 Mar 2024 10:05:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5DE6B008A; Tue, 19 Mar 2024 10:05:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 085136B0087 for ; Tue, 19 Mar 2024 10:05:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A76BCC10F2 for ; Tue, 19 Mar 2024 14:05:08 +0000 (UTC) X-FDA: 81913960296.10.8969173 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 73A801C009E for ; Tue, 19 Mar 2024 14:04:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dhdd4sVL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710857078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=MZ2IDF+QcHZ2yE9skqYignuDosSX0gUvG9qi435hiHKNWdhvaJ7wt4kjmAz7lMobIWHIvK 2Xt4LkSWARQPI9KGESZwfyEO2edKcAW8UTFMATRT3LMfuylOeHXrT3J0YTVhx6XpvQaNgA tUlnOlaIfemRMR6n4ksxyJdfyeSNIgM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dhdd4sVL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710857078; a=rsa-sha256; cv=none; b=6/+oEc2SGTW7t8qFrnGJY4kVbvd2tY5lj+LyrRgj0TGyrtW9n/jBBW+9aaycz5U+/28mX2 U8OrFYzNq0m1SVARLnqaKCBsqTnwKDkjRRZpkJNbMPMVjbyhJTGzQhW1YAy+3XgOUaNtbe vzv7UHeQTNfbRzde4GMfXRiAui+RLw8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=Dhdd4sVLgkgdh3Z5QXzj0spXGyeB/YJRyfoyFFc4U0688tvIzbZJPGqznrAi9SMkPsOI2g eHFnZz08bLMeyz5X1zLSKwqkqFSudYV/NjjADz9TV7WbsDGqcXnBaz9eq2hsHPTMq3yC9m ufnYuknGtzBTCK0QIwi08uACmtJHqzI= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-wGi34ad6NHSr9Pe_V-Wf5A-1; Tue, 19 Mar 2024 10:04:34 -0400 X-MC-Unique: wGi34ad6NHSr9Pe_V-Wf5A-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7830635331bso155305585a.1 for ; Tue, 19 Mar 2024 07:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710857073; x=1711461873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=hA+VfkeTuPb4HjzlenDmfUtyfiBnFPTd4PI6OKEnqkAwnmDsg2LjHOnmc9br6ls5Mu j87n9H0Y3tHfY94b4ODW6oWFwtZKIAQ9N2whDQWHPYXhjsGXSqcon8PnbSTJGrA9EcPQ IK8VtgkZIX9134G2Sb8FY0B5F9TdnX4K2gmTETLH4EI6do42HAYYNruw2QVkAhA6U4RU 0bzwpg7VYswl431/hf4aNR6Xj3tCzu25ihLc46eIkiWsYKsqb4827pY0AbHLY4RrV2QO 1jcoxDnU+OjkoS27JfGoRvIt7wUbg9I3EBg+D9VE4h8MSWLCRk/Mophiz3cVu+f77qCL bi2w== X-Forwarded-Encrypted: i=1; AJvYcCUghg6BH4rGHen/xC8JrsW/3SyFWDY5nzdV5KXjagC3N0XPjCww3o1dsRie5jVNPNqi2PgskWtteN6wUtM+9BrKw9w= X-Gm-Message-State: AOJu0YxgbcLvKugcsDKvGnRk2WpS5iLESF5yl2++oLv12RpgF+XGKGoO f5YkIBeORkv6KO1gu9/4VJXUTeP1sM0ZswGn8RvTalyKuI7El20BwJIO1+V5bPV3fhoC42E4VsJ IzhNaYt+IpDtJFLpfij9WfyLdvQUmdKe9HgowCCaTnL2Ddt/ST5SAj93Y X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518357qkb.4.1710857073246; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2woW7UEchY2IkBVWYzgRK0KWJ4spUtcTxNI2cDq95Ac2i5H9cK+iTpsS+AG/gM2n1vRK6zQ== X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518292qkb.4.1710857072670; Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id ye1-20020a05620a3b8100b00789e1874eccsm4708269qkn.41.2024.03.19.07.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Date: Tue, 19 Mar 2024 10:04:31 -0400 From: Peter Xu To: Muchun Song Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries Message-ID: References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> MIME-Version: 1.0 In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 73A801C009E X-Stat-Signature: 91m8o896ubngidheu89ywt1tfpipmc38 X-Rspam-User: X-HE-Tag: 1710857077-332164 X-HE-Meta: U2FsdGVkX1+bPiFluwrO2KyW7pYgZTVYsD3umw6mrqEMmlViVy1PjuUr05qRSTBJLz/idGbwKyo7Uc7xfXEow2wapzxCpKh6nIuPdvqJpi5NSsbX1HcxFaMoRvFzmRZuwD5kDTsnVpU+cs8fTWJVdl0NBKon/JhhYiyuWNKS34bS2dZORbjqXxRnX5DNs9BOTjpwgWOBxTcCVKtL8dy5231/2v3AcXkA0EaO8T4Gnq7S1++0WjTp/rqTt+sBx3ENNnREderHg5VpqhZoWMLSR011+dqRpkh0bhnp/qDfy1YkcsIRpHk0kOQYrd2RS0k8rTMrY5WyzKpN1jhBJd/71v+uuVZ6dAv4o7ELU4PIP2mpbWlOfaQIV8GosTgC8CObQgTs7PCDDN6DOS3jmqSeefWZvb+IOClnQpn8RnESL9/QM6Dfg1krfWL0PQ6TGo882fEK5epL4dBHByitVhCDhccTLtLVPaInp9H53L8SoGfLwQsYhy6uslCU/wUhLTzZ2Rtapo8LmhY5qo1IGBNre97hWwv3KrxF1HuZ81taYJAQqc+Z0a6VTvZBqUVasRG9rKjdlQOfNPzKizY9Bi1y0FaBmYnn/wHqdjppDQYYTMFD8o1gPQGBxIK5ovCLRCqq3RP8NdXWqbIb4R5E5tk3q65r7zNvyDAhvHp+s8v3/B4GvwyMRKQx/jstWY4WAGjZOJTbDCZBLyoSTod5yVs6CFDCLJVklSSYRxX7PyT+uA20bbT5lUxEGU3Ad5XfEqEpl+qob2ZZL0nRY4nt6kkoBSv+E3aVHAiMThazFRzgac1RZhg42j7jl+yxZy7LHpMUsJe8WSe5Cpteq7v9091ooGxeKWkEW12KIA4guQkbUBkUj2iYIYmNCuSttzCHraBHsZ5F5utxRW1RG0hdUVX6tLZIhqQ37OG/5OV6YneO3Dt7/rxEIwPW74LsO89I8mtQRMq2HOH4Kkce1D0di63 RLIJ4UAE 78Qx7mQeEq4tGc8vNpqpPWmjWSbYt0Iajf8N5we6pEWSXbgx1PCU3V7OscN1v9m5K/TzgUoIkQVTnb6XVq+WeQpROLsLXCFmFudfUdOgSFve9GiAY6JREmtjaZz6CkWSDRbQpnS1nlXKO2j5jCReVjQ+y/MiNT182zX13PJRWt8sW8Tr9weEAjjLv16liByiZzAA67BHfQC+QHHsBth74BmhLfV2yof46vCsJ6j/1oyuNudw586CoZWy2L+SJbXaEibZSCHiNhERZ+wmg+CXm/gzrfAVwszVrXgW0QyqkBdM5h93hOGDc21mgIRoewDVdeGb2VfIuwPZWe7uAE2QYaHmERGYANxfXqBpxSoWOF1s4jEYGGJf0xDzsOzdR8x3LPkeax3tyLNkkPK4Amq/gclOv3C15NNJgGHP6F2PHHmdW4Kig0jsOa0JBJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote: > > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > > > > int pmd_huge(pmd_t pmd) > > { > > - return !pmd_none(pmd) && > > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; > > + return pmd_leaf(pmd);; > > There is a redundant semicolon in the end. Will touch it up, thanks. PS: This will be dropped as a whole in patch 12. -- Peter Xu