From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C810C6FD1F for ; Tue, 19 Mar 2024 16:48:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9C536B0092; Tue, 19 Mar 2024 12:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4C9C6B0093; Tue, 19 Mar 2024 12:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3B716B0095; Tue, 19 Mar 2024 12:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A541A6B0092 for ; Tue, 19 Mar 2024 12:48:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B943A1707 for ; Tue, 19 Mar 2024 16:48:10 +0000 (UTC) X-FDA: 81914371140.13.596E687 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C16C2C0007 for ; Tue, 19 Mar 2024 16:48:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LJttsfsk; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710866888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V0SBy7Ck4tFXpJEBaySgBj+pOkXYLCrjbnWaEi08VzU=; b=weSLS3ViO4GhY77aOQxNXxQ/xSWzex+IlV6eCzg8zE036CJqu7dW9zsxwlXSDS/ZMv2bLC Mw1Zw7sIJ4/4jfWWA6o+u968alICnDPlfkRzTEFITPU66zhCaEpN7aiEiK3VJQZnrlO22s D/vlgvsNp3kK1lYKLsEsk6EHO5nz/nQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LJttsfsk; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710866888; a=rsa-sha256; cv=none; b=uR7Lfa8Nw2SoNyf5iq9b/96KQ+Wdt7fqlgXJpHrKq4zgCJf1QIHK4C8y7y4OEkVStpP6rB c5Y2NEUSimGETTn6Oqbi9dqydbtZjfTvgofnTFWhoPIqleZ2yI5Co2jgH/8iCx2p3T63DW Ltsj7A4B2HnVwqidDgVJhVJgrtqfl0Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V0SBy7Ck4tFXpJEBaySgBj+pOkXYLCrjbnWaEi08VzU=; b=LJttsfskNs00fcnL0LgG1jB0L7 iVg5ZWYK6v7D9MxeDFhiNq+xVqA8/QtmSqnqvmJC/e6foEa1JhM0Db6tcmPI/JPkp7jDW+yOTPWMn WilAJqWRKvQIZAkq/Q4p8kUlJZ2LmzFoAg3qBpriJ4DTo+kpUbVOD8N10ZVpCfOL8iYtEF7mC1bDj 9huXxDkp5hlugXLcwrpQtM7b43tZU7AselHCO3weExvnt08EY+hfPzSbgmJqDhoeU0OceGQbDzFFm ZYTYMdtbLWWnF8zlY8cKhuL2HH4ceArXYmy5MC6HfDKq8Modl2owyL8MqnMC51LmraH9342/Ypyzx E3zTsdOg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmcd9-00000002KxF-0cSH; Tue, 19 Mar 2024 16:48:03 +0000 Date: Tue, 19 Mar 2024 16:48:03 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/filemap: clean up hugetlb exclusion code Message-ID: References: <20240319092733.4501-1-ryncsn@gmail.com> <20240319092733.4501-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240319092733.4501-3-ryncsn@gmail.com> X-Rspamd-Queue-Id: C16C2C0007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yg5jptnaeudyh36cknghjmcei1fygw7g X-HE-Tag: 1710866888-794542 X-HE-Meta: U2FsdGVkX1+8HlIyj06lDaz+lmyo781uTuStlQtugRYfRLXh5w90yToNdM8JVewcdT9EIc3nUtnS4ZzZPuKka0xc8LqSllbsLvbL/mtOwTXYqvc1VNfSGHID6Ji38ceKTBAYtfMcIXeoObjXS1LzMMognBeuQ4hhiAgLyEgS60KMeOQ4Hkc2g4zLS+tSugJZTsIKDmRqSmlolXfOF5UXMSPECdPStd9hPtjpwhDIZMjYAzBPO2F6bt3m9pzuveohgoMxu/uZBsmpgsL3JUYj9l9K5TjD5D8YexOmsfODlILQxwuD6lFRJG1mvgvaVeNHrKpjAGmIN3LR/r3FyEThYCE9c0rA9fWmeP4bxsbkq0dgDiFMBREGGFpgwRAaTElneuyNpOmRYBbn89Zz/d884QXjY/DqFgt3wLbkLibpAL6kR2RQ2Kas0PRBJzxgUQNhbjiNaf60KVPUNsbYN235BTxKBF5M1gSCnU+52Y6E4/wLQCN8sQkKbg8go0PjuBl45pVIIrvE310888SCWJ1kK+17P31iJqd4Hf4xi5NvZk34Cj+Nbw79d18/qQdA7efa+NJ7582Un1bp+zi4r8+U+AtY4l5PKFa6L+sORSKz44GZZuFRr6k7XtvGRxm26ypQpPGjlE2hRfrW9F9loXe0MSbuIUPI701X64SAhqZ41AqAxs03oSKTQalXLzV5PmTcfE9z4pKUOsRtuPw4E/8EmLpbEe2YvUGAybFtFy2YTytfMdVxi3+4g04IpXmd3aeLgGfYbLI87HiW+Niz1BoCtxXMiMHevjRnAW8mF3sGN1D00H9XeOL8yXs/0d/hhj3yzFlCmqxLrFLwTm6iAqL0aO4XFouZcvO3oRTz6OFKpNwmIy9ERxxhMkqdsvC+cTbQ87tDs2EiFhKbU65x6+EyTZjSh5r4V5rDNkGtO2WYnLwrM5HumluI508iDE+I7dR1e6BpUHSamv9S3m0v3j6 gIkUHpAj tyWig4GD5ZdPFcq2itLEq5Bt2NSsLfboeaBEyv7KYqncSaSdNKHVeHf8XXlwTFbAZbn1P90aj9zWd235BDymdNyA7teCH+UrajLFqEM8Rc790W55x15dVuBpUonWXFnTJIWeHbduLxIzTbtIPqSf4FHhf8xsbT9OZsLEgx45KZevAMJp3W4ipV+0xD2CUVGSuijKviEDYiNudDU9WP+S5Z77m2DS/XOzKxo8CoWvhOYNXxd+GedRMvM64RLaS7RaxC53J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 19, 2024 at 05:27:31PM +0800, Kairui Song wrote: > From: Kairui Song > > __filemap_add_folio only has two callers, one never passes hugetlb > folio and one always passes in hugetlb folio. So move the hugetlb > related cgroup charging out of it to make the code cleaner. > > Signed-off-by: Kairui Song Ah; excellent. I once had a patch along these lines, but it never made it in. Happy things got refactored to the point where it's now easy, and mildly annoyed at myself that I hadn't spotted it yet. Acked-by: Matthew Wilcox (Oracle) (I'm acking these on the assumption that Andrew's just going to take them; I can collect them myself if that makes anybody else's life easier)