From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742E7C54E71 for ; Tue, 19 Mar 2024 16:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6D06B0083; Tue, 19 Mar 2024 12:52:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B671D6B0085; Tue, 19 Mar 2024 12:52:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A56006B0092; Tue, 19 Mar 2024 12:52:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9604A6B0083 for ; Tue, 19 Mar 2024 12:52:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 698A8411FE for ; Tue, 19 Mar 2024 16:52:12 +0000 (UTC) X-FDA: 81914381304.29.7DC9008 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 85C2740008 for ; Tue, 19 Mar 2024 16:52:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wD95Toxi; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710867130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KizDvAs4Yj6RxJgCz75yX4yH1t6QiF+D0on+mjFBcMY=; b=lkFeZ508DJw8FLPgVyL9DjCvp6MB4k3aIPG818D3f3rO+FGXbCkJDsd5peN9jztSMxu/wA MQVmfpq7KFfOCWwfWreYTUN+mRiS0SsBhJc1UkdHWjUDYP/84ocfZ6rmd2sh52xgaIZt5O //qr4S8iq5LbA9ndac8ahbAe9ptcvWE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wD95Toxi; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710867130; a=rsa-sha256; cv=none; b=C1b/EoTIQm/uY4Ya3vO7I8aKGBJszu9lTG+NAuxQMiLO5whHPhHY/gN2TqWNFAc6VXHPtP kbFTHyIG0jAjLDpFRSQOYHjlLiIgAkCrF706Mx2y/xLcYmq8M4QlVtWG7fPAZb6d6BmqXx toN97RH0oMu+d6ZMfCiamI72untk/vo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KizDvAs4Yj6RxJgCz75yX4yH1t6QiF+D0on+mjFBcMY=; b=wD95Toxi1mDsNY0oD6zGhWEqfA yR53icSHH734mg06hn3pofuf2It8H0/ljVmyc8VHn+6XWTokNP+4yiQ1vx23/U0AOUX38+kkKPpkE SiLb8NYFoZjcUXns5b8dAdi1G7wdigyDJSemyHlICDV/Du92a4dY/4EGtt950HQgQI44WrK7QNXXS NSeIUljFahH2pYbnISnSPy1p6oXxSzy36iTTqGuBCL6hIMhEKORNWV3pzCwAmK6UzHz5Q1XVVeX5m if039kC4j5ZITVbAwjF4WIimhaTPx+qTuN+K7Gn8RPpLLpbuX/q5MopitPqIBnxYu61nbtfDlMMOu DcIl/XRQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmch0-00000002LeJ-0ltl; Tue, 19 Mar 2024 16:52:02 +0000 Date: Tue, 19 Mar 2024 16:52:02 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] lib/xarray: introduce a new helper xas_get_order Message-ID: References: <20240319092733.4501-1-ryncsn@gmail.com> <20240319092733.4501-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240319092733.4501-4-ryncsn@gmail.com> X-Rspamd-Queue-Id: 85C2740008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: apg6txzmu6y81f1cjkw3z6cdtngnk9cr X-HE-Tag: 1710867130-732533 X-HE-Meta: U2FsdGVkX1+2N4paLRUi8VKZRtgz5jpvTLm7GpbqwCFgIb5T57JuXXagaBBsdcINjtgzFhupFRsMRbMjgetIScHoGshl5U9zQ6xBjKKd11807iluTnRq6sK+Z9GstTQSE9Jp/h6Itn4/AdBHJtl22bEiZOwX/LvUq1ktKfjgJ8axRB4dZWjeWJgl99NeS62/Eg9dRVfhw4ApiPWDEHqTtUhbCC6n4/u4gOxYkGTliIVNI7/aKWu0WPCdLdUEbwjcmTARVFfwd50GSXvpk9HF3qH2VLJOE0gocAl3Ic7VZshZhdTbFXUcgYYA/SIp0ZAghiYDuXAF4DaEa9Q2XPD0iAh2YrVPPZS443LPK80rmYG0N1aoqdgBcnDjc1I5ZtOib6NAhGi3h9D737YzlmPDMNXQiVRZKLe7isINTSRu5xsAG9nN7BDzvTMWhb9+1e033gce+AQdEr8x4xOQIekZhlG3qu7d+iQJbCv8jgf/7GTBGlZyKj5SpzClcIGJREYDqbTP3j0U7UTkmOMMFw+0Ei/p94Ae3U06NS10zMKyeNDjAgqtCgG8Tu9egIvFBplPdsFpZbozPaiWR+m3YrxqriVYqsSSd6rvrfxynqc34LnAUtdsKsEeVtSIQYapDnEDdmHJrzXKY0PICkjxPDXXpv3RtyeOvxZGmXWQ1xc4QNqPiq4bIMkiIVUj5cLvWnDtt4ZyyJ8tYNBTNiAotbGes+KLPyQe++cugzEFte5prVYchRQBvGFGp9o4UxVSgre4nEMH7WhBHRyuXss4XpuuA8S9khuaHQw+t3SCBOw2gd7z7DmApEt3IVngfgJbK32fUA9f4A2Ee/pciw+o6L+m/hUzGtIdR9tbss7DjA8zPapSPoqjN1tk71EdSVNn5UnOa+0U+eNq9wj6ZhPXF56xcj5ZMWqWUUOiWHPQTxRKZkx7wNhpNBzwc2iLpcuKbJNb/2K0XkzFONotvhSo4OP UHh6AItS /cAXcUwQkjpyOj0V1iQuNMukMATErDWJI1usCbBq7wgCqIbe12nic8dZnm9GcTOZZPv9u34+Ftk5BffirUsb2zDxTZtqxR+xG4pL1zgcYoJgxQjVlFQzWAYYWoudoCo8Z9Xnmx93iu5fRi/sI8oe3dFP7dpg4uqpyT7m4NhtDgTC/8Mo7rt5v5Wa7wKOuG290aBjAPoi/TAAri0qp0HJbSVB8I/5I4kJUltqymyFARfetBu0/GpUERxlgk0HLdGWGXVcv8ZzN4bb5s2Tr0KMdlUVi9DziaRvdPzOhBk4u0HuBDGB39zKjSY2D5XO60Gr5CipqaUX7ElDsMK08ubsCRGkdUheFSO58sC5x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 19, 2024 at 05:27:32PM +0800, Kairui Song wrote: > From: Kairui Song > > It can be used after xas_load to check the order of loaded entries. > Compared to xa_get_order, it saves an XA_STATE and avoid a rewalk. > > Signed-off-by: Kairui Song Brilliant; yes. I was just looking at this the other day and wondering why I hadn't done this. Acked-by: Matthew Wilcox (Oracle) > +EXPORT_SYMBOL(xas_get_order); We don't have a module user yet, so I'd hold off on this. It's an unusual thing to want to do, and we may never have a modular user. Also, xas functions are EXPORT_SYMBOL_GPL, not EXPORT_SYMBOL.