From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B69C54E68 for ; Tue, 19 Mar 2024 22:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D7786B007B; Tue, 19 Mar 2024 18:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887A76B0082; Tue, 19 Mar 2024 18:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701426B0083; Tue, 19 Mar 2024 18:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 616676B007B for ; Tue, 19 Mar 2024 18:17:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1758AA1234 for ; Tue, 19 Mar 2024 22:17:13 +0000 (UTC) X-FDA: 81915200346.24.408C564 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf05.hostedemail.com (Postfix) with ESMTP id D2596100005 for ; Tue, 19 Mar 2024 22:17:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="VfVRxuF/"; spf=pass (imf05.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710886630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6mKF14OWHZkkElq0bOodAxiF/Zp1dq4sueaSM4wOt9E=; b=PkUz2nS/VTcRUUudEGdK+/I1deOxKuASoI22pkZDFpWmDOlKusiDpruK+MO7b/JSVaaRfX IgA1MDfF9ybp44CavoOGVnkXnJwiR8DjTgeuZH2ArwSV3yE3+k1i+mpL5CwOizzxNSunoT Fz4F64bisU0MI64uenxpanKE47zAs+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710886630; a=rsa-sha256; cv=none; b=wq+E45aiLFLTVZj0NEk+yheaNWC+0saKELc3N1KeDZXbh+pi66eIVtBa5Eu6YY/Q3EW5Vp qY5/kQlWnO5nFOpYnByvx790af2l8nbSbany760oYj1wVKMj9V8tW2w/p4JODZpSb1hlJI Z1FXAceLSQePe8PsOWJWdAE4mBcOOpE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="VfVRxuF/"; spf=pass (imf05.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-690d054fff2so38421316d6.3 for ; Tue, 19 Mar 2024 15:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710886630; x=1711491430; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=6mKF14OWHZkkElq0bOodAxiF/Zp1dq4sueaSM4wOt9E=; b=VfVRxuF/BKECXftjhoWXvWByS0FhWxssXgza1aTWUztNGLTMyaK1q3yQg1Iyb5itvS 3nCEeNuNDpft6cmjRAHpetRknXwy+vYJfNJnGUFxgVfhFbJpDB+LposUaFdJEVLHmX7G qqhFaICpgHLhLpdJuQAKehRK81C/aMdNrNdkxJTrccx1c+sTs4O6tzcAjv9q+fgLxdie 8vHRAhwZBQ5bjae2PDZvQ/Bx3ekL4yuSnhtl15mvNXSJdtm5bN5lppM/o3maLzzelQvM kADccXyrBFcp8D7pbRxP+J/nhcpFjdcX7G9rpx3T4EeA7lsoeFgNJsuG0dHUCnOAV+eY h13g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710886630; x=1711491430; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6mKF14OWHZkkElq0bOodAxiF/Zp1dq4sueaSM4wOt9E=; b=t+xMtMX2J/t1aDPCpQPVZlvSwe9j5C2x+NLjqTRYBafUeeqgJG9dn0sAzk/FIyt+E0 L8I9xW7yibD/p90+uKgzLQiPRiDcmd88qPKbUSxttRcAMiwPa2HkgQrf0mgfiKNUfYBz eD60JTOzDnnU8C01iRDDMKitg4nBXvSVoLnxdDT228VkJ7TJ3BNGlxDseURXuhw20eS2 RFdx7KshqLsBvUptIfY5DUBfLShG5F4Aq61AeXCo+S8H0RG1gPiZYK6NyON57zwMQXEA C8eXV+fiUAhXKRLshil7ew3HM9cS+uHIb6qnSK6BcbNfC77hg0htfRjtlpXNgbLvLBi6 9UuA== X-Forwarded-Encrypted: i=1; AJvYcCVByZ+hZtwF30QZY+fe1P8fdTjoAXnlFXh0oG4WxjbobxpAGWV0F6zrUQnw/Zqw1H29khROeXDxZBW48PHXIyd/MFw= X-Gm-Message-State: AOJu0Yz9EA9ge6j85GAEgWRzZN/0X06/8tIKeyQzIKwFHxF0E68FBZ4/ kLYeK4iacfg//60oZdkSs03WFmukJPqiM+x10tfCqK5G1NWIykkV X-Google-Smtp-Source: AGHT+IFgcZi0l7LPJvcopa2SKXhsTMMmijH0zolxqJkPFZ+cvmw30Nbu2wYxGYeecQxYVOmJXFly9A== X-Received: by 2002:ad4:4d53:0:b0:696:25e9:92e3 with SMTP id m19-20020ad44d53000000b0069625e992e3mr3689993qvm.57.1710886629980; Tue, 19 Mar 2024 15:17:09 -0700 (PDT) Received: from fauth1-smtp.messagingengine.com (fauth1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id im14-20020a056214246e00b0069049298fccsm6952366qvb.65.2024.03.19.15.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 15:17:09 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfauth.nyi.internal (Postfix) with ESMTP id A448F1200066; Tue, 19 Mar 2024 18:17:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 19 Mar 2024 18:17:08 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrledtgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeehudfgudffffetuedtvdehueevledvhfelleeivedtgeeuhfegueeviedu ffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdei gedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfih igmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Mar 2024 18:17:07 -0400 (EDT) Date: Tue, 19 Mar 2024 15:16:54 -0700 From: Boqun Feng To: Alice Ryhl Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v3 4/4] rust: add abstraction for `struct page` Message-ID: References: <20240311-alice-mm-v3-0-cdf7b3a2049c@google.com> <20240311-alice-mm-v3-4-cdf7b3a2049c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311-alice-mm-v3-4-cdf7b3a2049c@google.com> X-Stat-Signature: b89n5fk8yyz1zcbe1kkergwtgqtsecpw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D2596100005 X-Rspam-User: X-HE-Tag: 1710886630-388690 X-HE-Meta: U2FsdGVkX19VLKNksb6g5DItv0O9j8P3s0qXhY3qGNdfIaILkdrZN4fXcuwHOnboQxegkP65L5QkqewUtsevtFjcRIm/Vdj/lAWApk/cgW8MVeeZHtq68DDnKiDSpw5s4jCbj75EWaWZiQ1xVjfF3DWbxcklUc99TqzNY5ZdLkSuqE3DvO/Xi2ngjLyFVomap8NkdDzi+ikf9S9fvwjdj4NvapQ4bvPbp1htCOqHNhMQBJ2yBkkOYE9SeaGo7Vw9uWQvgge0oOcXftN5YTpxlGj6SE9xjyHRdiMjhUSPrxRL6rKW9K41G+u2XCtxLyL3P1xaruU+Jt5AKaKcusaK/wy8PqGh1fcyNWWQp52ypg2Qd5GDaWUolmPM98KNaIeJSTnbyFHheEjLBXPgbXBJoRde4Ph72yl67LsIy6Vca3ceFZuCb390C8hr1snAUrD/sCsTEcDPXhzPreS2sli2Y9qrlzE97eKvWyiNK/CZBeA/LN8VVK23q8tMjj4U3lEu9Wf55UaaKRwlOeO595W5Jj7WgARXonlwWo2MsL6CbHUio9GDCV5WjLuJTZTh3OZU5HhQkPmw44d/o6Ue5LVPqv1HgO3OCHVtrIgmw6x6fUZu4oGToqWZSqweDoxnDIAiYW6WTloVHHz12r8eiccXpcOVBS/vD6V0SMYbDt2MgRVXG8UnGGTn6y199MPcqOWh6gf3+HxFqZx9N59PL81Az+5gtlhJ11Xa6utU0heWX1t5HOuFGSawew0y5ek51Ut4/PAx+pCMbkCmqtBckP5ULV8JIT8Zi9dV2V0fmnXyCOf0J60yWpLWFCtC1osaJS2XFnfvxuhx7XJ1wJsWsWr2NlV4D+lG/YY2xJrFlG9fodQ/LvuwOfTF8KSQEqPLWd6oIfEMIU7yvm+x7DveKQAa1XInd/0bjZTAz7hcvF3wWZgWK0bcZKKEtFoi2TMA/1a4wCW7w0DTgJYm8rAZPlF LmSUUyyG HbipxZ0aNB6Qm4ez4aTPAnXfsXF1aaHFifMaTjPw5pHRC9JtYf7qCb2uBD8R8h98hvHoqYfgS4iuXezjlS9ifPNL8oURkdSNwpsUfpxHExmHW48OGP+KHXAnK2OCqcE88lgfdMzF2Iyrr+GksBb0WF24HBBLRCbz+f0359APyhIp3bvG8OBlhkWbJ72DLH6MqWHHOrkgwwJzAbXGSf50+HcNYR9VDa57y36R85c6UGddJThf10yjudtgc3L7cLbGkzJIkqbYM3xgOR21ziZ1ZK5XSaKak+EXfuzlmsTSo/X9hcxf5F1UVmmfsIAdA2LhZxxpa7DVeO0qveF0OKIeziPXpiSNQhJgKc6xyd+ZttmKKozMkvr7AB3QQLmqODNCfP9oadKR4wYsuuHdDlF4HeC1OBg2ocXhePeeRXkdzDUgKynLVBlC6HtPnzMQalRM9Eo9fHdEWfdfTpQfOYkyYMqvklPyAMN1U/6/SikHUD+xttixyE7/QnS5w2zPn7hfz9BH/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 10:47:16AM +0000, Alice Ryhl wrote: [...] > /* `bindgen` gets confused at certain things. */ > const size_t RUST_CONST_HELPER_ARCH_SLAB_MINALIGN = ARCH_SLAB_MINALIGN; > +const size_t RUST_CONST_HELPER_PAGE_SIZE = PAGE_SIZE; > +const size_t RUST_CONST_HELPER_PAGE_MASK = PAGE_MASK; At least for me, bindgen couldn't work out the macro expansion, and I got: pub const PAGE_SIZE: usize = 4096; extern "C" { pub static RUST_CONST_HELPER_PAGE_MASK: usize; } in rust/bindings/bindings_generated.rs, which will eventually cause the code cannot compile. I'm using bindgen-cli 0.65.1, libclang (16 or 17), rustc (1.76 or 1.77). Anyone else sees the same thing? Regards, Boqun > const gfp_t RUST_CONST_HELPER_GFP_KERNEL = GFP_KERNEL; > const gfp_t RUST_CONST_HELPER___GFP_ZERO = __GFP_ZERO; > +const gfp_t RUST_CONST_HELPER___GFP_HIGHMEM = ___GFP_HIGHMEM; [...]