From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B49C54E58 for ; Wed, 20 Mar 2024 03:34:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09FB86B00A2; Tue, 19 Mar 2024 23:34:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 051216B00A3; Tue, 19 Mar 2024 23:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5B216B00A4; Tue, 19 Mar 2024 23:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D82306B00A2 for ; Tue, 19 Mar 2024 23:34:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7B550A0C19 for ; Wed, 20 Mar 2024 03:34:30 +0000 (UTC) X-FDA: 81915999900.25.F9E5A67 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 4A27A40006 for ; Wed, 20 Mar 2024 03:34:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D5ZzB6z5; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710905668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fmjl44mehHCSaJsJ049BqzU8nsY14MeWPP13ami+abI=; b=vqeLVRUZ9qcIRC8Q+SyGp2swQX6c8mqZPpwFE1kuC/jEFBPNQ1u7geZYhn4jS+bhTO3Pcp rbegrm+HqOkBncsIsrt4INP1lpABEbLCD+60nyoUde3kvfuuPrB7c0NNRg3RvtSLSX7vsl 7xuulAuZncoPwV93LU0GGdUirbzJs+0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710905668; a=rsa-sha256; cv=none; b=EUEuChT9XoMM6IapR+sP16qH/n0rx1JKLZzCSTF3phUshvumXsBj10K208/EEhj1iN6Pit NXdusS6X6AsuSO6iWmSnZCI8ASfU1wmM+viv2SZ29+SrAgkcQuEwmtq6nJuH8ZSZ5wxkIQ v/4Z9L0c4GVzbQNwMyfFm9cniT9q+30= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D5ZzB6z5; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Fmjl44mehHCSaJsJ049BqzU8nsY14MeWPP13ami+abI=; b=D5ZzB6z5MbJoI6zMuis4f/WsCg 88iH+1ueCQbgpQr1TiFTtRm81M1EIO4/+au/WGmzJpcmSqCFo9EfmHgugNfocoGInkiU0gpH9FpfK uPNaelLOrKVwvSXQDEvisa4gVDqHo5rE1vW4SNU8sy9BLELCk3CFf9OPLzrOeG6nsOu1fvoYl98BV c0iUFXzA9e7fo23DqdYvGWQI8exh8hbKV0n+OvhVIQGMTs9U5pzYwqnyIgr7xy9Fd1wfRSF+ddyJL 6lQNhq97mBnpvm4Dmu0IRPcwSz2ZDu7ofFfE+dsi3MCQgjTpEEBhV+VYDoaRJwg0gZUhvTpB70Op6 K9BDf3rg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmiK-00000003PYS-3S7o; Wed, 20 Mar 2024 03:34:04 +0000 Date: Wed, 20 Mar 2024 03:34:04 +0000 From: Matthew Wilcox To: Jiangfeng Xiao Cc: Kees Cook , linux@armlinux.org.uk, arnd@arndb.de, rmk+kernel@armlinux.org.uk, haibo.li@mediatek.com, angelogioacchino.delregno@collabora.com, amergnat@baylibre.com, akpm@linux-foundation.org, dave.hansen@linux.intel.com, douzhaolei@huawei.com, gustavoars@kernel.org, jpoimboe@kernel.org, kepler.chenxin@huawei.com, kirill.shutemov@linux.intel.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, nixiaoming@huawei.com, peterz@infradead.org, wangbing6@huawei.com, wangfangpeng1@huawei.com, jannh@google.com, David.Laight@aculab.com Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case Message-ID: References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4A27A40006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: uhmmsfqrpo4bngsj58qc1oegp6tusd69 X-HE-Tag: 1710905667-506694 X-HE-Meta: U2FsdGVkX1+39t8TzvRGUKrnleuCZDQuj5+UOFOXJSP9t420Uen9OGc40TFIJx7tTT8s6pehvm7eABnPJ6QBVxsEfMbQWuKLJcbYa2Vo9bEnHD3Kzoda8fZDXPxVCMGD8Q1Sba/g78xfW3lES7SEAf0bNgPUhS0iid3bYSSPGzFAzBCdfJGtG1yhSj7H6AsnGlerll3lbF8aeOpb/8Vh/Bv5kBF38F458IFqKlnwyJ0gJVifJDX3gA1xmxKcIYA0sNCa18CE/d6sTT5nfmhjcIjIJuaSU4W0OpAfirrE4g23/1i8dvPiejFjqkK2PgO1LPtjrxQoPJFilcjIODEIOspv+kG2hjjfnxxn7exHIlag+daGSSt489WRyIT0tLmEKY1AhBEsXT9CAdvgEoawJMugCzvC04SMg+91RW3DMQNZiYaKB0glhQ3bFA4oj0jNrJWmj2t7Ui09/3o+pbf8OtMMKAKbgawGqv6dwPTUvc1ggcppIeAZaxGSq+imJli3MaQpW4jCFtHcVduEkIaANHbRiVt5O/QSz9dZM3ElF1CeeQYlFKdmDBcFegEJbt6BJ1+TuoiKDIE4gW01VQPpQIEyoFbda8YUGsN8S/qCFfE/3D0/BtTsFnvcTeV/j/H6F8Aa0D0xD0V5NlJFUOal7tDQjJUGfzbiSQTFgzYeUXylpxO+SJpOM/1XpcREukX43TRZrK33ULv4au8592Etfdj8ewvDMC++ocHqOJd2yE4To2xrbwC4Dk09gH6+LbO6kG0+B0T8KqyfzWcbeer+58QzzqqjlzHboOSFozccPSgtjGHYGajiyVRnPOsWP0/7loHrF+yVICXbMlqdREjKek0d3RvpFrXKsqd0B9uFVxuQNQZhWUbxCOZZcM+Bjr6pN1e0dAobRLYsqIeBPyp9OUNWhW5vtpqhf7WFSIvvlAydCFDNki+1jb07jlQa2PgwL3uU9yogSuM0TzRsSu2 nDOjDmvT IWQwB8TClzfQO2UiTzVjzRxD7EU0GLhj7O4TTUMuWIvSZPsZyl+BHKVVeeUtWeYk5IlcEDIaGAc/chIuwwwyG9OxbW2uO56hH0Qn2NEvnol/U8BHSEHjZonX8ATxQsLP1BJ+08DJoUS+gS0ogWGahKvm9anBmzklEWahuF8bWco+oaCw8jbSYV7/I1D5TE9BZrfwaDTe7Cq6sdpOYH+EmzGH9Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: > The checkpatch.pl script reports the "WARNING: printk() should > include KERN_ facility level" warning. > > That's why I changed printk to pr_warn. > I should change printk to printk(KERN_DEFAULT). No, you should ignore checkpatch. For bonus points, figure out why you should ignore it specifically in this case.