From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB78C54E58 for ; Wed, 20 Mar 2024 09:38:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94F566B0093; Wed, 20 Mar 2024 05:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEEA6B0096; Wed, 20 Mar 2024 05:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EDAD6B0098; Wed, 20 Mar 2024 05:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D3A16B0093 for ; Wed, 20 Mar 2024 05:38:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3A2291C1564 for ; Wed, 20 Mar 2024 09:38:00 +0000 (UTC) X-FDA: 81916915920.08.42E317D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 9557680009 for ; Wed, 20 Mar 2024 09:37:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EFuQrpr1; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710927478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foisOSN3EsA17+OK/aCiP4+oKbxtANM1Kwrd66hkBBg=; b=2TWshMKd7wvK7jsZNFj0FhcAeNcv/yGXQUwy5KbIeOCiUc3+cu4BSXIjgjuC4ICKEeAoex ZYCxkDY1PYrhZ60BvQ16+Nl+ldM7TmKX3Hr7R2DREBb8WDbK7B3nzHJTqf/ljIMkklrUYU VHD4qI8/AaWoN8jZvBIDFjiddNkEMjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710927478; a=rsa-sha256; cv=none; b=eXAA8ANCuaguX1LKnOs9BzTFppCUSLfgU8CNm69pMNWcXcjAeVwdybRv8W04P9x9wQ6iVL 5M0IY4h2ld2AR+aLl7M52ZKEEsm/YgEUfq66y4KKTGWEwWEXvhWbCtzE1ED7TjemAEw5ht 5txO2EbafdrnjP0vw6q4K3I+9xYXmwo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EFuQrpr1; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8652A61000; Wed, 20 Mar 2024 09:37:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA07C43390; Wed, 20 Mar 2024 09:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710927476; bh=6en8ZZ+fOEyondqQ+Wkc9mV58Xe+D619z940m0qzrm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EFuQrpr1jzAOMq8F2IC3MV1yHDLmeckZtzWRKrHwdvnnIsPr3aiWwWV0UCpseJgMY CLVANZ2nMu20Vx/v7G0qEug+XY6D17CKFoScSKv7iSfSJc2Mk18dZpNZn4XDJFWD0v D0+Iz0wZTgbvswkA8UBsLimhMs893ReE4MErG0J74+jQX4sBmANFRvKSvZ41ojznqH QuINWdgXEerhnWjAkQVXdAWfUcu3ZMhme4xnes4TORjpi+glPdrPb1mPMv70cHmNA9 fONx+GdtQX9iLu0n0AOPGjt2ahtYbmAaywQkrxrgvSP6aksTyWRav+DygUuV1rn+pp cjy7ab8i7wtKQ== Date: Wed, 20 Mar 2024 11:36:51 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/6] x86: remove memblock_find_dma_reserve() Message-ID: References: <20240318142138.783350-1-bhe@redhat.com> <20240318142138.783350-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8z17fjudikpnj9seext4qgy411fdmpdq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9557680009 X-Rspam-User: X-HE-Tag: 1710927478-170393 X-HE-Meta: U2FsdGVkX19Gb30xSmcACxShtIasLXiRBoi31F2UVscwxR48WfLfzNKekyvDWetrHYphJPSAY6quQgpNhUyiTW8rkfVD8NVXWUcDZFF9VxIhgqNPLnLIaRG4MszBGGR/46PVKeOWZ0fqBtCu6oL25nxcj6/2BIc3OxCOf9Ca5f9ITKo8a5CHiBmupmGEzrgw8O/cYv+rkZJpQoLnj+hWZYkjtPvUyDqlAm/nuu6HWqpep9LHwWPtHcWk2pOjpYbBVEqXPjQG3yPspt2pVuKSqPOfZLXI5hHGZsQPX/0D1cHunfyez2d26vpimpVfL9HdeyTKZgrM01/FBw5+6RY6EqdD7z3K6987jb57HAiTONiujO39g8OsRW7u9qr/fsaPFVcBCx+CAOe2c6RPgSrzT5FG385St0GqGBrNxYehGfZnNjHWRXX3WCRr6lZjzPaxPTLOy6W16fM1EFHidQJmmd0mq60faakZIMORw6OFrrvvp9uzGEpKyh8YWZ3HmitpNTLiHe+lm4KTLyYCqoAvFocTtALPISRfeaINjEd1iLe6r/lNCWWf9MsCEDkXhb2yo370Q2ZXKgZEYPNr/lrmlLQADt4yBPbQ3nbyJAKveuSZJG3Fv097TGlgpw7skWvskRn3XsYqwqhBfyXjEWb3p0IbHGXA4n6/XkuoDsoldmrzHyFhSIjrbZLHxcqWIk9qzofu4zx8Hsh9JtCSkhXkcGbt4LFF4sNy+Zq1aNrdRMPV/jFArf6GROCM51T0f+oqWnCQnCCG8nBoCu0iCMzLCI8+OiE7KIIlZdy7Tzc7dIWPLo/LI4T2ZuEZp/Uq4kUg3ErDVGcnM2RvHmfwrqeIu96It+1jll/MWxNKevmO13aa5LwuHQq6nlbmR5J89GOyNUOrf4n8bMC4bCKBxSJJomtjjrtuyTS5THPYnSYhbAlN5Y4You4+ojbYWrPd6hW5PQimPufjsL9dnpBRpp6 xUDCkKZl 8VcJ1h+pbaormm4ymAxHRWfuJwDCHuiieMTNtqksHrdTwheTtNdj5wN8r7mCcoKkkxUClfYXE6k7FbsFwRVbf28WTca0W4AhqIQXo5j6WsSKbfRth4n878xuvH/U97XQBVQMZmnHSn5ei6vTE4Hc9k+r70WMXPDn2u/v+EX2x8498Y60Qxt4jiQJuB10fTefVs6CPEdRR2LXOGUlYZrbGJwlKtWeM1I54vnGrQhqfv6Ha7OI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 03:52:52PM +0800, Baoquan He wrote: > On 03/19/24 at 05:49pm, Mike Rapoport wrote: > > Hi Baoquan, > > > > On Mon, Mar 18, 2024 at 10:21:34PM +0800, Baoquan He wrote: > > > This is not needed any more. > > > > I'd swap this and the first patch, so that the first patch would remove > > memblock_find_dma_reserve() and it's changelog will explain why it's not > > needed and then the second patch will simply drop unused set_dma_reserve() > > Thanks, Mike. > > My thought on the patch 1/2 splitting is: > patch 1 is removing all relevant codes in mm, including the usage of > dma_reserve in free_area_init_core() and exporting set_dma_reserve() > to any ARCH which want to subtract the dma_reserve from DMA zone. > > Patch 2 purely remove the code in x86 ARCH about how to get dma_reserve. I think it's better first to remove the usage of set_dma_reserve() in x86 and then clean up the unused code. > Your suggestion is also good to me, I can rearrange the order and > repost. -- Sincerely yours, Mike.