From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2FFC6FD1F for ; Wed, 20 Mar 2024 15:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62BF26B0089; Wed, 20 Mar 2024 11:20:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DBFF6B008A; Wed, 20 Mar 2024 11:20:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A3566B008C; Wed, 20 Mar 2024 11:20:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3BD326B0089 for ; Wed, 20 Mar 2024 11:20:17 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 07CAB1A1425 for ; Wed, 20 Mar 2024 15:20:17 +0000 (UTC) X-FDA: 81917778474.27.4B8D2CE Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 212E8A000D for ; Wed, 20 Mar 2024 15:20:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O4ewiLp7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf15.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710948015; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fkCsEo4Bf7snePHiuEg/lPMrLlUywl5gBYIKxRVm4qE=; b=A/RfO5nzMLh1cLC4bHn5B5eSVpkkRW15DG5MWKWNsMzSu6FwQZiso7PTSK3/KcOW5+XWls RZWg4cKueE0uQVSPcmrnQOQfwflGfTFWd4w9MT6n/ycBxN7y3c5ePbFRooexTtouAVDUZx 51ngulfmT5N1sSBy9+LQ3AKUoBmvBiw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O4ewiLp7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf15.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710948015; a=rsa-sha256; cv=none; b=2E2XgPQmn0xzoolciH9A3q8Eh3oPlX8NaGUhxLnoeCg0JWOhIMLD0A6Av8Vji1s+Xq61Xk w+pna7q7wxq/19qyRQwAzY7wrNNkW1/nyqcAcvsakpUQOeq6WsAgYprfsJF9pM659Z0ex0 6loci8ni0btZubtAptRxLZCUQF0Z1F0= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-60a0599f631so62039007b3.2 for ; Wed, 20 Mar 2024 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710948014; x=1711552814; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=fkCsEo4Bf7snePHiuEg/lPMrLlUywl5gBYIKxRVm4qE=; b=O4ewiLp7AOZrWA54PsCG/Lk6cZfE5apxmklNWd4G6vhXaRoxAv3RZ7gXpqWL++JIsN Ac0TDC7OLcWyg1eKaqo6G21XfQXLmRBQ2oJU/XyL6vYpeNP9oBbSg1MGPEPPI7PCK8MB IGpQf2dnm8XI9EIIpGbxED29eZgVckioKfUf+YtCSNE4auzfS8SvQkwsQkeyxQIqerhn Kysg0s9kVUYeFXOjHkznMiVZpkv9LLty0hmjW3NE+OcogDRw67YKoG6z7ThlKdBcJjtH O+4C4VoFpv27VcISMd6EjNLuWIKjKBmL8GMufkHr09Tvn661AlmO2pHVEX1Mzl2OlrxU Ts6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710948014; x=1711552814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fkCsEo4Bf7snePHiuEg/lPMrLlUywl5gBYIKxRVm4qE=; b=v18VOYtxRlcT/Yy2mllfl6Eg5dowIfZ3MUteeE3D93//SJP58qKPZjX6vzPwoGmi5G LuJJCuTjSo2DXNJ5K+gpR15dwKF+pubJI6O9fME8/fmE+4Y2zp4x+ng8kQ3AZqD+q084 ovtGvNxdAttx7ApGbJ0YWD3iJ2n4FvlOcpUvarE4r2jDbFtYVr/szJ1srbDqndtc009Z se8khJvEkpqncSPeWD8qFDSiwRRhlPRGLBqOI05aXZvOjuqvcAsXP2s0BwkwmZx2p6pq Rlvo88XqY/rl1lfNQCZxjdakvBM7JhObCd/4VAmwNpD6AFqLU4VkxLRs9//STA/djRJT Pvtg== X-Forwarded-Encrypted: i=1; AJvYcCVqgzabfTwZegU6///v4+uXywbEEMChOiqc949SL7RM9aFT6cpqFNEd5ivsJSl6VIa2TKr+wSQOQdmuGDoVDq+oWCg= X-Gm-Message-State: AOJu0YxqtAf2zTQ5ftFneVLTDZYDd+yyDv+wx8FtZuStmqkBLwdtLU6U YbgFDRsM4QtBa/kXJYs9O917dtbIYyHw4PkGo/0Y/h8vNX+j2NZq X-Google-Smtp-Source: AGHT+IHanjX8/lQ8OxvojHk6r0sfMoxcnrCz64hpQd43RbD8WGd14eKvB9R6pdt3kBfrQOp21ELD9Q== X-Received: by 2002:a0d:dd12:0:b0:60c:f1b0:1eb1 with SMTP id g18-20020a0ddd12000000b0060cf1b01eb1mr5934741ywe.43.1710948014198; Wed, 20 Mar 2024 08:20:14 -0700 (PDT) Received: from localhost ([2600:1700:2ec0:58c0::44]) by smtp.gmail.com with ESMTPSA id v3-20020a81b703000000b00610cfeb2718sm1226060ywh.80.2024.03.20.08.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 08:20:13 -0700 (PDT) Date: Wed, 20 Mar 2024 08:20:12 -0700 From: Tejun Heo To: Kemeng Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 0/6] Improve visibility of writeback Message-ID: References: <20240320110222.6564-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-1-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 212E8A000D X-Stat-Signature: xmq5u6ahmng3ms7ypg9om3o16p8gjj59 X-Rspam-User: X-HE-Tag: 1710948014-189524 X-HE-Meta: U2FsdGVkX18Bt+24t773uyfH5Bf6Oxfc0H+Y9HoFckxQYlM1joqAwodl7r4foY7C04I27/f6u9/a5yCV9D8E34veKL9SX0GN1hS64mWn1SDmNNQ28lpzcstOYfipzMIegx1LniOx8d0neX/TPdY55nR0soU9Z3HYlJqPF+V8TeVqUmaiEZRB46Kjkjj6L6PXpcajIxON6fIHknW79ivN3ibOh9Pb/I9U14jKmrXGfIMw2F7EzbM9aqjqIcyylJlAB7gQpjpn96EHgqxIdPnga3uKurkr1FTXTbiHpFr6YPQcWEBaOxB77abrsUiadGcXDF7SQdLd28KC9F8OptktYU/VuexpQ2D+nS2lCacqmvQY73+UR+s+a8NsSFlNIm1ng4wtDP2ARmarkbynMa7R/Iy+Yl2cvHd7A7kmunGOZIOle/UnVMQ0z8eFBe7+yD5/t4+NMLyvxVd8Be+5ZTN9Gzmik8guN9Fh+RkyYcdP5nwXm8EQRvAOJsgMCMg3vcYqpE+PzRqLsAmafNk26H4AXBCs1LyB1zaHO3CwBNA9MQwXfF3UHzEyPS5QAA7vRirLuT13vQofheIlY4lrV2tyuA7oNBemzdJ6Vw3rEB7b/TLzHmGwyNvD4Zzzjrk93aAO7ZsVyzrcqlLNH2lxMl6mCo4QSwKfHEzHOxIObqo5gr3wx7ALjmbtJN77WnROa6QEmlX8tPy79TzywKId9ze4WkRLfjf5jRLEW1Q5nT1da+bIGSayx0BfDPcXKZR0aUa9A+fiRnyER7mpAv2S3sGeqTtLMTd2s3+sPdJcknjUWtUlteFpMFhknqxtJewGS/HKkWz8sICdTrDm4uP+KspcYyoMZTzqXBAGyCjZB5inaQ0YYMm0RWjiBw+p9gmEkVF+DQXGNGDazXk1ZUilo52FDgsOcqAwHN4dY8MJ/W/cEt1w1EIwMM6E9mTubfbatBYEMznV2i2Qsk7JxohkDgd SVK5dpEI o9kMGppLB+ySk7SYcecVQAI2GB9CBgP4JfWOwTOcIoK34gQkLYF+H/4qnWRQLmPD1GSOK6GM4+BoW08PySKiw+vl0AuGmHq246ZyqdEbgmluwlDffIRANbJZ+3uNxC+oz6DgD+5vP9EdLDtk5bfgHFtmyFZTEJ0hdged3IuY03sa3z99rzkB73uJbXyTxCpGMhNZ5Ln3fuNV/S72PN821SGCDpBsRYiTs8FUC2H0CRWl0a4B/QonYch7LDMN+Xn+vBGoGCukZSyYL8Jcyr+B1gBK3oH5oRaWK30DZXcooLs4572R+TzCO+SvB+8ZpVB5CEmw+QAcwG7MfjZHoScjSV2/9i7Cq6St6WmKvFxVgWNhv6q6TQH/oYNpEoF05rgJe9HWhWE2tN6A502n6Mypv3VkdDGHO2+R/0HKT5SD2ARJPvbuCRniSLGdqgyxsU2kptYSIWOLaBwK/0kStbxBoPlgAExgO/hkK6EKk1DXq4QO39opUs1YdBiB3YLMAZRnYHI1b62mRybCH+8ZOh/d2sWK7WhrL8Bfo5ob+MUOb1WWZU/uvXxw/z/OfId2UPl7ovXT7cq7NGh3ajVzGA/7PRbS2OC0/ZwqZGFHzNdqOFJymzhE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Wed, Mar 20, 2024 at 07:02:16PM +0800, Kemeng Shi wrote: > /* all writeback info of bdi is successfully collected */ > # cat /sys/kernel/debug/bdi/252:16/stats: > BdiWriteback: 448 kB ... > > /* per wb writeback info is collected */ > # cat /sys/kernel/debug/bdi/252:16/wb_stats: > cat wb_stats > WbCgIno: 1 ... > > /* monitor writeback info */ > # ./wb_monitor.py 252:16 -c > writeback reclaimable dirtied written avg_bw > 252:16_1 0 0 0 0 102400 > 252:16_4284 672 820064 9230368 8410304 685612 > 252:16_4325 896 819840 10491264 9671648 652348 > 252:16 1568 1639904 19721632 18081952 1440360 > > > writeback reclaimable dirtied written avg_bw > 252:16_1 0 0 0 0 102400 > 252:16_4284 672 820064 9230368 8410304 685612 > 252:16_4325 896 819840 10491264 9671648 652348 > 252:16 1568 1639904 19721632 18081952 1440360 > ... Ah you have the example outputs here. It'd be nice to have these in the commit messages too. I'm not sure about the last patch but patchset looks good to me otherwise. I don't feel particularly enthusiastic about adding more debugfs files especially given that some distros disable debugfs completely, but no harm in adding them either. Thanks. -- tejun