From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B45C4C6FD1F for ; Wed, 20 Mar 2024 14:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30A466B008A; Wed, 20 Mar 2024 10:57:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BA856B008C; Wed, 20 Mar 2024 10:57:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A9A76B0092; Wed, 20 Mar 2024 10:57:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0C34C6B008A for ; Wed, 20 Mar 2024 10:57:23 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 56BBDC1402 for ; Wed, 20 Mar 2024 14:57:22 +0000 (UTC) X-FDA: 81917720724.13.FCEFBB7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 0063F1C0005 for ; Wed, 20 Mar 2024 14:57:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EVVWGDMH; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710946639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Szd1k6J35ASlBha6qDCIcbBM34pxQ+1tlBnb0g8bakY=; b=PudU9wSSJZej3Cuyw47rp8zzB4H/sI7ECBVrg0C2SRm+mGCb61cVxk87IU6CfSaVJByl/i Z20PiDQu5LTnPgguVTlufQjq3Rq9zxWZ3XUDvqooPhFaW7nAZIpW2aVEBWoA4ShEfk1N18 JvodCcvqnXcm2F8gMxNTH6KZWQWCNnI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710946639; a=rsa-sha256; cv=none; b=hdPl5mEE4n1YYmT46ilGncLX2ERDcT9O20Mnr2B3aF3I2kkLBwvMSVzqrKwIx9MMNWTUfH z2Pu1tKWzWEs7QUdm/OjAyjAcLyZfp2Oyt3vvobnqnm6Fogm8BJTV+MvsyyltfhLK6Zk2f 6kPmn1+8+qBPG9dkBYR+6CyfYjGjYk4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EVVWGDMH; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Szd1k6J35ASlBha6qDCIcbBM34pxQ+1tlBnb0g8bakY=; b=EVVWGDMHntouYHloCKFTSu25qU hLiwXHyWtSPq4aS6Hmp5aUxbm4R7R/zC730IRBc+tZMghRepCk60nZRJF2VJHmiPQy0U/7W4ocxyk l8pUjKGok21IIOKXID0r4WffiNWPtA4rok3tt2oLwx3m+O2LFh4U1Xsg88EyudMLo5afiNoPG9CbX sILZSufHCo1UOuSS0HlLZ/f5kk9sUQQwP6Bg4Ge6V7+EVra9CA1TQT58jW7W0Z0sAewpVghPvn7t4 gei9LJFhbncfTLcClsNHLTMe5rUC0woPmQDBiKsHZ0cTt+3IXeB4WnwjtWoxooWgsns1RAYbVQgAz J+AejQGg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmxNL-00000004Wkk-04sO; Wed, 20 Mar 2024 14:57:07 +0000 Date: Wed, 20 Mar 2024 14:57:06 +0000 From: Matthew Wilcox To: alexs@kernel.org Cc: Izik Eidus , Andrea Arcangeli , Hugh Dickins , Chris Wright , kasong@tencent.com, Andrew Morton , "open list:MEMORY MANAGEMENT" , open list Subject: Re: [PATCH 06/11] mm/ksm: use folio in write_protect_page Message-ID: References: <20240320074049.4130552-1-alexs@kernel.org> <20240320074049.4130552-7-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320074049.4130552-7-alexs@kernel.org> X-Stat-Signature: mf13wxsskhua5f7fzbety9yxgbzq9r8a X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0063F1C0005 X-Rspam-User: X-HE-Tag: 1710946638-84410 X-HE-Meta: U2FsdGVkX187mdqpB5BpxTbYwBzHeFxLBZCrX5MiBcjpUWPfSNRkAfWfUZxc5ke1sQ/Y0bPwZbdGPPf42iYSnLnZTKybv6AreKMNAxYYL9aodXMBuckb76dZGA7jd7otkddqXIP5yJDPfRsvjCvmm5aT5x0flbdiKdOOw/98EOHx91+2IHPmAnWKpQ01k6ZwAxKFJLneW14LjwbUyV2Le/Aloy/kwqJa9A5SlfF70emlfHNS8khH25u1qzDcYAOg+RFCIBduYn6qRpIQHZmYUY7gBPJERBBl6LuXMjS5QZ66kGSU81nBKjSm6VQ5x+Q6yCGE4V/alOB0WW5HROgrYIovrkWZJSU2sDHtatffXOOaFVqBP1ds3azKjM3DgPRQt/7LO+csr4zLOFdtJdij5mh2Syd3U9QtmCWeAKQ/YKiMINqR43/Su2FRBr1iSKeIySTZTK9bbxY/OCd8rrEHA26PfRRwQr5hVrslrD7R4JfMPDDJbJjvFM0D5Q1zuB/fTWuH4xm53la5s5p0rUNC5shqLF/L2Ufycq7FzxKGtNFm1TIYCeH+v8vXFBYoLtNDEUByZBBHKO+IMVH972OdfSjoH9DFi6GJ9/4nsxfV9V8a4RhfTszdSzT2KqRcRyqmEOX9ervy1KTO+Vl46XlkPgDWK8h/9l0g7O4cnoDD2b2IO1hYhgZI6JPO/ReGDqdlPvmk7Z1FLv3U5pTZXijEhT76sFfJnnCHR14BuUxvQlJIFq8JAhRTBR0L8+azlHbomGDvkeeSvf023UaCVsHcGjucXcRfkQfHVuL0YJ0vtqZ0hQJhxmf8p4yHUYkfjQXr7hrriTqoXMAaLkTQJvUI4lG9V1mjQKf2fQsLKtkdHEZHz+SpykUX31vcAN4DzIKZpMoU04vL8n8t1uocg/ye8Z0x61/jCf0gndSPF+YIgShbhxNK0uZgSanhYjtVeglcysEy52bF20KgZDkycDn W2p9iPsv CW7ZxwWr6dkXDMFTO7NGUCgpEjWn+jRwLuU6dwcU/22dUT/iYsacDAmZwgGVaqEdZbJpEzMgErRl8cl69QJbvU1hOzxYmdkRO8pU8qnvHwB95Sn2+2p6LmL63fKwGepEaIsqnLArKcm6uhITR+9mw2uLJMyjqR1Kl6j5d7QCImKpy8kkf+dCz+2gG2e7vim+Cpx0O+G6CHPugzcxl4ZTtOuaf8uLSuIAr/V4o3+IUQFx/ggAcgY/OnwuMPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 03:40:42PM +0800, alexs@kernel.org wrote: > -static int write_protect_page(struct vm_area_struct *vma, struct page *page, > +static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, > pte_t *orig_pte) > { > struct mm_struct *mm = vma->vm_mm; > - DEFINE_PAGE_VMA_WALK(pvmw, page, vma, 0, 0); > + DEFINE_PAGE_VMA_WALK(pvmw, &folio->page, vma, 0, 0); We have a DEFINE_FOLIO_VMA_WALK > - pvmw.address = page_address_in_vma(page, vma); > + pvmw.address = page_address_in_vma(&folio->page, vma); We don't yet have a folio_address_in_vma(). This needs more study, so I approve of how you've converted this line. > - BUG_ON(PageTransCompound(page)); I might make this a VM_BUG_ON(folio_test_large(folio)) > @@ -1505,7 +1503,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, > * ptes are necessarily already write-protected. But in either > * case, we need to lock and check page_count is not raised. > */ > - if (write_protect_page(vma, page, &orig_pte) == 0) { > + if (write_protect_page(vma, (struct folio *)page, &orig_pte) == 0) { I don't love this cast. I see why it's safe (called split_huge_page() above), but I'd rather see a call to page_folio() just to keep things tidy.