From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A28C6FD1F for ; Wed, 20 Mar 2024 15:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E31726B0085; Wed, 20 Mar 2024 11:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB9956B0089; Wed, 20 Mar 2024 11:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5B4A6B0095; Wed, 20 Mar 2024 11:01:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF3976B0085 for ; Wed, 20 Mar 2024 11:01:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D61DC1A143B for ; Wed, 20 Mar 2024 15:01:35 +0000 (UTC) X-FDA: 81917731350.19.ABBEF1A Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 7A592160048 for ; Wed, 20 Mar 2024 15:01:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=divz7lC0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf08.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710946884; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a/Y9ZMfO3J09Mar43NYCGm0KZxucij/o5mhyh/HvBdM=; b=1FlhT6dvckfnJ8fzLe8ZRsza4P1iFZJdFk0Q/oAMRi/e9ZpBM4LoRJ6Braet1qy+zEoIPA laSLFd31qPQEeMxA3p7E0IpHSHEfbg/ejM9ds4hyNOfVCcmGX7Z1IupjPXpa1T0C2m7iYU oAUgLKHHU6XU0ET7iQGbLvcmnziqTug= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=divz7lC0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf08.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710946884; a=rsa-sha256; cv=none; b=txJRbwUm0hlY8GmV158djAQ2DkGyY6VYaUBEgHCdoiYAOliDgg2LZXNCXZyTTJcho6etEI iYsDX8/6PWPyT/vGPrttUHxwiRAb7SitaZwPK6TezqIJ5usqhFAXcRUxhQZhx4pbyENEe7 MZ8lkBdxHROhoyZCIunexKm/7gvRTkc= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-6098b9ed2a3so64163607b3.0 for ; Wed, 20 Mar 2024 08:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710946883; x=1711551683; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=a/Y9ZMfO3J09Mar43NYCGm0KZxucij/o5mhyh/HvBdM=; b=divz7lC03EtPHFi4KpdLsGTHdSz4ElOa5jRkulKpQrAkmJ9YhW43HRfHXoiy4Vufhc t8fhAne7J0oqFnMCYsNUwVyoF4e3ehWiZg5Jh4Uw8CyB3oB7KDgm+TIMGW2npdn2/mc3 ZXp1iBzte9NbTurRsAsa2tS9e0n1CmfmdtVcvzoglDAzzBGqhgCJJ7N9orvKcDt2nyC2 vlndjTFkCKlHrah0kK2yT8qqhds+nVALA9jYuWQBWyZSgowda2Ggx5O49iRz9zV9kMev 529rpt8c8ti/uXtsWAZG1HckJtYt6QnjNStRr9Ov7pXSECpCNei4OmNkOpbyaSviCXxk Izdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710946883; x=1711551683; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a/Y9ZMfO3J09Mar43NYCGm0KZxucij/o5mhyh/HvBdM=; b=Ys1C2q+MhmDX52Fp00Xda/LPmVF7d3LOKP1osvKc59eF764Sp/tCnkPU6aNfXwpq0U B35NCGNkvbP039kB/BNfoixyhSUfFB6gIbZhEB4OIM9djr29OwxHsJ7uQRPnKSKrvdIE ghTBxV/1vFcYVt+SpSIwHIIQeiFd9EmU1J6ZYe33vX+uX3oY0iVwYfQZ9SltNFym4cjp qhdTGfyCIDzimXF6XCurUCnKe0uB6EFwkUi/mcyFkek/pOxSWBm3kyNlmiVxbwy4EyFT FhCjkHW1IpiPIPE3U1g1QEfX2j9gDqj0U9hKrSAoohpKFxrRHCEgoWWfAiHZ+vPdnTgq Dxbg== X-Forwarded-Encrypted: i=1; AJvYcCW4rGC4mvDUQF3VrNWLSZ4/A7SDgomNvt8UeGZDPhGe/DRYnBKIh11K6/lfddH8S0T6667TtUtTh87wGJWGDuQE8lc= X-Gm-Message-State: AOJu0YxZBaV19++z1VrfJpUVdFERp4q9KeRJPU0ATz6kIbQanCqxbABN jVDGzWCwH+qoWkzT9dT6/CpHiva1dyaKgobxDPiQD0W/bv/4lwgp X-Google-Smtp-Source: AGHT+IHjPaOvJ970QixGpEF5AV6WMUBFUeINTSBQuqjCg3fk6IZAip/bPRH6Cjfjbe/vjM8AEiymzg== X-Received: by 2002:a81:8446:0:b0:60a:3020:29f2 with SMTP id u67-20020a818446000000b0060a302029f2mr17584014ywf.11.1710946883200; Wed, 20 Mar 2024 08:01:23 -0700 (PDT) Received: from localhost ([2600:1700:2ec0:58c0::44]) by smtp.gmail.com with ESMTPSA id l23-20020a81ad17000000b00608aeba302dsm2841301ywh.14.2024.03.20.08.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 08:01:22 -0700 (PDT) Date: Wed, 20 Mar 2024 08:01:21 -0700 From: Tejun Heo To: Kemeng Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 2/6] writeback: support retrieving per group debug writeback stats of bdi Message-ID: References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-3-shikemeng@huaweicloud.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7A592160048 X-Stat-Signature: ozk4s1tefjyseyp9jb8kmssyqjbokb9a X-HE-Tag: 1710946884-425904 X-HE-Meta: U2FsdGVkX1+iiSXuEuPJgiPTU0ZW+8wlPGJ3Ts+MqRwhDNApB1ovpZCWA26OhWsFlGeqiSGekCOZRbJdgMKUG+JkylnzXBTdoRzTL2BAt0LvPm4L/pPshvAeNFdAY0cxkkd4MmJSqKutgDjsxF31JH+CRWWcDm9XJWpeViYZSQwE8NqvUuYpL5J3OiNttt7sd8sg3gK+mGvZ4Qmpio3ihWViN6448/uh7XWcNvHNAXzYV1tFQ0hcIvQ3CCdhf0FZ7FCH8HvENOz0ldSk4+vkNlVn7M0ZG4jFQiNTIUMuHuLCAN6X2F0VzJsYzYYNjGQZCs2v63QWM9A0dfqa4KDtW5Wfoyzd50T1NSFez5f0QS9RTIdcu+1VZTRlaHrp9+O7BNH0KwxrQ02UJZWJOO62BbzUcGhogv4VovfV1rsmnCLUXXH7PV+5xHrt72WLv8mHmcCau33zqyV4rPHF+sCvCvoY9i9PPbkalhXc9Dj5kpwIHztVkyNVgv1OxV/gOjTesEMeaSlIXgfnD9U0Ve0wnZT7W3DeKbkyzKaDvpn76M0XrVTIbVeMdzpfZqAtJx/iS/6i721BFBhyyqh9XEeZbBxRXLC74SC0wxhu0Auh8Yr5Ud2sO4iTTEvJXe0rokq9WMXJaoSJNJeSP0Kp5OGuJMbyrNqEu8q/yYSpCT+hhXYOJnCHBMpfovKJyDwt1nrkT94Q90KZGEBBVfZhX7QWd46jIJPGL3UG+LxItaUH1bYjBUcldGpVy44KogEBXLzmAMO9Vfg0pRASoUReXpxmDzBs2cMKzl2X1uA0mwgAI54/UiOur+Pbwjdljck0Ltw0fZmirpvlZ9aZ0R3cV0Zvvdxg9R64of3nypJvWnJ7cILIqVkVuTr6UIqUwuKPe2ZBibpMABMTgtPgiR99VW3yJA2xkDv5PFAar8+M+c5rImqAKYIRykiFqPKxxrJLgDDCc5tLWXdbswS1wFLunXm +uzj03dU lHQThpEeb3VkfQqsWadCVWOhjDZPnduhUQpEMzXYnj77AHGqgHKzvrLBNPrjmArAgJiRsU8noAyzpJFee86Dlk79WhumAX3WZ/oreGWqJCMB8Q703LUd7Zo3LMDNqOx6Q8ot8JcuDGLb/zb4OUGqpUzg1uVmEcH2Q1yncvDzLKJdhPn9AliSKQl1oZVvEwYoI/b35gLZ08Sh33aVeJ13i3cBAUjZFEy4L7SE0GMqtFpw0tkWtEtTssYf7SYWz+UN3d1Ol3nGwvMM6BpqudsKcN1PtBA7ehJg8x3vnVR+DC9xIWWrARlDLo8VKN+GO1MLtXCul4LeC4f55dMzdotV7Cxb/6Cp9HtDIWvT4L04RLHkDxg87Ia+433m/epA1YiDX9oIJjMGrHEGB1IHKF9X+BH2TxUi/FL9eQMiP/O01ZvPP5pJ085DzkWBtvXAmy7/IHzyQVcIcyClH/ylY7YK1raHzFk5MRH0F29EAr3eFcAAsmqZs5OHds9sl+Tyb1eygN0NrFpEZ/gRJVg0026ccHDvez4EoU80apkUb+t/5FsUluJEzAxcMkdDFNad7wsCK3OPI/mLNgyazNhomwXRsxUFoopMgDXQZLgizca8QCsJQTtc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 07:02:18PM +0800, Kemeng Shi wrote: > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 9845cb62e40b..bb1ce1123b52 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -355,6 +355,7 @@ int dirtytime_interval_handler(struct ctl_table *table, int write, > > void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty); > unsigned long wb_calc_thresh(struct bdi_writeback *wb, unsigned long thresh); > +unsigned long wb_calc_cg_thresh(struct bdi_writeback *wb); Would cgwb_calc_thresh() be an easier name? Thanks. -- tejun