From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A368C6FD1F for ; Wed, 20 Mar 2024 15:15:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F75D6B008C; Wed, 20 Mar 2024 11:15:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0825A6B0093; Wed, 20 Mar 2024 11:15:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8A786B0095; Wed, 20 Mar 2024 11:15:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D53A56B008C for ; Wed, 20 Mar 2024 11:15:43 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 872971A1445 for ; Wed, 20 Mar 2024 15:15:43 +0000 (UTC) X-FDA: 81917766966.05.881C046 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 87E1040024 for ; Wed, 20 Mar 2024 15:15:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AHKZlMDf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710947741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FOA1OkHSqNDNi7l6mSUoWp1Vti+dK8LMbsievLGAJJ0=; b=arWtRmM5UQ4lNNuJf9MpgDViojRcHswfNRMsW1QtGzkA8iysH4fO4vZXgLWepRr4+6NkTB ScnLAhiwaPL+j8ODQYddsXYucmw1PSeQoSchKcN/U6kDUmV3vqpwEr/1CWIoBj6lzZbk2s 96myysmKJqkuDbOlYAvfi1TgKN7xR1w= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AHKZlMDf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of htejun@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710947741; a=rsa-sha256; cv=none; b=XUkUukT2Ye1rFz+pRZTWjs7eLaAekLr5ACkOQ0ED3Nuyc7ltubRvgTCNO6DfyGCA2FfAWe jHd8eV6tNXBczze6GiS3Uv0I+z1d1n1PD1zqNQbdfop21hXuqnYeIupKu9UAq2vn3fMP1w h9Z+KW2pHzBUuh9q7Sg7DULjaBsO5QM= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-60a046c5262so66147887b3.2 for ; Wed, 20 Mar 2024 08:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710947740; x=1711552540; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=FOA1OkHSqNDNi7l6mSUoWp1Vti+dK8LMbsievLGAJJ0=; b=AHKZlMDfgLPbZlHDMv3QBaWs16lBpLsU+fIa19jNOZkREqDG3CksQVqRRCnINUcYcK YcKscqrYJB3NxShaf+C44f6Ew73BregYB65WJgNFUZAcMDBbhToZZZ3T1Dz3rhTNCrhY qFnvtc3xlHV0DcGPOIQyRdjaa2s4Ir9/U/WshG8evl6k+dQLxVt03/jfkjxlz4Gzc4Oq QSZGntRal4i+ldOHsEVunEMF39kxm5EOYVizzRjtypM7XeuWHg3zCc1fU689Mx6bpYUA rAMbXa/JYvjI2zgf32+EBnOuSVJk9ypwQ7Yhxg76qqVoLaTX0qiyFFygTYChtZLjuB3N C6lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710947740; x=1711552540; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOA1OkHSqNDNi7l6mSUoWp1Vti+dK8LMbsievLGAJJ0=; b=kid2pReBIED8oiEt5BnFl0TczA0PzD/H30Tq2ba3xVXKMBgZ47z8+pSMXeP3Xguvul zKgQyDXd1L51oOmFK5iV3OA5TckC9I/lU+LnRWOYAEJSxIbYpgd4ztUUdE8XnR7rTquB LAzTDhETg8Ru0tuoSFz4Vnb9YFzXC8W8iozqnhqMNcn3G6ssxfuClG4+MZtm95YWyx8z Wu8vQoEhruensnJDL9NV+jtqolFnKgUGX2+LsMmeHFwAzltcYI5UvqQQfUVXfaxlqY5l wv/1H/pEtZnIEj6WDDiS5WRDiNPhj0VO3Np771RxhqpmLduUNVgZHNuhCFYB/Y5VojEN WNqA== X-Forwarded-Encrypted: i=1; AJvYcCVCj8THwF4nhc6TyH6s/537d6nlgV5tui3i6Vs2E5kK7cFppXPw5detqW4/nS9uqL4e6esHr6TmJ1uh7Dcg5O7IKtg= X-Gm-Message-State: AOJu0YwYvO64kR7r8WAjUbfVEjXrD/k1DkUFzhIlsDwfBQ+heFOFOqi/ WbwFBPNqBiKaqgj2ms6PbGjuiApUtE/6eQEQHvp7s+0q+FZGtiSNPviKGYLP X-Google-Smtp-Source: AGHT+IGEIYVb+JrL1n5CezttcE9gCGyXAR4HdzsHEKu6QmAj4f10FkRx3+A/wujjQICo15f4K9DKnQ== X-Received: by 2002:a81:ab50:0:b0:60f:ed06:bee7 with SMTP id d16-20020a81ab50000000b0060fed06bee7mr6001464ywk.50.1710947740634; Wed, 20 Mar 2024 08:15:40 -0700 (PDT) Received: from localhost ([2600:1700:2ec0:58c0::44]) by smtp.gmail.com with ESMTPSA id s3-20020a81c443000000b00610b532f8cbsm1798449ywj.36.2024.03.20.08.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 08:15:40 -0700 (PDT) Date: Wed, 20 Mar 2024 08:15:39 -0700 From: Tejun Heo To: Kemeng Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 6/6] writeback: remove unneeded GDTC_INIT_NO_WB Message-ID: References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-7-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 87E1040024 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ci7uszfec4iqu6hkacm1ixo9yzfhe7we X-HE-Tag: 1710947741-429677 X-HE-Meta: U2FsdGVkX1+g/cHhsgKJbMipSMqfpAQJ6pkMeF3iY0tW9XfllzOjlw2SMZBIneznDvLBM7F1oHSV4gGPXio3VvYhzexjLokOoIEnn0znoVqp+ujqNpqubCgBPwfKIsxi5ewEDgtHwxiUr9CU7F1sNCLcBrnCWyywDv4ik6IStzcETJk92qDp1JPwiiXr5FU8mjpGLCcsAPnEJ0Txs5GGdBdb1gsMTXr8wNLsaPqIrKVshZlW7xLQyrCcdEV9q4q1n8jIaGcxDj911f2FWj3RGxeU7j1/MnTkj39hRZ5ag9+YvzanHRHpMjcKtazrkgm8PBup7NqovHjXXCrQmHQxKCkBIARFvIgPypmMkXl+v3iSLAXzfqpOq0WWkhbFo3Ix/u4CrCd1kyf6QKNnY8mbELQaI3khbzugVzbq889u0OxjBJx5zbNugC6jJHbKq0sAevy2firBlUFEZRI4P4i67y6IO/RrIznrG9u5n8IgjfU3PfSLvi2DVTfpTdLbjcbS0IQdw3Q4SgUaZEX7LcGrdsFimHQ069n6M6RRrkAWbEKT0r17XzwF19hR+4wvgU3FAvJnsv69Wv2LzTfUBMxThJPxThtaa22Sfb2MvgbmmvVjMJ2k7vDOIv429It6HjBMyAHXygN5AoOoWmvIFS2nfAuBqATtNDSRtEyFXgJIDj4MBw+B9mfLNOf0clwy8RIXykwu0VFAVaJUJ4mS/4xtwlNGR1rYtAqjchlk6RbAPfisws5arzA12D/C9oueJaePAaYgIHa3xV0ehHoHugFnuq3gpncVpjOlQ+zUoSo9NihiV0ep6iogGVJVZ3n9l4ayC7leimy0ivvTYL/BUS8awmCZkh62GRP/YHG2nEWPp5ZspMleBe9bOPrtjvEyB14l0XCTMZSxtnsgIYReIs0PQs3/N+SIMR722x9ZxTRjqYHBELEg7PQUv2mY5IpXKFr3kVyfmX5s8NOyY/HdmHF WXwdpkxu VqvGnqROrRrZXeNVKnTOa3x0KpuBP9RGiZKKOJFicbku/pBqK8yB5E8MlMQWnO+pm7xeuNojaGGBRwkAdrS2URgRux0FgxG5bx5GQE+gdRWOcTyuxFwaj9hjHmwhguI7NQ3Aaw/859rxzdpjwbEgirFXhoyaWJHZemEADQLZHwXjxysQpky8UWyPgwu+HJ8sm9osedTxq/djeJmpCf7R6D0ia4YQBYQ1ZcBHuX2/Tfzw3ulzJJ0Jg8JuCTZsxHNLoCxNtKjIOz4+2Ftc6A9JXcqOKj/pS29FKlYTYmJ8Xdkew59NcroKu3VJbMR4D8LAtHJSr9cz3FJax0JwdCZRCdc27m7PECr/dV7bMW75U4SZj9xul/+vOqiSJMg/kAtlu6UJYxTCbZiuoPSrbVpcLMRYoSKXHaR0WXMYdaSqb6AvAu31XkHnIN7t30wR82Hwu/kCQQZmxfYwpjbE/Ypi+271yZipQi/QMe4hK9QyTH0pYOsoP1KEyhKIBZ09JU6SPNGzJ1W3uR+8SYRD0nc6EjHwzcB5O0tEgE+CDq76+hcilaDaC+JSrYbQzwX+pBoXtk65O3bIvp4KONRPi4GyxKwlRliKJzced7+oL72hKEHbzPXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Wed, Mar 20, 2024 at 07:02:22PM +0800, Kemeng Shi wrote: > We never use gdtc->dom set with GDTC_INIT_NO_WB, just remove unneeded > GDTC_INIT_NO_WB > > Signed-off-by: Kemeng Shi ... > void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty) > { > - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; > + struct dirty_throttle_control gdtc = { }; Even if it's currently not referenced, wouldn't it still be better to always guarantee that a dtc's dom is always initialized? I'm not sure what we get by removing this. Thanks. -- tejun