From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42364C54E67 for ; Wed, 20 Mar 2024 13:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 781C46B0083; Wed, 20 Mar 2024 09:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 731A46B0085; Wed, 20 Mar 2024 09:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F99A6B0089; Wed, 20 Mar 2024 09:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 50E696B0083 for ; Wed, 20 Mar 2024 09:14:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F37601A08A3 for ; Wed, 20 Mar 2024 13:14:39 +0000 (UTC) X-FDA: 81917461878.13.123835F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 0ABF84000D for ; Wed, 20 Mar 2024 13:14:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JdNZFw3M; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710940478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ey4AOs9r3AsCA3ihOFSnMBOT4qisnZYJ1SOYp7h6Xf8=; b=ji/eyBicLsy9S4njVR3zv6e+suH/zHInDI1rbjTkpMLwMT0g4kEtvjrqkag4bZKZ2n34fU nuXmHC5Ed8yVEM/OGmP7noYLRaw8bxAgi+bphZoKR+YWPPk5xbez+rLwD5ZByWPOSxG+aW wSV6nsPioyoLvri8r1Akq6nGRFO9BFw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JdNZFw3M; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710940478; a=rsa-sha256; cv=none; b=DFWuukEr3zZ2yzKuCvlF7s5F0reHG4pyfNFHuoKIHkU7fMkgJCjNdxHOgdW5JWqAwmE2WZ MdT5CvsySWihCuD9LAFjnqT+MK726JkxP8vTumvmSxKNNa3J2XSvODbyzh77kz1O+8YA3T pX567hnYkI8LZjmmJHlj8c1JjBBWQkQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710940477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ey4AOs9r3AsCA3ihOFSnMBOT4qisnZYJ1SOYp7h6Xf8=; b=JdNZFw3MHmosKaRgFcbEQQhO2E3Av3mRBJC/MEsp1DtF4UKGcGVA7h/GEQgLIztn17jWBY esiEwIWM94QmOvNGxUB8AL7mpE/iVOMe4d5yL/Lebs/ZhvhhLC3gHifAOjyFLTc0PIbaZH Z/jD4rzj/h8TnQmM/lB/wJbDAqPdQUs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-BG7UvSxVMe6KR0RfzBnoGg-1; Wed, 20 Mar 2024 09:14:32 -0400 X-MC-Unique: BG7UvSxVMe6KR0RfzBnoGg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F0615868658; Wed, 20 Mar 2024 13:14:31 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E69040C6DB7; Wed, 20 Mar 2024 13:14:29 +0000 (UTC) Date: Wed, 20 Mar 2024 21:14:00 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/6] x86: remove memblock_find_dma_reserve() Message-ID: References: <20240318142138.783350-1-bhe@redhat.com> <20240318142138.783350-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Rspamd-Queue-Id: 0ABF84000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cf8dxbj1rzr1sy5khydycmps43igrc1g X-HE-Tag: 1710940477-350929 X-HE-Meta: U2FsdGVkX1+2/I/46Tu/oQVvZacnTKXL+/Hbp2Kmjcw2r4pbxDJas3yOtw0ClRwG2dth6DuLeddn4QzgjpqY3fzQTwhREG/giPwhg0fCvLGxN+rLCTg/DxMjMR5T3IB+iq9Yz1tJAiOWmtHmNg+bpGjIyirkb4aKnw0IqbaxVCWEX9r+eJq0PROsyBU6oqwDK5Mm/qLK5ODPimgeTizFMhLwYXM309JOYkjIoh0G94+jR++eFXoUPtUzuHjDUoa6jlAruV6efybLINnCvJ2vUAw4ORVofePkcMZTrsfDLDzfIcjlZdQrSXlOPkZvrbwUE/eIo9NXJIOkd97ik32qjCE+8aywB5rxcObh+/jMJSFcQ4iT0EZL63AerbXzuWQH15xbER+NjGGH9usAZWRGayXBy6G16js1+ITTbeukqZGs11bcdYjdtg0hvaR2jblJQwAvEBqkGpWt+BRimhzdVsr8XV8QTDqLgf3hJ3PVZw3ZzzPkcIAJR2+72psn7ZNb6ntst9R6PcrmtM1wkyADamVjRrHdyHqG07NXeWkJbSy+n7Cxp2fhQyo1FXtIoZ1/9vEKmNKUK7Z+ort7Dz0b68k4ZPGGIwJKzmgWLy9DZqo44TR9dpw4sLD4mbNtdCwDe+npcxVKxMriV/2I6luQ0p4lI7PxOr0Yz6GFQGBTgpgARHJtPnUlDPlYwOHbq6lJdILHOqBUqY/UzKdvlu3BYzhPdxnEb64YQ7N15JoB0lRdTxWTlSdjVMXxGYry1YIq5Q0CTgA6yumj/0Haxs+oz8j1cs8DCE7CY5sPsDh947FKUWFcGEulxWj9Dv8V99a7wh4+wXqaEpnnvRArlpG5BhSgc0kHe8h1AHgbjlOv9iXA8eNfu9jzR+ojWad/0+7Al67Qq8Xm1+N7WEd2ao8WUV6nN0gq65SWoDdrGjlJZZnyP3H5wWoEivzpTEadu9honrFShHN5A/6cRi11ojy wxvt4yTg uTOa9ofDfObSj00f+XNMFwloIfcgplWh3DbOqt9t4GEz2w/N4YccP/evoMD9FvVSpkvOH9GpQkMjpoO6Uc+pGsYLbGeZDmijzDY8oCr5jozuco4a+nZ4BPa647mr3dS5WRdIMi0tYrjcOxitmqnUiHAAENKPn2Dx8TbPorqOUcqZufrLczXpCLqLkJAj2nNzTWoW9GEnwlsZz0JDTNuU6XxNK0Tjh1ViYA5CkOtgmw240aB67hyx7gZHqvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/20/24 at 11:36am, Mike Rapoport wrote: > On Wed, Mar 20, 2024 at 03:52:52PM +0800, Baoquan He wrote: > > On 03/19/24 at 05:49pm, Mike Rapoport wrote: > > > Hi Baoquan, > > > > > > On Mon, Mar 18, 2024 at 10:21:34PM +0800, Baoquan He wrote: > > > > This is not needed any more. > > > > > > I'd swap this and the first patch, so that the first patch would remove > > > memblock_find_dma_reserve() and it's changelog will explain why it's not > > > needed and then the second patch will simply drop unused set_dma_reserve() > > > > Thanks, Mike. > > > > My thought on the patch 1/2 splitting is: > > patch 1 is removing all relevant codes in mm, including the usage of > > dma_reserve in free_area_init_core() and exporting set_dma_reserve() > > to any ARCH which want to subtract the dma_reserve from DMA zone. > > > > Patch 2 purely remove the code in x86 ARCH about how to get dma_reserve. > > I think it's better first to remove the usage of set_dma_reserve() in x86 > and then clean up the unused code. OK, firslty remove the only user, that sounds reasonable. Will change. Thanks.