From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664FEC6FD1F for ; Wed, 20 Mar 2024 15:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5F736B0088; Wed, 20 Mar 2024 11:26:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE7F86B008A; Wed, 20 Mar 2024 11:26:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B61356B008C; Wed, 20 Mar 2024 11:26:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A3A456B0088 for ; Wed, 20 Mar 2024 11:26:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 69837160DC6 for ; Wed, 20 Mar 2024 15:26:26 +0000 (UTC) X-FDA: 81917793972.19.DA39C22 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id BF00CC001E for ; Wed, 20 Mar 2024 15:26:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YrD+Wcvw; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710948384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6H2VrsJPvIBusad9w260eghYblSiBWSXqydVmnydmLM=; b=QTvsTY9sRxuNyt53Z1rPzjdzsNkFVkmZeifdDXfrgKoX8dADCi2mOJsz2mTaQU1+HSWejU U7sVYLz4IMgqZelMlY/cqNVCJW+pYc0EqvaIS+Y5Q9DuVnm7ZPMY5aCVn8Z18P7LRe6QIC yiwbmmNkQ1YY6eRJdXg/HLmz+6/41Ek= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710948384; a=rsa-sha256; cv=none; b=FKgfL5tLd0XWqYED0spKJDZTaJ5Yeoa1hO7UFqvCpQjbZKFavmWtKlNIQxygMr134MjJOu geW0wwxMijGnQo4RNML7T+50eczhYTKYeN/QpnPns/sPeLapDHWbkdkzujUvruSP+etKl+ WTRCkNv9O1P+Yun+brY+b2ZujyvzAB8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YrD+Wcvw; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6H2VrsJPvIBusad9w260eghYblSiBWSXqydVmnydmLM=; b=YrD+Wcvwx2bJM1ESgcaNERrVAe qEyALxKKXv8LwVp8hBZlatltvaJZ3KlGjjMjYFkmK429NNtMIHBhuRDGQTXHV4p4wzlxvKTKPvTrx G1dxO4C6YWUBjFlPwMko3aJolkShkKYFfdrWFxFZSvE6nXKaiLEKwx5pqI+iu/tPGPRnpjxeIQcbl dPZvdcvAS8opSsNWuZbKhKU+DwueaHI2KTE2SC/vDAD81NPL8uJsosYfPQl+RfGmqEyGVA+I3WD9X 1OIisBF9L7cra+PWumYnIEGry9/vusAXwTvyp+JMaeLX5U+SEA0bngKd61Z5i7VYywO40IfdidiVl GfM+5fig==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmxpS-00000004ZpL-0V6A; Wed, 20 Mar 2024 15:26:10 +0000 Date: Wed, 20 Mar 2024 15:26:10 +0000 From: Matthew Wilcox To: alexs@kernel.org Cc: Izik Eidus , Andrea Arcangeli , Hugh Dickins , Chris Wright , kasong@tencent.com, Andrew Morton , "open list:MEMORY MANAGEMENT" , open list Subject: Re: [PATCH 09/11] mm/ksm: Convert stable_tree_search to use folio Message-ID: References: <20240320074049.4130552-1-alexs@kernel.org> <20240320074049.4130552-10-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320074049.4130552-10-alexs@kernel.org> X-Rspamd-Queue-Id: BF00CC001E X-Rspam-User: X-Stat-Signature: skiy63sq38mmf3dzotkex5pbh7jcctxo X-Rspamd-Server: rspam03 X-HE-Tag: 1710948382-426790 X-HE-Meta: U2FsdGVkX1/ta6BV5B94nerk/c9YBpmSVqUjSCrCGR3rjmUKczLdbGn8as+lX3S9JjEB8qIsq9msO5qKTCtlS1t0/+KV2elAj57y+xL4E+MderNT1UQ2DJ18CmECHYsu+L6d8V0Az+Md62jvSuDls89OuuVjbdiqF/j2easgeg7oznVDxjLZUbrpxW5Za6Z2UeQpSweHEQo6FjT3rB4rYY87fCQ7ihWxjH2s/Pcq/xubJLYdY7wQH0l02kFuxi3UlL00d65zHl7j3XlT+QefSOFDw6l/vcOh0aig4Y6VaTGyvVtbkrcnlR2P5XGtzNCNHy4zIq6GIT3ZIwea/wxjto5FXAaNhF6pGEM+wyWir23roI9D0zuKv9/DGJJOTcy1COh8gFR/32CVIxDXOR1dIsNAHAvX7Fyr9t/ZeBw6KlMp2shsxiL+xg6pK++Jm1vdkkeSojsJ7bXPpGBs/G0N4jeSqrX+XSfHzmQMSq5MsMXKM8Uzlzrw2+93A0wU+uFjlbYulnSyScF4IEZLaSu1zAWznWP6TyLvi7tGN7mlUmw7AuxGIpa4dOOMO92KNtJobCEga8iW09zX7mQpkPRoJtNPGDo7maztc36gmQ+Mf8W2DdtrsQUMEvAi/1craEbWZYvUiu5gppcptrhMjNWNOKROVVrl3k4Cc+DvPp1Ftu271px524HEhLWj2h8rM52uHMCZYD+dAdZqlQN4l+23S2AFU1dO0QExFlaq070yyeh/vOV+TSgeQyXX4OXk4az+NR6kzXrN5chBPtLbxDONkkZwnQp1gh+WFTDx4Sj4C6wjxv3kpDWbDA4m+dqnhsaAW5Yyj+duIq7xm66kOJzWe3JbY6XbThjO3TBnbsFt8lOI608ErkPyw5l0oiIRoN4ArSohsM/viua4B68ShPbJg/0l7sBPcn40iKvi8pDqVa5mMigrOmJlqdl4ImBgfbl4eToVcSPzn/a+F8kPfFS 4OQd/bvv ZMjH92UpGq7jxKa6bJk6G2Y87Go4cKOBV628WnTFlnd9pYTV1sTSCZx4rMV0D3sBUbqTMMbdr0hVfx3unQ8tajD01rQEmX9p74oXefmJbXAe2j8y+QIR12Mrt6OHXWR0SV1MIXSXrKiT4XZGrhxA1AlGUqYV//UZekSCq5i1ualOozvnmszc3nCwWmTytEtD6nGQiuWpWG+Sy/bvfIjBFClYTl+Wg2py3xBcvweO3jGnWZNQctSyzYWqOaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 03:40:45PM +0800, alexs@kernel.org wrote: > @@ -1820,28 +1820,30 @@ static struct page *stable_tree_search(struct page *page) > struct rb_node *parent; > struct ksm_stable_node *stable_node, *stable_node_dup, *stable_node_any; > struct ksm_stable_node *page_node; > + struct folio *folio; > > - page_node = page_stable_node(page); > + folio = (struct folio *)page; These casts make me nervous. Remember that we're heading towards a future where struct page and struct folio don't point to the same memory, and part of that will be finding all these casts and removing them. Please, unless there's a good reason, just use page_folio().