From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Tony Luck <tony.luck@intel.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Benjamin LaHaise <bcrl@kvack.org>,
jglisse@redhat.com, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, Zi Yan <ziy@nvidia.com>,
Jiaqi Yan <jiaqiyan@google.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v1 11/11] fs: aio: add explicit check for large folio in aio_migrate_folio()
Date: Thu, 21 Mar 2024 03:35:06 +0000 [thread overview]
Message-ID: <Zfuq6thrgFB8Ty_c@casper.infradead.org> (raw)
In-Reply-To: <20240321032747.87694-12-wangkefeng.wang@huawei.com>
On Thu, Mar 21, 2024 at 11:27:47AM +0800, Kefeng Wang wrote:
> Since large folio copy could spend lots of time and it is involved with
> a cond_resched(), the aio couldn't support migrate large folio as it takes
> a spin lock when folio copy, add explicit check for large folio and return
> err directly.
This is unnecessary. aio only allocates order-0 folios (it uses
find_or_create_page() to do it).
If you want to take on converting aio to use folios instead of pages,
that'd be a worthwhile project.
next prev parent reply other threads:[~2024-03-21 3:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 3:27 [PATCH v1 00/11] mm: migrate: support poison recover from migrate folio Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 01/11] mm: migrate: simplify __buffer_migrate_folio() Kefeng Wang
2024-04-01 17:54 ` Vishal Moola
2024-04-16 9:28 ` Miaohe Lin
2024-03-21 3:27 ` [PATCH v1 02/11] mm: migrate_device: use more folio in __migrate_device_pages() Kefeng Wang
2024-04-01 18:22 ` Vishal Moola
2024-04-02 6:21 ` Kefeng Wang
2024-04-02 15:54 ` Vishal Moola
2024-04-03 1:23 ` Kefeng Wang
2024-04-16 12:13 ` Miaohe Lin
2024-03-21 3:27 ` [PATCH v1 03/11] mm: migrate_device: unify migrate folio for MIGRATE_SYNC_NO_COPY Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 04/11] mm: migrate: remove migrate_folio_extra() Kefeng Wang
2024-04-16 12:40 ` Miaohe Lin
2024-04-17 1:43 ` Kefeng Wang
2024-04-18 2:32 ` Miaohe Lin
2024-03-21 3:27 ` [PATCH v1 05/11] mm: remove MIGRATE_SYNC_NO_COPY mode Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 06/11] mm: migrate: split folio_migrate_mapping() Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 07/11] mm: add folio_mc_copy() Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 08/11] mm: migrate: support poisoned recover from migrate folio Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 09/11] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 10/11] mm: migrate: remove folio_migrate_copy() Kefeng Wang
2024-03-21 3:27 ` [PATCH v1 11/11] fs: aio: add explicit check for large folio in aio_migrate_folio() Kefeng Wang
2024-03-21 3:35 ` Matthew Wilcox [this message]
2024-03-21 5:40 ` Kefeng Wang
2024-03-28 13:30 ` [PATCH v1 00/11] mm: migrate: support poison recover from migrate folio Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfuq6thrgFB8Ty_c@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=jiaqiyan@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=tony.luck@intel.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).