From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8112BC54E68 for ; Thu, 21 Mar 2024 03:35:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045C96B009E; Wed, 20 Mar 2024 23:35:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F38126B00B4; Wed, 20 Mar 2024 23:35:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E00A36B00B6; Wed, 20 Mar 2024 23:35:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A5376B009E for ; Wed, 20 Mar 2024 23:35:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35D9816142F for ; Thu, 21 Mar 2024 03:35:16 +0000 (UTC) X-FDA: 81919630632.26.8EDBD6D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id D20C04000C; Thu, 21 Mar 2024 03:35:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QV51zt6B; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710992114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x06kTZu2ohJ92bb9dbh/vRRAY4NzCQZ3OSLPkpWG0KI=; b=MbIh7E1BaEeqj1Qac+u+9Jbp49dbO5Cx9rtiFWajr+dMNaOWVM3n2zyMF2mVPu1ImZkEgR zewiAwgbsLDTxGsWavKvU5N7KPEA5FowOttXmLM0aOPWJOi3Cxw4nrGuKW7AiCDM8gQwY6 fDEChrS+HeRD0ohASqydBhlf+Z9nEKE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QV51zt6B; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710992114; a=rsa-sha256; cv=none; b=Ceth+pQM12MgUPcqkUvjNqUH26qUCaCcv5JfJIW74C+AmiUM3CjNGP7SRG2B8lb2kTVX3p r0Aj/OF1SEkwKSWJZEnxMHFsOW/FelgXRhXDfFT3VpAcLMnDPnmnUsHmUH9U2MqO4Nabsv R/nlGLavhANE17NFuCNea8H1IJ2Zz3g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=x06kTZu2ohJ92bb9dbh/vRRAY4NzCQZ3OSLPkpWG0KI=; b=QV51zt6B/WhJwt2at7W0x5CIX1 4lfXEuOWa0uOYx8DmrLR0qh7QEGFN6PXOBCc7g/QVyexDl0ncFLXktyz7FjetZm5NMjX5/ZXv0xMY BHbrJBPOS5q4NI8guAdEB57/F0hwaerPSo6mqYMZTO0JIRvKtyEi1MEdWxphoA2cgO9oFZOZibyY+ 3dXOpUN2lm5hkz2UAqrVT0I1mXNddFuT0jyepYOGDsmWPivrZU1iBPH/w44xn5t9wP+CZW3woBQyx HuMng+3UjUVi1fcb7hRh7lhHk0L+XUdmevEIa0QOv6H78buhdI397Onq1KyqUMp7Fq2OYHAAozYrO Mkew50kA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rn9Ct-00000005p84-0K4Y; Thu, 21 Mar 2024 03:35:07 +0000 Date: Thu, 21 Mar 2024 03:35:06 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, Zi Yan , Jiaqi Yan , Hugh Dickins Subject: Re: [PATCH v1 11/11] fs: aio: add explicit check for large folio in aio_migrate_folio() Message-ID: References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-12-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321032747.87694-12-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: D20C04000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: eg5qnjy3tcgnpfd4tz67nz69aghz1idz X-HE-Tag: 1710992113-94789 X-HE-Meta: U2FsdGVkX18ZG+UPtdvNSw7Bc1unjdILdUbC7D5hD/b9hyPpLMC0IIJPDs6SWhyWkyGqMEJ/pSgYVjRDbKw3zXrLlbh/d8iSidfR21+srfovryna9WrSujF9nGe8aGzvef1FhxTiGSF8IzCqnOBN9cDsyr5PPUXzb0V1d39emTpppTcTzEUFkbqAkvzSm0Xh9jCnIUmVw/vx4rQmKIpwF2ERqS+ARS4M7Jq1rddtrhjPAWF54VlH0HVHokJRKMy6Dlww9Wn9NSuwbqa3FtzB2CJeWIhbsrlRVs3JTcuSVHnptCERNzac21EoedOeRyW802jFl5teJYCV8CHVUu6QpfDViZNmo7K6HQp+gj+wBX9Z1/r66hW3BuwzhMToNfAqp6vcgjR6ZbbQGwdgxxqA2lOj95a1IUQ44OHWGRcGK4dxjmZCQmqkkqbJX6JrTehTu2BkZ/EdtHaBKd/aMgLjsJYurXPgSMhsujxNNKPW1vJXGJWqRjQ7H+IGu8ZCf99cz357e8MeK1C4FTYwVG6Zf9mAuWvGHPctgsFn4nhJj7Bo/hGZ1Tvt2RemOVjzHCHTPYUU76SnM67wAIZsI3RvLtUlLS7d2MnGizV8XGgBU3tnSrTT5fDa+TXDfL2GAfwu48fVC+52z7DiCAih1U1PRg20MdMuMu2duhzW9ShrpyZ6hi2MJpDcKx+CMsWarowdpT+7jmFgyjGJYiXCvg597Xj+mniMmNkZRCphHFXoHuNSRv8T8OdvX6TQ4a0RA8B/Z2Bu/ZKLly3k9R7Qube+d0SBMOObGBMJNfebTtfn/9RbPYoTnoC9gnuLW+2PDqebnLBwJSPp/DDQC5Fd8ASqcksq/WbTKY4+zzfBQMVS3z6Q34h9xybcL9RIAIDxTE9AAPL+SHVizqVKAmRrfHXhZU5e6PmhcnTynfTUTtyvUIhTOmyhIEPPOaVpnW73aW0nfPUmfmHaJZrpQ0E2XJV vOsUQcp3 DlhParsW1TifkkfoCWxzc2sFLpLiQxnMBzJs9RtlSEDHUTYFeA6FIcNLgowSApfg+ECH8LzYGJHoan4dT99U/btPO8o/29fqeX0ROPSeyttsvGsENF2VJearxKZy+YNPk5pKTDOQFz02QyoP8m+0mrVwAACWnQVLfVZztqUDq/Xnna2fE+m8QtreKWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 11:27:47AM +0800, Kefeng Wang wrote: > Since large folio copy could spend lots of time and it is involved with > a cond_resched(), the aio couldn't support migrate large folio as it takes > a spin lock when folio copy, add explicit check for large folio and return > err directly. This is unnecessary. aio only allocates order-0 folios (it uses find_or_create_page() to do it). If you want to take on converting aio to use folios instead of pages, that'd be a worthwhile project.