From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E16C6FD1F for ; Thu, 21 Mar 2024 16:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA4756B00D5; Thu, 21 Mar 2024 12:49:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D726B00D6; Thu, 21 Mar 2024 12:49:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCE916B00D7; Thu, 21 Mar 2024 12:49:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B91726B00D5 for ; Thu, 21 Mar 2024 12:49:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7DBF1C1659 for ; Thu, 21 Mar 2024 16:49:28 +0000 (UTC) X-FDA: 81921632016.26.31A770B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 174A014001A for ; Thu, 21 Mar 2024 16:49:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gGi8xJlV; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711039766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V9mrRuAn6P0CI166dm0Zpc+lSpGuhBwRxOMqznP0Qc8=; b=iYam3Q2wCIcfQECRFFzmJs5UbrHbdfQPwYdeAsoDE65TeiriZFsyh8gs1H9bhEwfZpDPNr ecdetUnI2et0057/ClijhmOnkCryKHmbHA7Y/GoTEmEtWjSRajUI/40u2UXBg1B7X4EAQE BAHz1ZMAB0u9iqtkEclWKqW2DeifPe4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gGi8xJlV; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711039766; a=rsa-sha256; cv=none; b=yy27ExRhSArT/TQtFh84n78rtkQ5rkH4bkIknr8fklucrwAgsQJhb5vEIIq8UA8SVbtN5L 6/gn9p+HfVu7GGxj8+qDeDJ3pE7bF8gShc26+KshIkcczwCxgcWq19A25cIELDhqjbzwK5 JStxHXnRtNnWgphcqKcmnb6LEt6HA6c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V9mrRuAn6P0CI166dm0Zpc+lSpGuhBwRxOMqznP0Qc8=; b=gGi8xJlVLOIZ3mUkkfMoCqE6+p GYatoWTGuIQd5mIJqoYod0ls6FiejI1yWosjlReTKpX/4QcfgRsdMndn7H2he5AtOEWNIEMdv6DPj ZRkrHCddWZIHbCcvrE7/i9TnUatU/rJkC1W5mkzmB2GMm50FbmFnSbKcERrsBngy84FyJ5zDJA3ue b28mrMSpQRD3X9KSoKdZo5dJvgVF7WsSod91+d2J7u195+hFp7vmMB1eLvYgh26B8RIToR3Z1idYQ 7DqIqZWDxe4h3KOCq8qN6htm+cvV2ALDrz/yfvX53nfhNfOQ9l3tfg2VOFzpq0RrFF/sMMqgsASJ6 2EI1+HZQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLb3-0000000793s-1qG7; Thu, 21 Mar 2024 16:48:53 +0000 Date: Thu, 21 Mar 2024 16:48:53 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 20/37] mm: fix non-compound multi-order memory accounting in __free_pages Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-21-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321163705.3067592-21-surenb@google.com> X-Rspamd-Queue-Id: 174A014001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1wswz9rrqutzncbn1m8ja4yfxtdwt41i X-HE-Tag: 1711039765-919957 X-HE-Meta: U2FsdGVkX1/pLWE46nvEos+3xMozH+SULDNdTdw7fnKIt6nfgwbP1AgNYiKhyuABhbck/wMaOGyzKss7/nbJ/lWWcWJvwwKBmsEjTuDOBD8RXjGhFkso4zD4xNiOoLZilB8Nzkt4EbVM+/aBC2nXy1fEXi77VTnuE9kgQteh1IGzo/OoGA82V/h14yxUDqumodFrgcgap1RPguSjMCFc0tGCFcjJHq2HYGZNQAgUI2QkripjtloLCxklTV9teYAri8MlAotR94DCMPq0R60X/C191bk9bfSmraoG8iFXrcjoB86A1m3hIGEfaU7sWIdLmo/71a3wxiOfL3TIMaxl0PDHposG5irFeRoYsTlBlxmICYN7Nqk4gyvibl8+vFflMltqMp9hsuBTwj4FfekGF3HILtatG2X5q9JsnI7ifSsy4U4BchL4JETmCwx/6vUpyfgeqGN6NaWSux8KqA0ccjZekXmdmb1rk6OjLH+4iVRG8Mjz5KT5iLC9eAe9sEqvWED1VMWJoh4pXPylfJXKmAR0S/QFODejWYfyZR2OEp0bl9uWAXRwuoDMW7gPgayWHxCiZ0jFItAu4ocqsa8aJeY6CMXTDOhLSuS7OnUwNoxxXiKD49pjfJG2GUuPmf0+hrRUAbAV/Kd7y5Ea8v/kiKyCpY8KM5qEk2NFo1kBBerJ0ZHtvhNIwsibSgX5XUgs7nJ+AdV3/3+TMqxJnghiW03f+kE0vjqfpLIjmZc/PoRZZANtubIhoJk33ZSQMix5TA7BqaXBAJcINceNAB0YCe+iZGm4aeV+EV/71O5IMESAby7qv0fgrybMhjHso9Nryc5AvhmrHJqgjICgX1LA0KNfIBW2RYWTpf7NJR9ApoRPT9oxg9wEvT4PxOvjn7yg1Zmew9KHWB1wkJBdZymSsN/nR7t8fzbso4/e0E2ipXZAVbp/kUQ2NWyydGJp0CkfBk22Li2aSkhipf+V8th XXV3rEYn X6d9IoZzV2UPXnp1bXXh7LZp+bRztjeZegnnX9Q30mdqxg95B6bEZl0PEpGPmXK2Ns/ymhpzEKFXFvVfcXZVOxrv11HIzBkJguCPb3tPosw8UINQdZtNj9jf/uvJtTCgHS1tMeo2vXkGYuj7HtfbdU9BFXexr7w0MW6+csa3msjCwGPVfUMLWc2f6wdStXUVkpl21mnUvgnUsMgI/jOa0Cqm+2OsgojXkwhnUAqU8toW8VwlJWi0niKNKhkS5bEf0OgbD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 09:36:42AM -0700, Suren Baghdasaryan wrote: > static inline void pgalloc_tag_add(struct page *page, struct task_struct *task, > unsigned int nr) {} > static inline void pgalloc_tag_sub(struct page *page, unsigned int nr) {} > static inline void pgalloc_tag_split(struct page *page, unsigned int nr) {} > +static inline struct alloc_tag *pgalloc_tag_get(struct page *page) { return NULL; } > +static inline void pgalloc_tag_sub_pages(struct alloc_tag *tag, unsigned int nr) {} > > #endif /* CONFIG_MEM_ALLOC_PROFILING */ > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index fd1cc5b80a56..00e0ae4cbf2d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4700,12 +4700,15 @@ void __free_pages(struct page *page, unsigned int order) > { > /* get PageHead before we drop reference */ > int head = PageHead(page); > + struct alloc_tag *tag = pgalloc_tag_get(page); > > if (put_page_testzero(page)) > free_the_page(page, order); > - else if (!head) > + else if (!head) { > + pgalloc_tag_sub_pages(tag, (1 << order) - 1); > while (order-- > 0) > free_the_page(page + (1 << order), order); > + } Why do you need these new functions instead of just: + else if (!head) { + pgalloc_tag_sub(page, (1 << order) - 1); while (order-- > 0) free_the_page(page + (1 << order), order); + }