From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20F3C6FD1F for ; Thu, 21 Mar 2024 17:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27EE46B00A5; Thu, 21 Mar 2024 13:04:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 207DD6B00C3; Thu, 21 Mar 2024 13:04:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A8E56B00C4; Thu, 21 Mar 2024 13:04:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E234D6B00A5 for ; Thu, 21 Mar 2024 13:04:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E56ACA1629 for ; Thu, 21 Mar 2024 17:04:33 +0000 (UTC) X-FDA: 81921670026.19.A6AF6EE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 3378B14002F for ; Thu, 21 Mar 2024 17:04:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KvEPlgWf; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711040671; a=rsa-sha256; cv=none; b=rD8bo2V2xm69zSlRRuEVOe+xBVfIDQpALVl+1QXEdU33EqRx+P1tOPBxP3dsa83/vp6qzm U3Jj9WjxV1Zy7UDe36nlGOiB6fU6pl59aOuAdxv5wLI08fH//yvktRf3437ZrHRcOdBNO5 0YSr8gloU7iLEvlMjM2615dc9AazlTI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KvEPlgWf; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711040671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=grrtrTSALnjlmhusaSmHuxgXHvy0PaqBERbW2XOksq0=; b=lP2kYaE3l2vHSoaXq8ab/QGuytZXvY4izwPgeJU38FHv5rwrWyqpndr2MzM4Mwd2IDtjb9 yGsiuB4ISmOQMcRs+5vix8shemCGD+YtNaK0JrDkrWvfITP2OKokgDfCrRCX2O7kujxgC+ CSTRFZTjVaB/U/I+AYO521DkAUHPvK0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=grrtrTSALnjlmhusaSmHuxgXHvy0PaqBERbW2XOksq0=; b=KvEPlgWfmkZUIIq92E2QZaaPjt VZnhAGfpOn0TI3GH3pJGkjjDKFGgCnRVoZXS0BnLBMeD1ysCOzMVESTZFH2ZdWFKAFjnnJlrR5uI5 zf/WrZhxkWHn8GwTIdG1zh3HdqNwj7dYkA4xHqWXF2ODLbgR0RW1k0j0tjtwj8yFbkmKVhWzVS3Y6 TOQjkHw4Zx3NY/0ztZG4Etw6zBRqBCBnusj92jv7s9yw0pEcoFBeAfAg1WXXNifPuRvLrVhXYEOSk xN0Lo7fv/rEgNH7tG5XAA+oXF4lQKAZALSzMZaggWOEPJTF9gdOPdlAxh7rTpUSFkYhhy2AZFvZTI zY4tyT5A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLpl-00000007AzI-40SJ; Thu, 21 Mar 2024 17:04:06 +0000 Date: Thu, 21 Mar 2024 17:04:05 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 20/37] mm: fix non-compound multi-order memory accounting in __free_pages Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-21-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3378B14002F X-Stat-Signature: p9j1za59ydwkme8m31bkjkwbdek6si15 X-HE-Tag: 1711040670-48010 X-HE-Meta: U2FsdGVkX1+e1StA6C8kUosy8sb687kKMg4ilaodtz+TyiV17X+JZ7PlDPNJ6PCnVu1/PT0x6DKiZNUfa4qs0Mejf1esiRos6J+QEjMqueUF7eMj1E4DMmyngUU5URTXdP9DrFWnFugQNgOzDwnILOZliHraWMmUfgnv/jr/vuTzrFqPeXd1wP/9pmcoRh9bZyX8xCWihpE1CE380a6c967B0jsYzKIiCdF1ZhqI9RUsOmuI5bwwycdPgZI/oZwwmfJHzkXvQHuf5nWhMmuEpwXFYvPYcYndhADXPBDg4AM6vx4MHZJCiyYx/uw2b6KuhpfJ+9FNyGeaqR4lc4ZuKqLHxCBQPs/ADOloEMEDRo3v3qrXSMecnYElhXOzemA51Fue9Cd0gLrMoUUiDCpn0GNaBs2WljZISYaHARMkJ+O97O92Q4x0D7FLFsjOml9FYoUJECH0KuurFOUzlp0gtS4upzIK2klcsM7MLx9k+Q15dgqdQ8DMW1XX8thyIIDaWgfzGvrQzttZR6dzliNl+Nd11GNgmvNfbX8qFMNtAImD0sjyxbsimkplEsWh4gBDg1TBIy1+0WN+oUcSjRcXYfosKg7JmqN895mRVh38LKZBlKP1k30TB169R4olSXs+kZajDQiT7RImTiXXVARLQcQNt/GNEcEzN/N/m8NjHDGkBJdzgZnq4y3Q7wraN6kyNpvxUb8Jgh1b+kqe83dhDOWzK3G/irBpRWlNHOPLOkCli9Ts/p4u2lO1JI8JOPmRM/8E2FxA60Y4ERa9qCw5aLr+/7T1I5ovibn+IHM/QuEV+5gxYNGJzZLxZpEiY31r324sv42Hi9PvRZ4CJn+AmhiJIjPv1TSvVI/v/Z87yTEuI/6GAWrn7rCIPgtwAwfzBwRWq5AWARJv7zCjZKnCWtAZbkzV+iNJGHinQ1aPCKPFyKpQyp7WiBNKylQj49/JzRR7VVLQqOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 04:48:53PM +0000, Matthew Wilcox wrote: > On Thu, Mar 21, 2024 at 09:36:42AM -0700, Suren Baghdasaryan wrote: > > +++ b/mm/page_alloc.c > > @@ -4700,12 +4700,15 @@ void __free_pages(struct page *page, unsigned int order) > > { > > /* get PageHead before we drop reference */ > > int head = PageHead(page); > > + struct alloc_tag *tag = pgalloc_tag_get(page); > > > > if (put_page_testzero(page)) > > free_the_page(page, order); > > - else if (!head) > > + else if (!head) { > > + pgalloc_tag_sub_pages(tag, (1 << order) - 1); > > while (order-- > 0) > > free_the_page(page + (1 << order), order); > > + } > > Why do you need these new functions instead of just: > > + else if (!head) { > + pgalloc_tag_sub(page, (1 << order) - 1); > while (order-- > 0) > free_the_page(page + (1 << order), order); > + } Actually, I'm not sure this is safe (I don't fully understand codetags, so it may be safe). What can happen is that the put_page() can come in before the pgalloc_tag_sub(), and then that page can be allocated again. Will that cause confusion?