From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D55AC54E58 for ; Fri, 22 Mar 2024 00:09:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D570D6B0087; Thu, 21 Mar 2024 20:09:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D056A6B0089; Thu, 21 Mar 2024 20:09:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA5866B008A; Thu, 21 Mar 2024 20:09:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AAB196B0087 for ; Thu, 21 Mar 2024 20:09:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5150680B87 for ; Fri, 22 Mar 2024 00:09:40 +0000 (UTC) X-FDA: 81922741320.05.A43EB88 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf15.hostedemail.com (Postfix) with ESMTP id 3B3A6A000A for ; Fri, 22 Mar 2024 00:09:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=aXkMMI0j; spf=none (imf15.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711066178; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2moEpAismjcawN+PGW1bmLh6TrJn1P653kp5rgnCLkg=; b=eXD5Z9+IC18KdBGwjfYvtNJtavmpmGGL09zunEazJOMKLK4dYi9a5Rdyu1Xn7AAUBTnmOc 37ZlROZmDcfFaVqlwjrOSOGJfyuipkmHgbxEVKi+ttdfiO44+F+f7mgusqU1B9p/er+8o+ M9gHBAFoAUF0gONJ1VJGgTULL8OeUQI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711066178; a=rsa-sha256; cv=none; b=Q2hU+aXP4mBt06goOwg5cmxVEQGP71vuE2mT1WmUg/0qd6QVvWLvLowNziToNrsmkZO0Q+ 5vXy5gtkvMn83IIw1pTIbWrPeu584dFTAeCtneH1/rY8iboqmNQCGnkvhzMr2Xn48G2Ccf kxaog580dSFYxwV3N4kD3aXqC55Avzo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=aXkMMI0j; spf=none (imf15.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2moEpAismjcawN+PGW1bmLh6TrJn1P653kp5rgnCLkg=; b=aXkMMI0ja+5UEUhZLzxrAJrkpo OggZC2nCb+f2Fc6/hgyq/dQ94GWFA01LJDDP2/qY/PfR0cOEEIRO7rDEZOR4X/evTYWr484x/xhO3 47CbPRUUvktN9l7IXCMsnWhcklfjWOYuw0E9d92IWt5TWXUCJkQDKh03JS9U77CcNYcMHVghXmFFu 2t4mOBimVFjY+Dib9ePoRuVpnTqqQ61NKl5z1snJ7I9je9VFA/RF6dHv7EuRNfac5ZN52xWm/ySPu Nb6YpH4MMb2hjDYG5OrQtutMpquZ7gmQOTxdeOUBXqEoAoqtZcYcCC66Uvr72DpXZJUlgnF69G1wf Ybls5MUA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44658) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rnST0-0008AS-2e; Fri, 22 Mar 2024 00:09:02 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rnSSs-00049Z-Vr; Fri, 22 Mar 2024 00:08:55 +0000 Date: Fri, 22 Mar 2024 00:08:54 +0000 From: "Russell King (Oracle)" To: Ard Biesheuvel Cc: David Laight , Jiangfeng Xiao , "arnd@arndb.de" , "keescook@chromium.org" , "haibo.li@mediatek.com" , "angelogioacchino.delregno@collabora.com" , "amergnat@baylibre.com" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "douzhaolei@huawei.com" , "gustavoars@kernel.org" , "jpoimboe@kernel.org" , "kepler.chenxin@huawei.com" , "kirill.shutemov@linux.intel.com" , "linux-hardening@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "nixiaoming@huawei.com" , "peterz@infradead.org" , "wangbing6@huawei.com" , "wangfangpeng1@huawei.com" , "jannh@google.com" , "willy@infradead.org" Subject: Re: [PATCH v2] ARM: unwind: improve unwinders for noreturn case Message-ID: References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710906278-23851-1-git-send-email-xiaojiangfeng@huawei.com> <84a57ca8-8963-ca24-8bd1-ddc5c33bf4da@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3B3A6A000A X-Rspam-User: X-Stat-Signature: jjsm7xc6tpe668rqini3q9c8trwyd1fc X-Rspamd-Server: rspam03 X-HE-Tag: 1711066177-237004 X-HE-Meta: U2FsdGVkX18247LbquwY88bzZ5//jS4VplV+fsEoeOlbE9uXgCG74ACkjALBwLygY/5A64VAQkHDK3ykB/eVFAvNE5me5y0nba7vTitmfjRZvKtbW7dJYxOIX85QxFKCdie6kmjMWYZoPD3E84w4pR2Z4LVrRZZCE9Hs1QsB1+uib5qZaAYkdV1sesS1Bst5N4lzfS+9cpV9mQ2qubDpHDr4k9Lx9SzhKJvHQXfJxjdiYeLnEXaBvlijPIrDpnQ/fL7oa1Q4AXbVmHwGM1aHmfZugpSjNZvW3YuDzDxljVC+rDeER+t5NdbrajQ18sV2sER8IkufJt2qdBWg6uiABwKn7NzEplKEG2sSMr43vkEyQIAK5/RTqqb1PMOZHA2b6LyDwd8LPpodCphPr2pL8pgDp4LGze5yqHKD8v9enspBAfuzS27v0nhbamUGxvScILGCqtaNGydkU7GeneJDZYMl8Fk+KSHnrlCXRpeApcyeFLlYAHcHFfAlhzxaTjvq2Q3tsq9Qp/Z2SVQy7qAnG7XmJrx5hKegZ0vlGEgPZ7YNiVt/3TCQheaLelLZ+ZQGPb2tdFKkj5HBJZx8ys6bGa0dgQmGJXPTsgQ10KBKValz5aQ0T+wWBIMZGO+FVu9U8dboYKLTqR3XhC2SutkB8714XHJueJy+gsTAjY0OH8fXLAe/plWqg3NjNRWYbZch3lBCvrQVpApPu9VZ+Fuv81zPR091kFKO3DogAh2T9Zfo5lHJcstkO4c3IDSrCtEN6eUQpL/ictChXkEMLAO8/NHwrL9nw1K4q14OfepvzA3571oUuR0e1xp9U6QddKuaYbzj2XUBA//fC2kux+UYtY0SPmh7qglBela4EAaeKonP3TApBKn2k9a15uHRcd+CVIcs/EDtWN1/2e+wCAIrizNzNvg94OUr42BZ9Wj1LzOllBhArffjJ0ksAPuGde+jaZbD3tnZGzevaJdNKoI DEc6qX3m r1JHw3aS2abBwBYKtJzu3QPObOs1hg8WWR/ZIG6GCfoIq2DIAfIKNY8dPzOxe/UxuYGQFrlTIf9n/LH2dGvi+EiUj8jLp7Wbk2xnwPf3JEFYD8DWJ3fsTTgB12ilON20aslN2oBhzTXq1xpmQXojFbQIU4OpFscp/HgIiTpDOjSUD73EYJW7nTO443V8dtmZEDP6thT/YoAhb1EPI+E/64flO1tpZ7dAqpbxKSeeTnYuptCwoYZ0ATVaDEnVEdy/37/863m/2oB0T96FQVO4thLWGMHf4luFtRbDHeJlMxdMvlyIneCpbNDx9QvYC6UAilMOnSPBjDrrQxXknXN5sspp454qNuLuCXGbj/rQCg1J0jpHXHL0WzN58nHg5pE8PUb5bva+adSZUGhvR8tVvL/7Aw+/CnwdPASu9ZhIcKF972NdG1dUZpG5qiMDm4QQ5T/DDVghtbwBTBORztTwVOvTNyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000779, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 11:43:41PM +0100, Ard Biesheuvel wrote: > Given that this particular issue would just disappear if the compiler > would just insert a BRK after the BL, I'd prefer to explore first > whether we can get this fixed on the compiler side. Arm32 doesn't have a BRK instruction. What would be appropriate after the no-return BL would be OS specific. Maybe a branch to "abort" would be a good idea though. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!