From: Matthew Wilcox <willy@infradead.org>
To: Oscar Salvador <osalvador@suse.de>
Cc: Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] hugetlb: Convert alloc_buddy_hugetlb_folio to use a folio
Date: Wed, 3 Apr 2024 22:17:45 +0100 [thread overview]
Message-ID: <Zg3Hecl4ejp2ctMG@casper.infradead.org> (raw)
In-Reply-To: <Zg0EdZOwznm3wTOm@localhost.localdomain>
On Wed, Apr 03, 2024 at 09:25:41AM +0200, Oscar Salvador wrote:
> On Wed, Apr 03, 2024 at 02:19:19PM +0800, Muchun Song wrote:
> > I think you mean this patch [1], right? With alloc_frozen_pages()
> > introduced, we could get rid of the trick from HugeTLB code.
>
> Ah yes, that one, thanks.
> It would be nice, but having read the discussion I am kind of skeptical.
>
> But maybe some to revisit.
I haven't given up on it. It's just currently parked, awaiting more
cleanups, some of which I have scheduled for the next merge window.
Part of the memdesc project will involve not having refcounts for some
memdescs. Slab, percpu and pagetable don't need them, for example.
I think hugetlb is being unnecessarily paranoid here, tbh. Or maybe
this part is just badly structured; if we're allocating a hugetlb folio,
it should be fine for its refcount to be temporarily elevated by someone
else. Not sure I can figure out what's going on in
alloc_and_dissolve_hugetlb_folio() though.
next prev parent reply other threads:[~2024-04-03 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 20:06 [PATCH] hugetlb: Convert alloc_buddy_hugetlb_folio to use a folio Matthew Wilcox (Oracle)
2024-04-02 21:19 ` Sidhartha Kumar
2024-04-03 4:55 ` Oscar Salvador
2024-04-03 6:19 ` Muchun Song
2024-04-03 7:25 ` Oscar Salvador
2024-04-03 21:17 ` Matthew Wilcox [this message]
2024-04-04 11:13 ` Oscar Salvador
2024-04-07 7:14 ` Muchun Song
2024-04-03 6:00 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg3Hecl4ejp2ctMG@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox