From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E02ACD1292 for ; Thu, 4 Apr 2024 21:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEBBF6B0095; Thu, 4 Apr 2024 17:39:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B2C6B0098; Thu, 4 Apr 2024 17:39:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914EA6B009C; Thu, 4 Apr 2024 17:39:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 744656B0095 for ; Thu, 4 Apr 2024 17:39:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2D8DE120E25 for ; Thu, 4 Apr 2024 21:39:27 +0000 (UTC) X-FDA: 81973165974.11.CF09BC6 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf04.hostedemail.com (Postfix) with ESMTP id 345004000A for ; Thu, 4 Apr 2024 21:39:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=tySC1Jp3; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712266765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fPArP3ejLo3l+aX8ToKGJxurh8OEHx4iQxc5XkqOF4g=; b=GOZEO0sXS7kBiPeowRUN1i05k0ijIiqAjMFXTMleKxH+yAyg4E0if8dSNo5LPsKHjBe/8x cFkCIaDzmauLMEVQVWgA51dtqYiMMvlfhDG9wuc/VuXdOmZo28qn9oz2fPwoQmoGARlXBm FhDJ/AJ09TIzLEvwphYkj5Aw+hODEpU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=tySC1Jp3; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712266765; a=rsa-sha256; cv=none; b=5G0pOM5HV5LFfXiowMwi4Xla7OPFJ57VmOLPiQjCzrDR9CIsDewBbhQTvfbWE9Mga0mVpT E7Og9KktKwHYY8WGpzv5cVgyG922qa8l/XtUi9X37ZNUyb+AjxtosAkUAGwUFDScZDrk7f 9ijSmh7yn+a4CjNlvzfv5NjU2HDO448= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e0d82d441bso13784215ad.3 for ; Thu, 04 Apr 2024 14:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712266764; x=1712871564; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fPArP3ejLo3l+aX8ToKGJxurh8OEHx4iQxc5XkqOF4g=; b=tySC1Jp3wbb8SHqrF4wUs4jQxcdYiMyUS2aDvbIUcuvcPAP31J2yOiu9xKy3KV/QTv DJ1fGobMb70Ouvs3hKLWTWNSdr/KnJzCyLOnsepmqErqwhRic5Mp/ss75v70HpfZpumw Mba2zHoR4MRYU/lRJLvitN2vVaGXP4owhp50hc6gC5qDdkoQX5SsVvVa5eAkquYYiH9Q 6aTDcY1GYQLEMRsRA1xFwG7fSQWBDPEvXbNVERnJiOwsZS8BqVglXmhMw7ItLGpyEC5n LYfGLbI/Zppz/X2b5bvFGL7BIfMOPZdwVCBeRxDD2vIRB2G48bycC81PFKeoptVKXXi4 Yhqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712266764; x=1712871564; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fPArP3ejLo3l+aX8ToKGJxurh8OEHx4iQxc5XkqOF4g=; b=wd6+sO8Sa+zUhu/tgK7wANIOnGxGv2BUk0ro26W65sSC/HiuHRxPLn9vNnG31t8yEI 2SSCj/xi2Wx0CNxIfoKp0o9nxRZuuZI6is8rWLBZHAkIh+2+igby/krQp6dhQ+qK7Q4E HrPcFmGNeKBrgMXgxMZu3GpkjTg25hTAJERCPQWCjUuxbOpEa7wDWHfxiroaKZv5Rrut NuvDoXDTx/XwVWVuTEkIwcvfU2HyudtDrlHDq6FvaKHZQEDX9Kp2oq8P50noQpx//6Ho 9rb34U8P7b5LcD5dJC3T6OtaPRQlsr7FYA4o/dQvs6QT9Izt7O6S6r+WJTkcJwm7l+oi TxWw== X-Forwarded-Encrypted: i=1; AJvYcCXLImYnIMBwlZgIKJ60iC+qP1U1teAG0YdgFHXv9bTcqY+EuJwkWesjjgvo0IxxyPBBZ0j60uSIK7XWCIF/RqKbTDo= X-Gm-Message-State: AOJu0YzDJ0pOTN6JjxvbpMtwPciuVX4rRVJ2fVZiSaODpM5avuxIOxGq qvHNsrEPVt3kkFmHd+3czha3eRRRJVeUjkoHtHyvJFdByEgx2/j41DYisvheT9M= X-Google-Smtp-Source: AGHT+IFPYkwFkCWA+SA7mff7SB9WJfJBYnvlFHy9eSaPUSq9JIjSJtsLm/B02BDU1sUJv+HfqHd+4Q== X-Received: by 2002:a17:902:f68a:b0:1e2:887a:68a7 with SMTP id l10-20020a170902f68a00b001e2887a68a7mr4103646plg.33.1712266763893; Thu, 04 Apr 2024 14:39:23 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id l10-20020a170903244a00b001e29833ada6sm89367pls.140.2024.04.04.14.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 14:39:23 -0700 (PDT) Date: Thu, 4 Apr 2024 14:39:20 -0700 From: Deepak Gupta To: David Hildenbrand Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, Mike Rapoport Subject: Re: [PATCH v3 09/29] mm: abstract shadow stack vma behind `vma_is_shadow_stack` Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-10-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 345004000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bugi1uszhumxsr6k8ptz1hr6nsz4u6p7 X-HE-Tag: 1712266764-443005 X-HE-Meta: U2FsdGVkX19H76QANMI48q4rkbk5Pp+hzdq7xqnrgPNpJBusn1zgCzIONA2UeU6mpghAh8W0ulUMAGiXfqPCAeXPFat5wsxBRijDTnHElEivdJTh+RvtZ4eJurgO0EucV0iewlIpYjpvAh1VZHpkZFbQ3aRB6GOTDoiw1vgE/1u8coghiJy8qzrAWyEwjP9QDx+2pas2HDo5nts0woKW1oh9axVFm8QO8ckgdrkv/fl7wRmSYXNcGTf0dxpZ9FPXWri4It01pMNikq2gqH7TlP8f2W2troEvmSMEr+9q4NfVfifbeHBL4S6vQuP/bElJTrcyw9hNDBTpJxcxR4ZzTD9omCPh+KzvXWPNqqINZhyYDzEHikER4+fFLG7ISVF1EFhW8R9CW7hi6Ol6rB7zxU6zQ9z5fCbmyRCdIG530lXFZtdU4NEJjwbkhe8osGZXEb6erNXsqMfk4tifYquZEE1e1EfRDZHY6i5O6H+u6iIbH9UJ/lmkWPB3JSbvTf3+gG/H52vLL98bWTKz8hOPRwcWHYWssugRgOcUCErax2bhqbKEC6Pn4lhdFh5RkRKj6c63uTVa6xn68zbCwj5WO5C1DULqf0PkPfDW+/+It1P+KKyFxVg966MatziUhntnp4Fi6NBtIVZlIxlXt+tG3RT1r4eIdcWEIZRbVuHKXdHeIFV+bSlTLB5OiF2hrYxGX48hTXULlnSO0IC+nVfo3p+Ur29KaAxj6EtWcmkmdWn8SEx/jjFIjpFgPI7xAJW5KGNY3gvTXTg5wxem/J6as4SvBHuD9Z8CND99bzxW8tmKKKGOKjYwnpYGOvQDD198+fNQLauH6YhVhE7AbGjkiwAHpcyKg2PjS8mWFNfAbTQip4vTn5HcMl0bOE4Chvb0wuLv4ENqfxLrmfTb+fv6LYAYV9QDusqyE+F2EZ9+r2LcBPcc+v7Hf1IF34rXXpuXo4XlmBKGVWFKyJHqXi5 JrllGR8H sDJWkBeAYfpng19wtaUSVquPVf74rrk/CEaqdb1GvL5ZPYDfdUmiPuO1HF5FRTqsWM/W9QgiVHAyQmlofde4eju+a6VcvFfKDo9QW4vIg6zPpkymNY/0MXhWnjaOpxtnjXMBYwC9YqW3HRdNwBBGbxM7ubshcv2oDTVUod/qPtLh6d2aOTGPkWKqkgT8rgQwj7sqfvkti9DQMF5sdKAejT//pA/j30V60H4sS8u4Uwmhp/a0jXZr522WRfBBR4Oqnsxawfpv3HOt+qIfTFwts81BNpNqdZDSepvKw6oLeew7S8qjc9dZ6ntqQebfKt0s7FyfB8ms8TJAKA0BueJ4EgIWk0dJGCtPg6MKOIP/Y9lsmce4gvu5pEtUTm8YPLgwvEWtPliFe1IenNSJMhpXyNeTGHmOoitGWSnOnDrkZFo+mZnyO3THXBq/r4K0LuCHUC8w0megIw7dlCQ7SjtTeKjr66fWLr/pLGRew9bY90KORc4ULtLULXDEn5gfUh2DsB2d+yzikr4IwH0tcXCNRBiP5u/a87cxSZIHld1e5PCnqJf4hULxkm2j6jsFXiHMQmRTxvxf7GrTItf+BqL20s4HjM+qkv8Clpmzg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 09:02:17PM +0200, David Hildenbrand wrote: >On 04.04.24 01:34, Deepak Gupta wrote: >> } >>- } else if (!(vm_flags & VM_READ)) { >>+ } else if (!(vm_flags & VM_READ) && !vma_is_shadow_stack(vm_flags)) { >>+ /* reads allowed if its shadow stack vma */ >> if (!(gup_flags & FOLL_FORCE)) >> return -EFAULT; >> /* > >Unless I am missing something, this is not a simple cleanup. It should >go into a separate patch with a clearly documented reason for that >change. I tried that here https://lore.kernel.org/linux-mm/CAKC1njTPBqtsAOn-CWhB+-8FaZ2KWkkz-vRZr7MZq=0yLUdjcQ@mail.gmail.com/T/ But at that time, VM_SHADOW_STACK for riscv meant only VM_WRITE. So I think there was obvious uneasiness with that part. Now we have VM_SHADOW_STACK pretty much same for all arches and only 64bit. I'll try it again as a separate patch. > >-- >Cheers, > >David / dhildenb >