From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379B3C54E58 for ; Tue, 26 Mar 2024 03:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5986B0089; Mon, 25 Mar 2024 23:13:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5F696B008A; Mon, 25 Mar 2024 23:13:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1EBF6B0092; Mon, 25 Mar 2024 23:13:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 925666B0089 for ; Mon, 25 Mar 2024 23:13:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 26586C02E4 for ; Tue, 26 Mar 2024 03:13:14 +0000 (UTC) X-FDA: 81937719108.11.B1F6218 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 13D641C0005 for ; Tue, 26 Mar 2024 03:13:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SCLuPgk5; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711422792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oyTIYfAEgFR5EqikXW3EqaVFHy5A7Gf0H+FFygqy/tY=; b=oGVkEXXlUe3srxrFn4FMvNV9+1TK6DlfL4epjOZcsjSsKxMFEf9iORMCiXjznGBXPNRUrP LnqLx+Rf0VgjiN1DzML7eHMfJM9nAthmhEYjGWUC/L9jj5Wl5CG95kF8ZFRDZaqLC2tWhD xr67ya2KVhYUVppPFo2nPtnI4OeBR34= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SCLuPgk5; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711422792; a=rsa-sha256; cv=none; b=l0IlFWEhxNCkSanOlOJbdmhXHi8wqonA5NIptldu3GOfKvcZsGyZKyXvLX0Ii+GyHr3+5q IcrKgmE5XI7KrOlr29sfPRTVhnx56tBRMa1klDnu+6kwA3Ezn3ic9NpJDYk+HVMlJ05/ZS bb9vi//eoGGkwHlr332egMabLEUDAGg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oyTIYfAEgFR5EqikXW3EqaVFHy5A7Gf0H+FFygqy/tY=; b=SCLuPgk5eGRHTeejI7Po8CxJNS bbsYrw4YA1RuHwQTN3lJSqv0cJSQcoH3NsUnHsCLUTRrfJWekmABSNIEgOKhEMlB8dnHghsjIdFjH tbov3PTpb0mXI/yE5w3u/IVAXlC1QXni5Bz5wSTdDFmtmk3/lUQVqBMRUB9JCEGMaZRxGPpLSKzI8 AkEU50g2pNUrPdELPskDeHhnLyEAClZf8W9he7Cc9V+7bQe2F0mZfyzWa1l9zDCSP6kaY+j2mVk7o yGjKWP4eAvQ2SZs4EGAA8NkZAxQg0NaXHyaK9US3OwjCxbPOUVpB0PZEswh/elWS8A6JeJkH0GU+N ub3NBf9A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1roxEn-00000000Lm5-3f0u; Tue, 26 Mar 2024 03:12:34 +0000 Date: Tue, 26 Mar 2024 03:12:33 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 14/37] lib: introduce support for page allocation tagging Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-15-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321163705.3067592-15-surenb@google.com> X-Rspamd-Queue-Id: 13D641C0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1bu91apqqjr93apc7dbx36oxeqxx1pcn X-HE-Tag: 1711422791-95838 X-HE-Meta: U2FsdGVkX1/fbZerzv41cgJ0+3xs4UtcMGifcoyYwZfrIh/XARwgptV/smAXGKp6cv0S8jXsxQ4LhVaLbdr3BEpWPOkAN/HNAKaYFEJoU9oJyf/dzPm6/87Y30ZLcTua+VIzk9IeWVyV+w7UGwnS/YVsPcG6HK4O7tX3AXkphxi9wGl9LDLsKBxarx2hoP86u4ZffHS5pB0Nlk62gJOTmR8q0jMN2bZMWUM5ImCn7U/rGy1PJ2wIFk5A0bzfhWddeEHQJHdVMUCaok9krts9D70nnatw3fh/crXd2UnGD5+fu9slUxhoL3GVSrH5J79IF9lsLh1k42Gtjvf7/8lIW/eg1P8x6ugQTvHeO0tkfSCxrB6LSeEeg1rIwoDu7+TMeGH/cv8O5pkMiSbS2sV7JQigHj09GmM1/nf6/qs+NonHw0FWwrlqH3iU+lpX+X8vjBsfhaCeDJRZVN221Kf3grOH81neBXMi/Ys+tqPn1IdIMpr3ZRY0SIf54CoQSfgJ+UaXDgT73haBgwII1R8CO4BX6ltIKga8XCE/zIcm8squYQJs3yvJst3pTCb6kuqtiiZjhP+G+wDqk8RE3ztQzQr4cRBNRqBpn/l2i5dSgLiRiL+ZievrRjpRoSHnXmhvnN25Nx+OtlppZqXXyq1aY1WqF5KHRKwIRB8t8GK0srBg/a6gw5OqosuZlTAlrTfLOwFT6v0GfC3kZ58sChxJ7xEZEvBEk+thzhUcRgH+qvoMQ3T1K24hVQ7FvnObeWhVrtJTy5pv37ayb6Fgn4parCvAVsizTyMP0YESLPDx18hG8LBOAYdVZCj3Uh316ADg1kCHt6Iti/pw45hJqFdjysShlp+Rj6Wns/tb9OfSOohGfEcByRahYi9K+AHPKthoUSzIB5Y1INT9GDh6/KBbgMG55J7jT+yxcLtKiUzl6eIPXFVb+V15NKcLo9YYYb2rBoxl+A4yUFsAJaniuvV IO17mgY1 mAYE03Uom2HAY2jAHOvdrm1oeVJPJzmgHYdZ+yAu6i+fEVJ4dJx/qwyBZUJZ5YcfpYEINLpdyK1bYJemULC0Gd92TXyf4+01LHhxCsFpURGaftCRUxU1ApYK2nfGK9Pn7Ih98qggukXVadCBGigqXMfFlIxyNOUPqc3kwrMZPw96+T/0frgk49wF8q3KuMwuyDnOX4S6iKif10SSPtSea4fAThQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 09:36:36AM -0700, Suren Baghdasaryan wrote: > +++ b/include/linux/pgalloc_tag.h > @@ -0,0 +1,78 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * page allocation tagging > + */ > +#ifndef _LINUX_PGALLOC_TAG_H > +#define _LINUX_PGALLOC_TAG_H > + > +#include > + > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + > +#include > + > +extern struct page_ext_operations page_alloc_tagging_ops; > +extern struct page_ext *page_ext_get(struct page *page); > +extern void page_ext_put(struct page_ext *page_ext); Why are you duplicating theses two declarations? I just deleted them locally and don't see any build problems. tested with x86-64 defconfig (full build), allnoconfig full build and allmodconfig mm/ and fs/ (nobody has time to build allmodconfig drivers/)