From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E87FC54E58 for ; Tue, 26 Mar 2024 06:45:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93CDA6B009C; Tue, 26 Mar 2024 02:45:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED136B009D; Tue, 26 Mar 2024 02:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DC6E6B009E; Tue, 26 Mar 2024 02:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C3E96B009C for ; Tue, 26 Mar 2024 02:45:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 347EAA093E for ; Tue, 26 Mar 2024 06:45:36 +0000 (UTC) X-FDA: 81938254272.09.4E2091A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 857B11C0004 for ; Tue, 26 Mar 2024 06:45:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uKfjQouz; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711435534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oVWZ0Lx4gSwnBmQouPQw9Y5zwOhKanBihSeSwgLJK3Y=; b=sQUADJXsvn3L5di9nzUkUrZwml5AywVGTy0IhpNOTLQdoLu74CcCnd+Wkg92C+kRESvuxW Rq8JG1EmxM4v2BVJjss8lmNS5qtTnkI6NinG2c6yblhn0A1hldN/ebRU6X1iR7cQvDhG7c KsarYB4VavOa46Ac+empms+MpfA3vno= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uKfjQouz; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711435534; a=rsa-sha256; cv=none; b=tGFrUDrXLaAmf8B2oiGqZ1bM6PcdBhk6hf4PBIOTvGFR6mQw1BKO+a07OM6HWXUNeGvx5t 4vIft+G0PhHF+ZSs+/tpd45HVH+I/1r0xWkOU36gFOIkTsLKmI9fq6zLtWb/zf1CCLJOcT aNcZ9ELaKijNMlQofQTEHPwK650iwQM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8DC856103E; Tue, 26 Mar 2024 06:45:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE56CC433C7; Tue, 26 Mar 2024 06:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711435533; bh=ulrv7k7ZRJRs0j0UdGjBhPLsD3RfogntRNv4v9/Eono=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uKfjQouzCOhBvoDhqXcHLgUMTJFUwVqNgPbgWGKOmhGTJ2nQSmlZE1A6IBDIPQY2A zVpMgtMPeairercXPNLIzgoWtn3Fot5ibnD/lzLoVjSHSxBEC54Stouwo1s7On6811 GV3eKVumEycJwcreNVmSqHMaEU3TT7qbMKpzGd0QH1KXh/HcLxTNhvf4wg/wPPgehW o9P9KN2GbpJQ2SiGHHDwXxJkMEoyB7gGG+UVh2qybk2PxPOBC9IrRtKLtb5QTE2OPs 8YV0+/1H9qGhY+CBxkf9uGH3nLLndd1kAzYHZhH2awWnGchEcMWzNHZhDmOF0r9nH8 uw4bX4TFQ7lqA== Date: Tue, 26 Mar 2024 08:44:51 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/6] mm/mm_init.c: remove the useless dma_reserve Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325145646.1044760-3-bhe@redhat.com> X-Rspamd-Queue-Id: 857B11C0004 X-Rspam-User: X-Stat-Signature: fauthyy64hyubmk1x6ombx99ri7pktp1 X-Rspamd-Server: rspam01 X-HE-Tag: 1711435534-151298 X-HE-Meta: U2FsdGVkX188YNVDH+GzXuY+o8Ca4tyU+1F/7itVMXP6Ep/B2Dkqha6PQd56CLrtIwdrTMZ2IE0Ph+wHPJJCcxG2j5HjH+bbQ7dBx81IZR1iTAtEiPoRwpb+KGZZN61N9B+/QDhBQxsmIMkW1nNhxRtNwdtpBb+W+nyCEfA/QaHQcLb+yN+vs+aCdjLbq1EOz8Ei1VGk9tPffgbHgpxvq6uGNJdhHi1ld331Ng7po5MFADP+JWUPShr5HzoXodkT4t0Dcsgd7D7EyNsxU8FzERYS9VM5FcxquPYuoHsdZ7ZenqSVxxxfxfqBAAUhRduEM9Fr1Qbr51ODxObEYFWERTroQgI6XChgEzvUps+oe4cZnRwph7zVZj4yVPN04+sbpGvqwuds+gQgTpn5BPaACswk/hikteRwh+iyGqfwPykjwZUyqMCgjDJ6erl3jCtW3VAFzKn0RAKul8cvraHTGBh7V1WcKaCylYRYjifWSvEkslseG4RGF+xvatw397Jmnm6Xb9N/i6RnT9ERl/Lht4m4Q3UoaBU01+w8zsG9QH6GUmKVf1K//VknDGUnGMCDWPyRqSPayJmI3ZGZV+x/AOjokRKRoUDiNHPTjns05oZHuantjnZC2cUVBBMAFssMdTSdUQodWwhuasTRywjsz+N/AXMSSsY7bs2sux7HR0Pa+Mr5fMmCirWLoqRJbZZmzZrVJYbLRT5/Bw4qL4agTgfpaFbWdqNOYpMtl3T0q1H3QD/gv3pax7m4KfGdrTiFeE2lmXwftukS2Qv91Mi8mazx9rknsSNkjya7CrYwA+dj0MRf5NFArWPfOQzM+lIGO2xBaucw9Yx0sqmBYrgVlGE+0hWKBG20koNHQWYO3wqcDAdxChJqCNxEvdrwlPYdValiLG9MGu0bFwdYYiIXdrmPNmHKCB+EDfrJOAEDk3Z9CiCAEYMKTOdP9dzXNf80GTZkinmP7iXSBW2HFlx fcNzMYK3 5Qi3AyzEEc7Y/pALQVebXMXmy1PhSE/9nvSHjnULDN1lyj06xeSfxk7BpiIWYFKtePPoqvGNkj2OmB3sIHaJYubug3GbHIEtDN8ZhktO68v2TkWPaQ6xs314JK9S2h25ahHiYOE9zig0pt64lL08wDB5dqBYJSdAKzLuBAwEurUDN1Dk52INgMHtxvr5X6nE8h2FzPW7GwaCllKdlEowpfsDC8sCueplccCHSPFuuzLLGdfz7mrqG4KVrVuX0jVMLIuwEankx+MVqHynkN3hRwXE2tBz+LjbEhqRGTadu1hmKY9H2MVEfjGF8rTuqPowQK0E+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 10:56:42PM +0800, Baoquan He wrote: > Now nobody calls set_dma_reserve() to set value for dma_reserve, remove > set_dma_reserve(), global variable dma_reserve and the codes using it. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 1 - > mm/mm_init.c | 23 ----------------------- > 2 files changed, 24 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 0436b919f1c7..ad19350e1538 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3210,7 +3210,6 @@ static inline int early_pfn_to_nid(unsigned long pfn) > extern int __meminit early_pfn_to_nid(unsigned long pfn); > #endif > > -extern void set_dma_reserve(unsigned long new_dma_reserve); > extern void mem_init(void); > extern void __init mmap_init(void); > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 549e76af8f82..153fb2dc666f 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -226,7 +226,6 @@ static unsigned long required_movablecore_percent __initdata; > > static unsigned long nr_kernel_pages __initdata; > static unsigned long nr_all_pages __initdata; > -static unsigned long dma_reserve __initdata; > > static bool deferred_struct_pages __meminitdata; > > @@ -1583,12 +1582,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > zone_names[j], memmap_pages, freesize); > } > > - /* Account for reserved pages */ > - if (j == 0 && freesize > dma_reserve) { > - freesize -= dma_reserve; > - pr_debug(" %s zone: %lu pages reserved\n", zone_names[0], dma_reserve); > - } > - > if (!is_highmem_idx(j)) > nr_kernel_pages += freesize; > /* Charge for highmem memmap if there are enough kernel pages */ > @@ -2547,22 +2540,6 @@ void *__init alloc_large_system_hash(const char *tablename, > return table; > } > > -/** > - * set_dma_reserve - set the specified number of pages reserved in the first zone > - * @new_dma_reserve: The number of pages to mark reserved > - * > - * The per-cpu batchsize and zone watermarks are determined by managed_pages. > - * In the DMA zone, a significant percentage may be consumed by kernel image > - * and other unfreeable allocations which can skew the watermarks badly. This > - * function may optionally be used to account for unfreeable pages in the > - * first zone (e.g., ZONE_DMA). The effect will be lower watermarks and > - * smaller per-cpu batchsize. > - */ > -void __init set_dma_reserve(unsigned long new_dma_reserve) > -{ > - dma_reserve = new_dma_reserve; > -} > - > void __init memblock_free_pages(struct page *page, unsigned long pfn, > unsigned int order) > { > -- > 2.41.0 > > -- Sincerely yours, Mike.