From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5356CC54E67 for ; Tue, 26 Mar 2024 06:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9EC86B008A; Tue, 26 Mar 2024 02:58:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4CB86B0095; Tue, 26 Mar 2024 02:58:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3BCF6B0096; Tue, 26 Mar 2024 02:58:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A42E06B008A for ; Tue, 26 Mar 2024 02:58:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7852AA0926 for ; Tue, 26 Mar 2024 06:58:13 +0000 (UTC) X-FDA: 81938286066.02.5052564 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id D3C681C0012 for ; Tue, 26 Mar 2024 06:58:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ay3TqeCm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711436291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZFFfJW0sbZgVzZCyUsqWO0DGAOyHJJG2oUtMxtK+8gU=; b=U+n3jNAAaTR5HztVoJR8d/zqXzP904lM9nC3MEIp6g2HvVBc+SDopDUuhe7OodbVpfyfRl kmJlv4mVI/9Fqmma5SDtV45o64O26ni1+jeBToCvjEp4N1VPf2rzLCQghbbxeLpB09xga9 NIYLrApfC2QCnNiiLfYahYHD1YUgUJQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ay3TqeCm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711436291; a=rsa-sha256; cv=none; b=aO0QZYKJC+800XzJRoHrXmGgcuy2ywrMMrHIZZENOiqNkVnyIqplAQHZ5h8Tgpf/HMIL0d DjwOk+z8kRpL7p/ldqAnpjr2bYFEnlfVlx8p7JpN1/NE9XabcykJ2LZOar5wvtIoiA1Bko WI+SypouEVEsoh/2wlBa5DDtBUHA/iM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D4B0D61203; Tue, 26 Mar 2024 06:58:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D0DFC433F1; Tue, 26 Mar 2024 06:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711436290; bh=Oto1Bgx2nEcBajuiq3zg5pa2/Kdk7vuiCcvbsEb1ox4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ay3TqeCmVtCa4qF1OL7AxLUF84qxvhegocKTuLWHsbSzS0UgBlX6f7JYNGb8GsCCe qFmQRDbOM1FkEdIcqkVwhm64D+hPxIJNp6dbf8c0W/FuEw56ogMEjRCM/FOdLWKAbZ 0yHansf3kxUb5Lg4jDxjCOL5HNwe/eO/kiY4JrnAhwSZ5dG1adz9keSrXWgyqnlyI1 WcvlKvRNMtOCP7F40tIJ1Dvam3LfxDgwCOx6j8B7kc4BEl++YLMZJu715mR4qd56gl FDAxb7ulwHdEUegXRfRWU/qnUO20UzXt3ALdHLqKNdWqmYi24QG6HIL2SjP2TydLZT zKa93/C8jXs1g== Date: Tue, 26 Mar 2024 08:57:29 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 3/6] mm/mm_init.c: add new function calc_nr_all_pages() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325145646.1044760-4-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D3C681C0012 X-Stat-Signature: oheymgehmya5pzk8zyxfdpjucd1hk3x7 X-HE-Tag: 1711436291-350192 X-HE-Meta: U2FsdGVkX1+IcuNk2j7uaJneaHJK3mawm9IC3WU+wTP7xNxmnWLlGPcQ+LswhFt/47t3ud3VKEmITJGTxna+rTLl1dCGhvzN1C46UD+FR/59WaiAH7j87F3ClPfRjqGgGQVgpYkI/BCTRBQhm+R3stLW10RC5xuI8MscJAxmA/e9Rdu1VUuafxskjDHf33vwSWUoWoGOz3s2ya2RKEn7PNOEeudA1sfYALzNLA5/vtCmz3UJLfSUX2mEYLqid6rnmQJG3y+rWQDs7VJzH+mn/IU6xB5BCrEO8qRU8o2ALzm0hntgV136KyX50H5imrcbbFcnHMlXHsyykPgOFyqXEy222/GqPXclzSHrUrqtj+okrlkF4XWvWNVSMfD864V5flN2rOomKxlMsAEN6NEb1+BW836H9pfpxGnPc5OvsIUYiIGFADtR892/3LqcXCgEsI5x5rXLaEwWluSnga9yw0g2VF1x2LQcNACmdRLYSGiIFhKMYc3QnJJBrJVjWQURqPFBu2dxYM8gayAb2musFNfEo2hQ68f2Qpx+lDcg2bliGgazSQgUHZ75qNGSmuGW5OuKz0B23R6O6PZvX6xe0i14FTuDy13x78kgzQMYa9J2eWPuJNn+Ziy2abZjiWAV+xBf7ihSygiC7CDaDHakTsqWSp0Hh4GF1q78U/KhznS5bYt+V/Iux12ULqLUUGLLYQoPlS+odx4RgpMZUQIWGdGCeYb2ycRGhmLsyfyIbWBzFfbnDwRFpppUMQSfiyQ2Al9NLFP6CzVjIhb4DKTxaVJ71eKIrZMG4VLWm0fFj/vaCu5U9669O4IpgOlHeez7iHKvEa6JBgEMnCf2GWEHu3YlLdHFEBz17mEWpSrpzDZM0b/AeiiWN8qlMMc3cS33JGYC3tjd2SxI4QoXL2tHsiZTCDkfryb+qjcWXCOfjxiBu0h/DM9JbeQqX+HAPKBS/ljHkonHxsUubjxwE9x 6oY2fTf+ oi9SrUejKbpXxn1upXA4uP6xXd4OGsf+QxngBNwg/S3A3JzYqK4HBr1tR+nt9nLdDWjGdOxg7DjlxSCHKvQW1V0zIPxju8QMQZLS93Q2OZvmYz0Cj7Issl+JrWygdYkdXl24QegDlctmgMW5/0pW/Upw/1ORwl4UC9/uERfTGsWQ3+/W41N4HXLMzWJC4NG+Pd1v+WLKdcYLd+32/HjsjSOA6CwCvBNU9pjRPmdMTa4Dbm6ZlkCsfVTrdGPPGfuqK54Aj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baoquan, On Mon, Mar 25, 2024 at 10:56:43PM +0800, Baoquan He wrote: > This is a preparation to calculate nr_kernel_pages and nr_all_pages, > both of which will be used later in alloc_large_system_hash(). > > nr_all_pages counts up all free but not reserved memory in memblock > allocator, including HIGHMEM memory. While nr_kernel_pages counts up > all free but not reserved low memory in memblock allocator, excluding > HIGHMEM memory. Sorry I've missed this in the previous review, but I think this patch and the patch "remove unneeded calc_memmap_size()" can be merged into "remove meaningless calculation of zone->managed_pages in free_area_init_core()" with an appropriate update of the commit message. With the current patch splitting there will be compilation warning about unused function for this and the next patch. > Signed-off-by: Baoquan He > --- > mm/mm_init.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 153fb2dc666f..c57a7fc97a16 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1264,6 +1264,30 @@ static void __init reset_memoryless_node_totalpages(struct pglist_data *pgdat) > pr_debug("On node %d totalpages: 0\n", pgdat->node_id); > } > > +static void __init calc_nr_kernel_pages(void) > +{ > + unsigned long start_pfn, end_pfn; > + phys_addr_t start_addr, end_addr; > + u64 u; > +#ifdef CONFIG_HIGHMEM > + unsigned long high_zone_low = arch_zone_lowest_possible_pfn[ZONE_HIGHMEM]; > +#endif > + > + for_each_free_mem_range(u, NUMA_NO_NODE, MEMBLOCK_NONE, &start_addr, &end_addr, NULL) { > + start_pfn = PFN_UP(start_addr); > + end_pfn = PFN_DOWN(end_addr); > + > + if (start_pfn < end_pfn) { > + nr_all_pages += end_pfn - start_pfn; > +#ifdef CONFIG_HIGHMEM > + start_pfn = clamp(start_pfn, 0, high_zone_low); > + end_pfn = clamp(end_pfn, 0, high_zone_low); > +#endif > + nr_kernel_pages += end_pfn - start_pfn; > + } > + } > +} > + > static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long node_start_pfn, > unsigned long node_end_pfn) > -- > 2.41.0 > -- Sincerely yours, Mike.