From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08EBC54E58 for ; Tue, 26 Mar 2024 06:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8586A6B0096; Tue, 26 Mar 2024 02:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8074F6B0098; Tue, 26 Mar 2024 02:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71DFD6B009C; Tue, 26 Mar 2024 02:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 634266B0096 for ; Tue, 26 Mar 2024 02:58:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BA4AA0CE3 for ; Tue, 26 Mar 2024 06:58:43 +0000 (UTC) X-FDA: 81938287326.04.9A78BFB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id B3CE61C0003 for ; Tue, 26 Mar 2024 06:58:40 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fnZXP2hr; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711436321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEpuDLIgpS2RHHMnhxZYek/Q/nhTtwSEXGUnUQeu8/A=; b=YK8OnfLcfpibq7dHgtrp/QQe15nzkupP1gkKMq8vNx9y604/kseY0d2+uCWzirzSueEEeU N8/O553C9s3x77IYDzbiZRvEV9QET5bbn1evcbzLkMtVoPvR1aBRk2br0v3+i+v0bhtWEk cR5CMIFdhL9LTFGD4eVp4JGyXDskW/4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711436321; a=rsa-sha256; cv=none; b=SPRwCHZv1Y6QA3ssDT8eU8Wr2tOElILvn9U7lKxbNONiKbpM5FfrX5+3bZo4EtX8ttT6RR G8xzYSItm6szgMozFd8ZGMo9vysbp+7vR7llR0weFNcVYl2an4eZJRkDH4eNDgqb88w9KJ nGWV3qYDcFzbM08Ibn3+TyQxSp8mjtY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fnZXP2hr; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1573DCE1E40; Tue, 26 Mar 2024 06:58:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D9A1C433C7; Tue, 26 Mar 2024 06:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711436316; bh=2h+xwPao4UQjY5pzAeqIZuJmOnkTkwIZDSMWkOI2/m4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fnZXP2hrOZj2Z8QDTITPOCDYzWo/RpPKcF0v6NAm2SpxZh0PsXWZuJwc3oEBhKUWv Mi68YOrSG5ih18gIT2PvjY4DobC3VNnhLdVZ4TKV5pulyRNF+tgTqiupcSx4gKxdDF jeh31wT4loBcfFORRnpiYexhmfYOeJ0YRYAbUKlUvrW4KnatdYDaSPrIx66kjajELw ZmEbAEgh75QcmMm4slvb4gY5lIJxBCtvKm1zkNq5n1lycKvAdGz+YzlUO+7hqlJNOw OOI24Tspe9k4/8k5zOe4Nf3ymGckG543nJ0Hn4azqvR6YbgKjAskBkT5tdXk4ZBfMA uifqEFW4HXdvQ== Date: Tue, 26 Mar 2024 08:57:55 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 6/6] mm/mm_init.c: remove arch_reserved_kernel_pages() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325145646.1044760-7-bhe@redhat.com> X-Rspamd-Queue-Id: B3CE61C0003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: i8nm4mw9d5thodo3kmjr8maais1e96ft X-HE-Tag: 1711436320-613515 X-HE-Meta: U2FsdGVkX1/BUGxYL6RxYQrHL/QUcAiwA5yhGsG5vNkihzhTa35ZLQgQ5jhFEwD0t0MdT95TgFzEObbSmYhz1jRbMZIlDud8wwhRQUoBIjTdD51q+dIUp2ydcZAphVd/LN5y7grALESGqlge1wSN1b8aw6naObEu4Aj+GfXuAy8Dx7pxrws41CJaiLV7+qvtkMWXnrWN9xbjMPo2SBw3kEVwhO4pXUxwrKEWBY+jGEzgH7l+Zk6h7bzIYaValYnu1IGQ+rD67y5FkbKST+/cA4MOI/SoL2IDEQx9l2iRynFL5vTbsx0sX1fatlt9KZ0hcQ8CAdPMOgb/qysMM1BEOyz0w1nVJCs7tb0sxGnGb6oEjDKAG7uP7AvvJRWP19KGCQ1hOtdcsC05u8d6XLbYxoeH0QFu86bxLW3hZ+Voe7+SZv50zGbYAWimYpQWPcKMNfOaJ6u8oMyuOa22dB8pKrHPTOXPQEbZzL5+Ob8LrUg9PqCO78zlgd7Q7/wJypS7uDzY3AUUHEIB3ofeylctfVUr5mq7IewjduFSLAHzsveSw7JH39fhmNb+vk7xdMQ2Bln0d9my+zbeOcO61ySy2oNj4WH4DzFrwNmJXiwWKGl/fQc6YO+EzdCYRAotVvAqWVeZPZ40yJlic5eo89EtEHGo2iEQCcW9DNv0dzVShxp7gt93i+FGzJdFqfKXIcRy4M+P+YVE7QmlXRI+KoLJAqz650qdLv1HCdL3V9Eao3FqPAzRTQjwFHamiIYpq/ivWTMBs3XZxiNloEP6xkrX8msfP8nm3Hyvowt0A4pjwnzqVpeh/O6yivhDsV55DsdKWgetgw85JkIZJ6wZkCVlP312a/0aqahhksI2QTo7VF4auPgrwxazD71Yug+X8WVDsfxXgvUa77SUGBs5LAelfPdsqWfbQAbmx1TuEdkDWm9mraBL7jt1iYF1WPRjLGkLwbWTqUoBwvgJiRtYLMg ZoOpBe0b XMMB6yBemYIqqcMmrB3Ggi0uYQvOHLapMy7D7rHIMxr4+LxaZaxPXTzfrNBN/5kUH8IOJDpgMv2W537R8YcD6aANck75lz5I1GpGGnIVC4pNNfURI6UZ3LIQycFzPMwez7USX5IFYUrpFlLtTmNV7WSiJKjupHv0ndj6PXEnWp76XQq1ZfRmd82jJpabeJRLIfE0k2wDW30CbTMGh5RyX+a2dHlI33GqoabgefPG1974G92X9WD9e/U4j6X1rP5qVcR1QtG5se16sL0Qr66q7a92eLDLDJ/7mlyAqWukeCigmS7iJ76joHwqtCjivZBkeesWr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 10:56:46PM +0800, Baoquan He wrote: > Since the current calculation of calc_nr_kernel_pages() has taken into > consideration of kernel reserved memory, no need to have > arch_reserved_kernel_pages() any more. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > arch/powerpc/include/asm/mmu.h | 4 ---- > arch/powerpc/kernel/fadump.c | 5 ----- > include/linux/mm.h | 3 --- > mm/mm_init.c | 12 ------------ > 4 files changed, 24 deletions(-) > > diff --git a/arch/powerpc/include/asm/mmu.h b/arch/powerpc/include/asm/mmu.h > index 3b72c7ed24cf..aa5c0fd5edb1 100644 > --- a/arch/powerpc/include/asm/mmu.h > +++ b/arch/powerpc/include/asm/mmu.h > @@ -406,9 +406,5 @@ extern void *abatron_pteptrs[2]; > #include > #endif > > -#if defined(CONFIG_FA_DUMP) || defined(CONFIG_PRESERVE_FA_DUMP) > -#define __HAVE_ARCH_RESERVED_KERNEL_PAGES > -#endif > - > #endif /* __KERNEL__ */ > #endif /* _ASM_POWERPC_MMU_H_ */ > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index d14eda1e8589..ae8c7619e597 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -1735,8 +1735,3 @@ static void __init fadump_reserve_crash_area(u64 base) > memblock_reserve(mstart, msize); > } > } > - > -unsigned long __init arch_reserved_kernel_pages(void) > -{ > - return memblock_reserved_size() / PAGE_SIZE; > -} > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ad19350e1538..ab1ba0a31429 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3221,9 +3221,6 @@ static inline void show_mem(void) > extern long si_mem_available(void); > extern void si_meminfo(struct sysinfo * val); > extern void si_meminfo_node(struct sysinfo *val, int nid); > -#ifdef __HAVE_ARCH_RESERVED_KERNEL_PAGES > -extern unsigned long arch_reserved_kernel_pages(void); > -#endif > > extern __printf(3, 4) > void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...); > diff --git a/mm/mm_init.c b/mm/mm_init.c > index e269a724f70e..089dc60159e9 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2373,17 +2373,6 @@ void __init page_alloc_init_late(void) > page_alloc_sysctl_init(); > } > > -#ifndef __HAVE_ARCH_RESERVED_KERNEL_PAGES > -/* > - * Returns the number of pages that arch has reserved but > - * is not known to alloc_large_system_hash(). > - */ > -static unsigned long __init arch_reserved_kernel_pages(void) > -{ > - return 0; > -} > -#endif > - > /* > * Adaptive scale is meant to reduce sizes of hash tables on large memory > * machines. As memory size is increased the scale is also increased but at > @@ -2426,7 +2415,6 @@ void *__init alloc_large_system_hash(const char *tablename, > if (!numentries) { > /* round applicable memory size up to nearest megabyte */ > numentries = nr_kernel_pages; > - numentries -= arch_reserved_kernel_pages(); > > /* It isn't necessary when PAGE_SIZE >= 1MB */ > if (PAGE_SIZE < SZ_1M) > -- > 2.41.0 > -- Sincerely yours, Mike.