From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB27C54E67 for ; Wed, 27 Mar 2024 15:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65BD66B0089; Wed, 27 Mar 2024 11:04:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60B836B008A; Wed, 27 Mar 2024 11:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3C96B0092; Wed, 27 Mar 2024 11:04:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3089A6B0089 for ; Wed, 27 Mar 2024 11:04:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0561B140B92 for ; Wed, 27 Mar 2024 15:04:02 +0000 (UTC) X-FDA: 81943139166.07.6F3ADD1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 435EB40016 for ; Wed, 27 Mar 2024 15:03:58 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sEXhPEfA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711551839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lSXsATRSH3T4FFzskGuLtXHSrB5PIP8lmMX9qzjpF7Q=; b=Ufe26EBjISqmjUIc3coLB4ny04F+cg0syfXLeGbBwCE5l/a+pAQGyBqbr5dbveQH1oVyUw CHEp0tOqmIyZ6ziItW6IOyQ5BDFvAWAgdSanJ1Bk30pbJpYr8zLc+wIk5IeV0A1MTclNJa E71CejymflVLIKBs85C0JsLZ2Xr8tOw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sEXhPEfA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711551839; a=rsa-sha256; cv=none; b=ox5SgoMIZdSRvbS8gXWKmduQuunyNcBe2F6lqPBge8pozUm5zH/sV2F16MIEel0k+S5mBC +A+XT2VCarO1GEiChPMi6FBF5IN9MtwQFOjKdcjQT/Cnkw3rOFRTeqNRmathTFEygDs6Ta RpB6alXxaXwhf2m4xWd7ConthCX5FhI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4B910CE26D9; Wed, 27 Mar 2024 15:03:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCAA5C433F1; Wed, 27 Mar 2024 15:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711551835; bh=hrWUIu1S4DXcjUN8so6lC+qmnHu3MFuX+fS4XcrdbO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sEXhPEfA8uvevGFpChDpATF2dMUKGWLnO5+bt+v7isVd7EjxTKF99rLKMlCoCY2Jk LuBNcgxFXvcAgzKgdn7vsNZjHWI/5Sxa9eaRM8pqyajO+AVM0tR5DZkT4hNHK6CO2A w6S39o/WjUkgG+q0WSK5KMJFjhLU7SRfEIgObn/GsY8ta+z1NArzQzAOYHOeZnYnjW e38vh+dRtIDDS4AosbPwEtJyLKxcC3Cc6m+WHoxDCOw+3s9xMFHxTRa22EtgGEEj/f 8i2TtvEZt8J0HLpsg/flQsmKDxLTLrVkjOuog3osUis787HulTYqsgEXHQXq6rhSio WTScQfYfAJsMw== Date: Wed, 27 Mar 2024 17:03:10 +0200 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RFC 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments Message-ID: References: <20240327130538.680256-1-david@redhat.com> <20240327130538.680256-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327130538.680256-4-david@redhat.com> X-Rspam-User: X-Stat-Signature: fez1crffkyom6tgqqtxp51z9rek7weam X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 435EB40016 X-HE-Tag: 1711551838-685937 X-HE-Meta: U2FsdGVkX1+A9OJWoSVk7CyKrKBOhrTLmpL8itm9LuH3Tb+tV9nf7bsxnQPzpUBDrkQ5065OTP4vrsXEhsdWWBPuwpqGEz0AbMH1sUYSc/pcj3OLe7di2IYHZbAW6wt/uedEE85MadwdqHNEBV/PC2o1oN8j3bRSYvL0Wk4wVEvqK0AXc0PRhqnZTiZqc+7GVUpD3KBwBTcZ8DmKUKqmlGpr/aFPgI5IGPq9Rm6tjyP0wbfPzoaGdIj/YHbg3ClwtaN0TTaOyoyS6gLO/TiGDEFfRr2EOHRW9y3Zi31qEVQXWtXe7itCbMdtFMtEfXcTmqVuZzC+OSs+WZdCWCmJv1FgeTVLTI5nZkPWdl+jO6Y+QqyTvi7bDk8KC7NTV2G4+K2JkNC8piZwN0X+6V96k3NMfiSVvINcvYw/bdLs8YpOPEZp6aiLSkEDab9wYVSBVed24UaVSPYp7oIEDL9dLBir7wB3S+wiAxQOSdjsEgpxc/h9BFPkBA2utZHlMFSGEABLQKWdE9H5DVjWamT0eaGgcQo4Zo+7K+Ku4fvojvgEuuCf2ZB3VIXb1lw4pBBligxoV75TqC64CejgWwe+l9Q9pA6d5UQyGtWEDNtigYiP/1jkwAhQYJG8QQMd24onFDrZooTYkLQJNaox6Wg0gUvLeKLJAWrmaZ7fOxRxENgEwL1a8Fma5sn3jAALPQcXcKnjOYNRHtCJLuWrF9lie3w5qFwiEO+fUpb4ghQFdLt3GiwBqGl7N/1pb7kOlNzCpAIYiMNRZ0BbRNyeUCkufPTlSuvv3JfMvoXvWhcdta897MEdzF0JOv2/OlAGuXg0Lr0qsJjmdnBKl5KIGOZNhGtDR+Qf+Llr+01o/rLP7RJ2Ia0q1+ZNN8D6GlSDA6qkuRNMIx3r04ASthiIY0KFWg9duC7e3Zx31z1q4usDEOYL669vICSNmQT3ZBslqSs1zHD78bnLey/xFSGlRY2 G4TGHqvi Kp5xH3lpO3Azr9I+fCT4O46/awABqxa4aXza/vHrEiq+rhGIEmuAGd4jTEqP0EKAR3PUz+6TfID4uZ0wqIu4+Ji6ez+yrI8GjMM8UskXi+3izPcizVT6PfhsgoThU3h9uHJ9fapNKLMYsgqwCoU2Rwpg5gR9Xm2mEf5GUzkMx14cRUnutQsPhnrC+aKy9kMVw/bhypFRoqzeLvIgFI9hPil6/sSK+0NNKErVMjD1Eiq2EYY/XOXLGL/jEeQZN5gafIZASfrV3Jods08mNHJUGmBRNoPOekSloMi15RSUFYGJb7q00Dj5D/rVp9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 02:05:38PM +0100, David Hildenbrand wrote: > Let's fixup the remaining comments to consistently call that thing > "GUP-fast". With this change, we consistently call it "GUP-fast". > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > mm/filemap.c | 2 +- > mm/khugepaged.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 387b394754fa..c668e11cd6ef 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1810,7 +1810,7 @@ EXPORT_SYMBOL(page_cache_prev_miss); > * C. Return the page to the page allocator > * > * This means that any page may have its reference count temporarily > - * increased by a speculative page cache (or fast GUP) lookup as it can > + * increased by a speculative page cache (or GUP-fast) lookup as it can > * be allocated by another user before the RCU grace period expires. > * Because the refcount temporarily acquired here may end up being the > * last refcount on the page, any page allocation must be freeable by > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 38830174608f..6972fa05132e 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1169,7 +1169,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > * huge and small TLB entries for the same virtual address to > * avoid the risk of CPU bugs in that area. > * > - * Parallel fast GUP is fine since fast GUP will back off when > + * Parallel GUP-fast is fine since GUP-fast will back off when > * it detects PMD is changed. > */ > _pmd = pmdp_collapse_flush(vma, address, pmd); > -- > 2.43.2 > -- Sincerely yours, Mike.