From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CA0CD1280 for ; Wed, 27 Mar 2024 15:40:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4F476B00AA; Wed, 27 Mar 2024 11:40:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFC276B00AB; Wed, 27 Mar 2024 11:40:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3FB6B00AC; Wed, 27 Mar 2024 11:40:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C7776B00AA for ; Wed, 27 Mar 2024 11:40:58 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B296A07D8 for ; Wed, 27 Mar 2024 15:40:58 +0000 (UTC) X-FDA: 81943232196.20.D7F29B9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id BB2328000B for ; Wed, 27 Mar 2024 15:40:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y7y9hYHu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711554056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rATdLTObDwylu0nu470hnr834O2jOH2Pl2iT/o+Ne7w=; b=lb5gGWph9sYdZkQ3fjShmuWaS1/yVGYJxAKxjdUXKJwh8V22arGkvT5ftnk74Hu61jussm mUr+GCxjb+YikcdBm83iyF1gEK6JmX76tFmNgAZ78GEeQtUqcGsPyOEuvBWDPxZQ71+8ys rUqBtKpfB77MzxEQfiRO7DSNUJp0Pp0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y7y9hYHu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711554056; a=rsa-sha256; cv=none; b=Jzoq5Sv63Le3dtzRFlFTCCp1Kk9kV9gG85i1zkh57EeTt1nPm2SY76jJpCamefwRLON+Js EW9uff8iFIedSH4tbdBVBnKn92FWM6eyfrxOUKiPx0c9r5e9kb3D1aMqSXAvTm+Imj5l4o nGSAIP+2pOY/OerWJt5t87klbXVVl50= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CCADD615C6; Wed, 27 Mar 2024 15:40:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BEBEC433A6; Wed, 27 Mar 2024 15:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711554055; bh=HNlX16yEhkMKnQYWOX4sU3T+8rc8JG5/hnyo+cviw3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y7y9hYHuRLtHvFLwO8Y4NO0itC/fk4QqmGjSusGf91p3QG5DF6iyq1cxHOvvstzI0 edCWgqhb/0nQbxWRTgf8biJg0d5OeT9/fbxX6E/GjmojuvotpQOzjJ0fTSE+bjk13Z 21wIMYhkIy7dr+27z0Yzz2IZdMF9m0HoRyEgdrtyqkn7d/Lxic2MM5TmmEfclHRjaG TMc7uLg0ymzMNuHxyfmESWSNzMzcnrRwnwI18Zrdq9w7rmLyzP1CQ4DRxYinYyq+xY P3tSh6w6HlL+vOS/Flq9BgOvcdfVDQyD20LMrIQR5rBkNZ0rl1e+G4RbiPKlwZFoGN dI6A4osqTA2Qg== Date: Wed, 27 Mar 2024 17:40:12 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 3/6] mm/mm_init.c: add new function calc_nr_all_pages() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325145646.1044760-4-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BB2328000B X-Stat-Signature: 4q1ojsahobafnghs5zrcen67jbj7nfdd X-HE-Tag: 1711554056-892943 X-HE-Meta: U2FsdGVkX1/qEOLY2TKsruvQEx3nvdAS5fxjHG0IVL6Q71WNx7KCpmkbQC/Bebk4YumKZf0jVRSRaxd8phYRO2/Wn36t9T6YRravkURCJWjMVER95x8IOSc5P7l8ijGs6qjZvpAOzPc5YYuCogR3vbM8sQqvnAejcUGfHsxA66GofJtyOrU7zm/4Ylm0vpiUTetvzPVhfSaEg7PHqfmwkCcGhPE8X6xh74PoMOD0Ti4YGwuNeR//Z06Y+nVGOz/r0uZx60kHWGoOf1cQx5tSvp/SRZsf5viUglNZrLa+scHnETzJaf7GfP3IMigWQfI9HJu4OPRnQc1byr9ejQw2IMhddrZK0uy4DRWpR0kgm02gDhJdtvAKmrpl61kzrbAvyiCkr+ivqgVw1QbsARDo5sAFip15aW3ohfpIG/clhvf2ccZrWicwV+M/Wr9KCzA2lHLnVeHaSwky77Sr99EGNqJpCm3/KxZHDN2XXHUnB9jir7N3hJoOE3YEYjHuJHJF9jGtkAeOz8jjWi+4yS0zypwyTgk72IMLR+7lMHekbrjNmDj/4rYTR+Bin//ocgd0PrpBO41sZ75xgPmQcDpHCVE5RQcaSfcvCha/a/xRZf4FRYebX/OiXyTlUny+vltdriNIJEe4cFilmO/+H+fDUNr8coVqQjxhh9d3QXfy74AEXjQSZyQlktbfqcBaZ3H1A85zR9jGzNJuR5UIdBaaqfUZZD0ZuiH5GJnXwbyQTUSQrOmH4PyzyA+q61L0RCKQIhO14SlLzT0nRgvRxlDIe0l4ax3bUUSL8CxiqbXCr80bMMJVi3ZevRUEJRLyXW9zsBX+yfkfHCDbkJ7hYuJMtQGoWUCIgo+apVxD0wRFUCv2sdG2TqU1ylhi05obzIWm3FegS2rgW13ZfBc3DNSbykS9Ii2FqwLrVKGTyE7Rdi0uos+qXlfvDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 10:56:43PM +0800, Baoquan He wrote: > This is a preparation to calculate nr_kernel_pages and nr_all_pages, > both of which will be used later in alloc_large_system_hash(). > > nr_all_pages counts up all free but not reserved memory in memblock > allocator, including HIGHMEM memory. While nr_kernel_pages counts up > all free but not reserved low memory in memblock allocator, excluding > HIGHMEM memory. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 153fb2dc666f..c57a7fc97a16 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1264,6 +1264,30 @@ static void __init reset_memoryless_node_totalpages(struct pglist_data *pgdat) > pr_debug("On node %d totalpages: 0\n", pgdat->node_id); > } > > +static void __init calc_nr_kernel_pages(void) > +{ > + unsigned long start_pfn, end_pfn; > + phys_addr_t start_addr, end_addr; > + u64 u; > +#ifdef CONFIG_HIGHMEM > + unsigned long high_zone_low = arch_zone_lowest_possible_pfn[ZONE_HIGHMEM]; > +#endif > + > + for_each_free_mem_range(u, NUMA_NO_NODE, MEMBLOCK_NONE, &start_addr, &end_addr, NULL) { > + start_pfn = PFN_UP(start_addr); > + end_pfn = PFN_DOWN(end_addr); > + > + if (start_pfn < end_pfn) { > + nr_all_pages += end_pfn - start_pfn; > +#ifdef CONFIG_HIGHMEM > + start_pfn = clamp(start_pfn, 0, high_zone_low); > + end_pfn = clamp(end_pfn, 0, high_zone_low); > +#endif > + nr_kernel_pages += end_pfn - start_pfn; > + } > + } > +} > + > static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long node_start_pfn, > unsigned long node_end_pfn) > -- > 2.41.0 > -- Sincerely yours, Mike.