From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3075EC54E67 for ; Wed, 27 Mar 2024 16:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D0416B0085; Wed, 27 Mar 2024 12:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 781596B0089; Wed, 27 Mar 2024 12:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6480E6B0095; Wed, 27 Mar 2024 12:22:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 45D0A6B0085 for ; Wed, 27 Mar 2024 12:22:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6ED16804FB for ; Wed, 27 Mar 2024 16:22:08 +0000 (UTC) X-FDA: 81943335936.22.87DF677 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id B9EDD40018 for ; Wed, 27 Mar 2024 16:22:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IavBJGsz; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711556525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g4Ro1diaAhpyahkrIs4Gfq8gHs90ko+mPMzWttBtxqw=; b=xFDa+Mv7185fEMC1P2p2DtQz+3Uh1Lwu2w+ekUhh55U0YnzfmuHDleq/v7awZ9PuKdKFcb aU7TQ9kbFM5vPqM1bKILsOh3OOt+Nrn3q1dJ58z0cVe7rmRI2UIPdhA+2cmJJCv96POJzD G0dS7rPDUt4Rp9maK9VAgh8sVPzbH18= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IavBJGsz; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711556525; a=rsa-sha256; cv=none; b=v0PWCF+qu1CjzVkzvoVr4V9zFWxixztOWu9/xjf6S5xM7jlWEF2b9LuRZbUeTCoqmLQe/8 +5zhRbIC6PcqI3u4rZgg01hvrUdELvvlAp0a3c+SAwyCwxlahTVHKhmC83lr5tG5BmGcy4 qtjaNpa1/XaqaHCX55h/SlIZtxyDIf4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A6DFD615F0; Wed, 27 Mar 2024 16:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE561C433C7; Wed, 27 Mar 2024 16:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711556524; bh=/HwfEIPp2rgEplQNov6HPpeEoXKzTzryrZH4IYBxJHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IavBJGszFmAlc2pEn+zfe6ZTmvjuzS8OniqKBl3fq326ok4Z1/lQIFhubB5J3YlF+ UJ7cH6fmsukvoIbMe+qb0s38Dpb5PZkO6MeQepUNQjTYesXIsI7Tt6Okk8maBGjSOE 2ZjVJLDIGgdH9xzzcM3kKRi0rqL4LQ0EAJjGeovCvCD4A6h/kwamy8QttJ8EIgV/zp IzQAw0jKezVA3KsiiT8nk7Tn7rm+KI1haka80NRE9CgIVAe6TudWIlsqAq3Su1BT8/ j2oRBxYxdj1bTB2sEPjNeWwA+TXigfhS5Lc9NBty0edAy6fDSDCpgqHNsZ1UG/5piz SSHvZMjybuQKQ== Date: Wed, 27 Mar 2024 18:21:20 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 5/6] mm/mm_init.c: remove unneeded calc_memmap_size() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325145646.1044760-6-bhe@redhat.com> X-Rspamd-Queue-Id: B9EDD40018 X-Rspam-User: X-Stat-Signature: 69xb4uyy14x49y8hozwwh4p4apcokn89 X-Rspamd-Server: rspam01 X-HE-Tag: 1711556525-943109 X-HE-Meta: U2FsdGVkX1887RFEkja40m1qjziivPQxGdME9aTAg3NbQKpcxZz4ww6xUiMkeQb8Q/1wHkNOFV7NBompXppiVd2nDByu7mDmmSBdXV+s7EJz0GaiNDwIXIJFvpTzO+EyoBzr21xqtdxaIMYWB6UVj4tMn0IH44q3IWJtnVzuwIGJe/bn0lyFl2MuSXJI9AVJK7IG/lxdrlwaN1ZbXGl5yV0l85Hft1/1wOCP/WDW7Q78+QkODF/1McYD31QX8bHFfj4bUsHGbyoAmhSnNHuBw/VipjZDRWc1VpCDBtQsgMmO99LLHANwHMFviBDuGzrHD0bCM20uP2xlmCaFDgr7rVklxNuu0YVqqXclXhq89PuSqmWIZVVwMkjjkXuHwUcOzGViOmC6X1SlXEEzljTTmJBoxeAO5TRXYeJGe50aJ7nsNM3DxIG4Tr4gwQB7gL75U2CrDHVbBkNq//8tmxRSNNrXixCgWMjC8z1pS2KHml+uWr1QoGhFzeUm9yq/ZUl+3yJPhd8xtEZe1L31hSJaQcLARTcxVqHkxMmmBF5mGFduo5qFGgKpnMMDZP3KEJKdEDBZ1h+MaaObcEpiUMPmivrHQZBuM1hQ7FTM8aoQCxoJ9hua1MMv7rLCvM/s/Bk+2hO7yt3VwmOp8OdViLfOJ2roOM3KC1ULL9IXtM8L1Ip2IAPEVsdzEFildSyzuR81EkDDYL2LdJdAVbacHIGZG+LEjFYSRD+POpy8IvrWheBFAqRxBDzPZLoFwjznPSPUH4jA6UdGkNprQDZde1k4YbjsrURJrwhk5+SbMjnYLPtqvIE5X0GTPX0NfycqW8p1bfDu/fpNDl1LepKSv++zlL1U2Esvt552KEsfp/9XRYgXqyAsJe7E0pcn+LNZnsr17qKl7bWgszVSKVKtKpfBOZrs3+lneUk+vMvtNd58HMDDYSUPP1nOFM9JDb9KclX69RzbjLtf233LlU0Azen 3K6qwvI3 1voSV/FoBGkb9pm1RmtPMEaZ5ETuCPB0pLE9QDQrEjMhe79wj36NVKOSlMzhkIk7VRsmT1Z2cRVkMI2vo7F0noiBQ/5qzlozIabYpSXQEgBVnHFWiSwvQebxVMe4Pjoowb/3aq8jXy7mKOpSl4hKDQRz9RY3Uey7w78LSencDIsv01fR/Pr9W3rwDuZjF/s4A6FDyYC06NtqeHVe7JNM+gjLG8jtvNY3hLjiYDkBYZ5UHf+SF2X0WTwJdVQhSPntL9veK/Hs6GH2PnfsqPybLopffF42YnhKV4r86Funklmj1XdVhdgHx4Sp/ubVvg57HEQSj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 10:56:45PM +0800, Baoquan He wrote: > Nobody calls calc_memmap_size() now. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) Looks like I replied to patch 6/6 twice by mistake and missed this one. > --- > mm/mm_init.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 7f71e56e83f3..e269a724f70e 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1331,26 +1331,6 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages); > } > > -static unsigned long __init calc_memmap_size(unsigned long spanned_pages, > - unsigned long present_pages) > -{ > - unsigned long pages = spanned_pages; > - > - /* > - * Provide a more accurate estimation if there are holes within > - * the zone and SPARSEMEM is in use. If there are holes within the > - * zone, each populated memory region may cost us one or two extra > - * memmap pages due to alignment because memmap pages for each > - * populated regions may not be naturally aligned on page boundary. > - * So the (present_pages >> 4) heuristic is a tradeoff for that. > - */ > - if (spanned_pages > present_pages + (present_pages >> 4) && > - IS_ENABLED(CONFIG_SPARSEMEM)) > - pages = present_pages; > - > - return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT; > -} > - > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > static void pgdat_init_split_queue(struct pglist_data *pgdat) > { > -- > 2.41.0 > -- Sincerely yours, Mike.