From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BED4C54E64 for ; Thu, 28 Mar 2024 07:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB68D6B0083; Thu, 28 Mar 2024 03:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C66B96B0085; Thu, 28 Mar 2024 03:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2DB76B0087; Thu, 28 Mar 2024 03:16:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 948616B0083 for ; Thu, 28 Mar 2024 03:16:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D78744106A for ; Thu, 28 Mar 2024 07:16:15 +0000 (UTC) X-FDA: 81945589110.17.BC11803 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id AEC0D4000B for ; Thu, 28 Mar 2024 07:16:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="NAmN/m71"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711610174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yu5IdRwuipFRBL5S54W4/9KxNeo1TN0epoM2FAtBwqc=; b=ckzWPcV99yDR0ra5OOuGrZ5aFdSVv6xV+v1Z2LXg0wANOMk8XVtCPuLR9dA00vHRrTIWlC ezlI51+ZzUtUS8k6U7BxHKZIngCblsfFOI6x1lBfgEtruR9dwq6fxLle7cgDq76QBp5ovH RalMa3tPkOVKTDqZHSNnqZLEDeIBrqs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="NAmN/m71"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711610174; a=rsa-sha256; cv=none; b=c5JBuUIh0KGXUXliSgCXW3Dx713roukIHi0YvXB41uzuF9QUW7DHkAxHrt7yZYnabQsfh1 oFtyTJKfnDLD2yHz+ZFyFtuatw1DnWa0v7mHnDFfh2pnYg298+Q1qilREhlcib2NvPhZmX ItA9zCHJW2FIbX1Ce7t7oGWXUUSyFfI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 77550CE2936; Thu, 28 Mar 2024 07:16:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13A23C433F1; Thu, 28 Mar 2024 07:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711610168; bh=r1JsHv6zvguqW90jyEY0U/U4DMDGMKwYQjCJCqIjmk0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NAmN/m71xn3ib012g07l8sC+gyJIzFt9fFK3jdDigIHga4g8Fy0g4u0A9zMTn2G8y Hz/ArW+aqXuqTPb2fPpftu20+1RkDRzP/XFJQhHXJMj8KYnoe5TCRWhoGwSsNg3v4T H3jfZDkvrEoo5QMLri7RoQDmFW3FyBYt4qgxPfkHDpAB+8Ajo8fibnxufZyqfjrguR dBNlncXj4g94p9pzTUeGHFe+ZO+Z9/1/QE5YeVvQ97AoXIN+LsdR2yhA69cvKvdLXt K7hfz3k4p687HCWjsBvcGXgtiDBmENV6h+EZI1V7LNtQhQ+nyZGFPEfci2N6376cIj b9N3P6mb8dHLA== Date: Thu, 28 Mar 2024 09:15:20 +0200 From: Mike Rapoport To: Arnd Bergmann Cc: Vineet Gupta , David Hildenbrand , peterx , linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Ryan Roberts , Alexander Viro , Matt Turner , Alexey Brodkin Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast Message-ID: References: <20240327130538.680256-1-david@redhat.com> <3922460a-4d01-4ecb-b8c5-7c57fd46f3fd@redhat.com> <3360dba8-0fac-4126-b72b-abc036957d6a@kernel.org> <10da3ced-9a79-4ebb-a77d-1aa49cc61952@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10da3ced-9a79-4ebb-a77d-1aa49cc61952@app.fastmail.com> X-Rspam-User: X-Stat-Signature: hcdpk687x1qrst9r89shtu9xzyxtcg17 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AEC0D4000B X-HE-Tag: 1711610173-504854 X-HE-Meta: U2FsdGVkX180Tjt7bvbVVcitFHqwqKqgm2R86Zh1LgRUsPBMDYkZ2JQL2KAjr57OBacg/kSgAbff0bDVlKY1/3bSmfVWVhlEZmDDsvk78OmmLLUAkzorEeuuO2HEeXiFVlWWpkhD4qmpVEmHNllNfhAuaflXQlLPVZyfKWhOMyJt0SApo8RhZqJJNJUGLGerlMIBFYKW3g/a7PnTbfalg/2tOspynJPzegnEi1ZMzCpntz0PNfpxqBBCQDL2P9H1XvCfP61aH5/EpHoZMd93lfnzZIAnLd7l/XaMyNm07MBjak+UPhqPrgaf0P9k1e1Gm/H4UaYIeJ9TcvsnrIVZrrqhx/WNZSEZgVsaw8oWroqF7MtaK2jwP9fgeszwSuWZglilzNDAosqKozpVe+2liqtbqGhvWGlESCwtMdrl/fkLPijhbP1wPF38ZkHwZEY3FB0CiGt6JejtJ1UgMUYTm86UPkTM14gC14atKKYnZV9499fnhXZ/rdnji0kx70VcVgb2EjalzzvmE2IT1kkiwOsBZBFGvwpz5+AgGKn1U4Ig4SxWo7OlqmMjMZSl86osxQifBI9PvSJN/KkqRyHnpth7uRbz0WAVseVNiFjhuQst/KLIm4UMGWTUEkN4ZGfyuuljgfWAKQC2KGneT0tSh20GuKdUncXHhiW89OjYfVE5B6fhH3Y9lHzyU7kBBf5rxWD7jEqcyMwfqberqA03yQvEgBALjOO8wX0TaLSD2frYuX24o+nTy1/7fBRhs68ERxfnGTJJReSYYClmPZ+Ee3y10Dy1En0YliAWgiefof6mhO/t+3qlHSk5lJLjjI6dtMgaF4xgApcLkuaVeTPtHHkiQySMDCcY/15E0J9qLhaN9DRIFxeY9chv7tgO91n42NoYvDcvlZH6r/pw1Rmyr7Rmtlv4vo/DWh2Hh3Oqka1KsxCk9oSc3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 28, 2024 at 07:09:13AM +0100, Arnd Bergmann wrote: > On Thu, Mar 28, 2024, at 06:51, Vineet Gupta wrote: > > On 3/27/24 09:22, Arnd Bergmann wrote: > >> On Wed, Mar 27, 2024, at 16:39, David Hildenbrand wrote: > >>> On 27.03.24 16:21, Peter Xu wrote: > >>>> On Wed, Mar 27, 2024 at 02:05:35PM +0100, David Hildenbrand wrote: > >>>> > >>>> I'm not sure what config you tried there; as I am doing some build tests > >>>> recently, I found turning off CONFIG_SAMPLES + CONFIG_GCC_PLUGINS could > >>>> avoid a lot of issues, I think it's due to libc missing. But maybe not the > >>>> case there. > >>> CCin Arnd; I use some of his compiler chains, others from Fedora directly. For > >>> example for alpha and arc, the Fedora gcc is "13.2.1". > >>> But there is other stuff like (arc): > >>> > >>> ./arch/arc/include/asm/mmu-arcv2.h: In function 'mmu_setup_asid': > >>> ./arch/arc/include/asm/mmu-arcv2.h:82:9: error: implicit declaration of > >>> function 'write_aux_reg' [-Werro > >>> r=implicit-function-declaration] > >>> 82 | write_aux_reg(ARC_REG_PID, asid | MMU_ENABLE); > >>> | ^~~~~~~~~~~~~ > >> Seems to be missing an #include of soc/arc/aux.h, but I can't > >> tell when this first broke without bisecting. > > > > Weird I don't see this one but I only have gcc 12 handy ATM. > > > >     gcc version 12.2.1 20230306 (ARC HS GNU/Linux glibc toolchain - > > build 1360) > > > > I even tried W=1 (which according to scripts/Makefile.extrawarn) should > > include -Werror=implicit-function-declaration but don't see this still. > > > > Tomorrow I'll try building a gcc 13.2.1 for ARC. > > David reported them with the toolchains I built at > https://mirrors.edge.kernel.org/pub/tools/crosstool/ > I'm fairly sure the problem is specific to the .config > and tree, not the toolchain though. This happens with defconfig and both gcc 12.2.0 and gcc 13.2.0 from your crosstools. I also see these on the current Linus' tree: arc/kernel/ptrace.c:342:16: warning: no previous prototype for 'syscall_trace_enter' [-Wmissing-prototypes] arch/arc/kernel/kprobes.c:193:15: warning: no previous prototype for 'arc_kprobe_handler' [-Wmissing-prototypes] This fixed the warning about write_aux_reg for me, probably Vineet would want this include somewhere else... diff --git a/arch/arc/include/asm/mmu-arcv2.h b/arch/arc/include/asm/mmu-arcv2.h index ed9036d4ede3..0fca342d7b79 100644 --- a/arch/arc/include/asm/mmu-arcv2.h +++ b/arch/arc/include/asm/mmu-arcv2.h @@ -69,6 +69,8 @@ #ifndef __ASSEMBLY__ +#include + struct mm_struct; extern int pae40_exist_but_not_enab(void); > >>> or (alpha) > >>> > >>> WARNING: modpost: "saved_config" [vmlinux] is COMMON symbol > >>> ERROR: modpost: "memcpy" [fs/reiserfs/reiserfs.ko] undefined! > >>> ERROR: modpost: "memcpy" [fs/nfs/nfs.ko] undefined! > >>> ERROR: modpost: "memcpy" [fs/nfs/nfsv3.ko] undefined! > >>> ERROR: modpost: "memcpy" [fs/nfsd/nfsd.ko] undefined! > >>> ERROR: modpost: "memcpy" [fs/lockd/lockd.ko] undefined! > >>> ERROR: modpost: "memcpy" [crypto/crypto.ko] undefined! > >>> ERROR: modpost: "memcpy" [crypto/crypto_algapi.ko] undefined! > >>> ERROR: modpost: "memcpy" [crypto/aead.ko] undefined! > >>> ERROR: modpost: "memcpy" [crypto/crypto_skcipher.ko] undefined! > >>> ERROR: modpost: "memcpy" [crypto/seqiv.ko] undefined! > > > > Are these from ARC build or otherwise ? > > This was arch/alpha. > > Arnd -- Sincerely yours, Mike.