From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5886C54E67 for ; Thu, 28 Mar 2024 10:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E5516B0088; Thu, 28 Mar 2024 06:58:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36E446B0089; Thu, 28 Mar 2024 06:58:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 236EF6B008A; Thu, 28 Mar 2024 06:58:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 01D0C6B0088 for ; Thu, 28 Mar 2024 06:58:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 996C580AE5 for ; Thu, 28 Mar 2024 10:58:46 +0000 (UTC) X-FDA: 81946149852.12.E66F94D Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 92F1414000C for ; Thu, 28 Mar 2024 10:58:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZZo13hja; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of qperret@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=qperret@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711623524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u8ZQFWzPDIrF3CuMM0f5B0XY6jp3IE2F7J7SSG90F6E=; b=xqLGRlDixfpk8TNoopzr+xzQ34cM62peTOkWZcbDfh6+aU67H028lBleB1l6rI5vwM75nX n7uekaet3iKlGOLGyOAfZylsx2qMhSiXT6xvMXxKjTUUFn3EYk6lP4NqtOgDASMhNWgrHC 890QyoqSldolPDVY6yxMDN/Y9kKWNzo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZZo13hja; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of qperret@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=qperret@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711623524; a=rsa-sha256; cv=none; b=xOx4qbuM2YedmJqgKTO4pGfBGNT8bAldu3bOgGsWfB8b3KS0TqOPi4R5HDcrLLuTd9tKnG 5zTKpbDXtPwkp6+Uv/6PjVm6noPqC3RAztAqQTTjH0Zx4TXvD1Vi5jijd37ZCF/kyg4UhD 3vI8MCH93xry+FvULgkzzXPffNYEIAE= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-56c36c67deaso936484a12.0 for ; Thu, 28 Mar 2024 03:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711623523; x=1712228323; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u8ZQFWzPDIrF3CuMM0f5B0XY6jp3IE2F7J7SSG90F6E=; b=ZZo13hjazy9jkyeLcmBO1XxyYkl2Fht6utmAm0wgROqs74u5w29QrCVjNqzCl5gBNJ 5XHkmRs0Hdi/ltTtSsFm3SMWpR88U+VZze0eCMvUsqtiKgtBM2fIjJGpBCYw5OGkG/Ob +BT5v5/J7U3ZrrCJEcbJWqeue3D0KC2at+pX4tFcgSA3xJnpFkOL+aHfWHXsdIZG5gCe DQuSmVz8cahYz2LWq+xCqSPkb20HMUxHjNBQB0R1Pyj7ddNMoXX3c2BJJBOI3q5Fun02 vViGxTMj8h6jTH6jNYxj10ZSmDF696vIuaH17snfMc09E1+0HP0mniwN2CzpBbi/C3SJ ImJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711623523; x=1712228323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u8ZQFWzPDIrF3CuMM0f5B0XY6jp3IE2F7J7SSG90F6E=; b=b7omrHPHLKHiLH7TADKE5lvZkavi4+PJpomo7PV4a35EDqcWIdSFZoV1Xq0Mu+mw/8 ipHcu1d6/1ncGrAjelgQIsg5mfzW4/t1szJvqVrAlvY9sn14jdFt2DXKZ+nUoGVZEYn8 y/ws6fVXVWc0ic3C/SDL4Z/U+7Z8gD6Z1yJQMZErKEp/aR9gS7N/wfLNAB3/jgSHHbkd 76p+bzmAC5qYzkGYqoZLPuiA09B8cXC9lz8WjlnYt5LKttXgp2aHAT2UfrV1fYiXFEhk JLqip6vUCaHQk6kYzElSM4btRRLAemSM8uREmjDeeNjT/nvY4+WLj5ugJ+WQSMXsyt75 0kxw== X-Forwarded-Encrypted: i=1; AJvYcCVoNsj0z26h4nmdpOpjescY3+7K5j02YUZQzC2U4h+PomfOI0ICg4g3x6FxDwOM3WtYiPEXmABArcOPDeGwcpFj+Xw= X-Gm-Message-State: AOJu0YyUlCh53hWhOVBBZAHeyB4kldZ2Jqv01UyagwTRp63e9I5acV2T Jb6qbeBUks6z259cjSTMhsgyDgeIi9QMn1V5bXFlOuaKUuyw6caWtHihkfMb8Q== X-Google-Smtp-Source: AGHT+IFz6L7DUIGFP2Hr6sv1erUlly4EFBC5ORIiQg+IMjzxvFI79NB3IXUA7dV5PbKsHLbd6MH8KA== X-Received: by 2002:a50:d5c8:0:b0:56b:a017:10e with SMTP id g8-20020a50d5c8000000b0056ba017010emr1602749edj.42.1711623522711; Thu, 28 Mar 2024 03:58:42 -0700 (PDT) Received: from google.com (61.134.90.34.bc.googleusercontent.com. [34.90.134.61]) by smtp.gmail.com with ESMTPSA id h7-20020a0564020e0700b00568e3d3337bsm686755edh.18.2024.03.28.03.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 03:58:42 -0700 (PDT) Date: Thu, 28 Mar 2024 10:58:38 +0000 From: Quentin Perret To: David Hildenbrand Cc: Will Deacon , Sean Christopherson , Vishal Annapurve , Matthew Wilcox , Fuad Tabba , kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, keirf@google.com, linux-mm@kvack.org Subject: Re: folio_mmapped Message-ID: References: <7470390a-5a97-475d-aaad-0f6dfb3d26ea@redhat.com> <40f82a61-39b0-4dda-ac32-a7b5da2a31e8@redhat.com> <20240319143119.GA2736@willie-the-truck> <2d6fc3c0-a55b-4316-90b8-deabb065d007@redhat.com> <20240327193454.GB11880@willie-the-truck> <5cec1f98-17a5-4120-bbf4-b487c2caf92c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5cec1f98-17a5-4120-bbf4-b487c2caf92c@redhat.com> X-Rspamd-Queue-Id: 92F1414000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3nq4p5o7pyuk66pjs6aoh4do8hu7si53 X-HE-Tag: 1711623524-884859 X-HE-Meta: U2FsdGVkX19iRunlU8D2ZruqTe9Ll1nQFsjrFqAzPeWlz4JNgUf9aGkwYBAdI595NZUIDiqqCE4jRhwJ3IfZuQBVLJXVT7RE2MubWb43Bfts3iXlik2uQal6AVtPISO2s/K1UrVMhTRbOkXTx3K2w6N9yp55omEh53trJ9O1TcCer2xfRVRhm8NKvPF9mHiM+n+x0J+SSXzkW6200zLf4hLPaEAy0G+yYuh7fqf0Qcwh6hIPzQCCkPVRjx+3CSKXcDt8S/Z/0+EzD354enrCvqKkjTZeruvWKAV+x0A4h7vjv8jB85B+uF2Yx9gkoXYXw4CPnPGI3grIK7wYGFGsZTNpaOIT6MV2+mnvgvNCGEXNtQalt9cigw/pCup03dzoNYoKnwAB/vUcpmHwIllWr3iC0TbRb8SzFqSe71TN6lwY9i93XUwMGWX4jDQn94dDMf+Ewy+dFSniScv4MgqERVbzzL8Sl5NWfsEUowRTwpCIPt2T5lECtDUfrvvC+Zo1y606at2xMeIx2gm2LeKT3LclK4EZPi5S9eT6lGiP6JqHTfTKLpVHxQn2Pa/mZvFrf+Q2lFDVh9Z4TDxLq74uXLpmphleJN3sn3NUvW7anH4GwuOaFUWuRzZ6LWj/51vEJVXqpq341e97y5Wy+4p5U/tvNCvxmvB5LMPvF2064nUmQLf6i2bADvvJL4lx4vd/SuY3BOTCu4fm4D1QentGhF88eJcC7Ud0r58fOuARAucF0oYjZYE08eamQGR2IwA/8fdOHaAyCK7WAk6RFuxUxdsKxW9puzKiylv43Qvj5MVpa7msRkXw3jLoJNZZ0C4Zykq7rWNWMyIYfj/yRQ6P7LK6xCyc4meCzAHK8Nm8WY2b2J76RYmahGulniAcOU53GyZDOIaoHmCj8DHH/8l7ThrFdpJGAa37u2AzzIaFKCfZXfWGM3TZQF+QiP5jdcJmGRyiSTvV2hRDq57B43w nCYzUfC+ 9ssxEj3tS7RKjNor1hQjzPuKofbMhHkUs7rCQJiZSAGvNWVJS1ouYpC/Hte5o1yENFbZz4x2rCgScLedeLwJ9Es1pbJ6T3NrDpH56n0tV3ZMv6X+i0xWN5Bx1XmuAQCgFW4bTbZqt8lsDgj+jb/SuEESm+fRv80B/H2hURSFpQovzEXzRV4MaOmpUUfQeJ3R7hksC+5euC/vTtT9pJoVZJ/T4R4RjUJuBCS+QPuUzTRLkY2qoUelPK9N3l7bJMjOayAxb6XzZmrEwozCKUv7outVNVNdajO+JpmmNkmZ2s86C6msl3ZxkCf0wSFUnu5+q9d8XzipyjQ4KX7YfZOKuYbUjfmrygUseiPRgHYI7GNAdZM6uF+UJzKYy7TlrqIDz4xwaJvv+NAJQajs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thursday 28 Mar 2024 at 11:32:21 (+0100), David Hildenbrand wrote: > ... does that mean that for pKVM with protected VMs, "shared" pages are also > never migratable/swappable? In our current implementation, yes, KVM keeps its longterm GUP pin on pages that are shared back. And we might want to retain this behaviour in the short term, even with guest_memfd or using the hybrid approach you suggested. But that could totally be relaxed in the future, it's "just" a matter of adding extra support to the hypervisor for that. That has not been prioritized yet since the number of shared pages in practice is relatively small for current use-cases, so ballooning was a better option (and in the case of ballooning, we do drop the GUP pin). But that's clearly on the TODO list! > The whole reason I brought up the guest_memfd+memfd pair idea is that you > would similarly be able to do the conversion in the kernel, BUT, you'd never > be able to mmap+GUP encrypted pages. > > Essentially you're using guest_memfd for what it was designed for: private > memory that is inaccessible. Ack, that sounds pretty reasonable to me. But I think we'd still want to make sure the other users of guest_memfd have the _desire_ to support huge pages, migration, swap (probably longer term), and related features, otherwise I don't think a guest_memfd-based option will really work for us :-) Thanks, Quentin