From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D7FCD11DD for ; Thu, 28 Mar 2024 19:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 132CA6B009F; Thu, 28 Mar 2024 15:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3006B00A1; Thu, 28 Mar 2024 15:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC5A6B00A2; Thu, 28 Mar 2024 15:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D08076B009F for ; Thu, 28 Mar 2024 15:46:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8A43A80834 for ; Thu, 28 Mar 2024 19:46:44 +0000 (UTC) X-FDA: 81947480328.14.4E02465 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 9FAB71C0011 for ; Thu, 28 Mar 2024 19:46:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L8I2ePW2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf18.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711655202; a=rsa-sha256; cv=none; b=747OAqSGhAyiPbdbrY4nveY55NdAfXD6qTTfphpABfG+xCjObWPZxN6SQulR15mIUbts2h ScdgrVsvnAL0LBAMNACo9GjIUl0zcH2OtdhM3wEis/xMI4UOw8v4PnX2uMji+Uvw3cFUQr ExOIKFJxS/TuL0njSz4RzbQgXojcey4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L8I2ePW2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf18.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711655202; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uT3+EvMk0DC3SU3LipXNa10bWu769Nw/MuJjqYhTZRY=; b=ILrS++PWCTl+BbLHvG+eieJ9Jy71n2mMPnTuTY/zSh2BEAZEweRel1d8DWymLPOwxRhCH7 0SW2OB5KDrctaL+6DvI4LCugD9+vrfGkH/RWrlL/5WvbO4wZ9LNoS9V8/fYdmx4RioxPGn pMYpcATgeD36A1L13wljY8b+mzK6xeM= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6ea838bf357so1196611b3a.0 for ; Thu, 28 Mar 2024 12:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711655201; x=1712260001; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=uT3+EvMk0DC3SU3LipXNa10bWu769Nw/MuJjqYhTZRY=; b=L8I2ePW2QiDBbBJGSrJOJ5NI+SeHvDbb74FQxd2YidMncn0vqzz6B+eI70e4Oqfahc 85goVQeEWdfGBWXbOAUEzuUxQuECQYHp7IDUc4F+SW4KqpGJZQsy4lOk9YtqOXkmHLT/ 95u8yuEuB5ufrqpwlmz5J+XGZoqeSH6MMSSKthAbkehsReyiBaYjLpoLjmWo4aSfHkgO 4BPErymyashTpOfP4JNTC/s+S6nDVXdknGoWiePmWN0JaqnnFqGmHyzg+y9Qg5ld8dwo X2t29SpXptAYb6X77od8wySBHaC5v/C0Dn4+DaPOipKoDeYX3QcNyoamsIHD/SnFBc3H ChZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711655201; x=1712260001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uT3+EvMk0DC3SU3LipXNa10bWu769Nw/MuJjqYhTZRY=; b=g76qZxC7d30dgtPXHQUJxGIkVhMz8O2bxTQoGnvU2x1ibxNSg3gjF81O+MiZgPuFjA kDJOO00S4XBbfb+ugM4nw8Qg2gkdbr21sZIW1eoYequTqFPr5HI8T1WXPyLC9M4FCqpO g7gQQv2iSI8GOKlgSIhZ+FNgSW2Xnc2iE+dV0wY0vc65eQB/7hq0j3ZWwMkUTg8Jc7OO bBt3WKjA9V8rxoq6P98txncnYDY8RMBE3iuwFx7bq2j+7uZwPuZfZjkkFyd4ASawQx6C yp3CXAm/a0cP4vgdk3F8D63dlosHJCdobGNlmaxMgrxvj8JRI/0xbCEyaiwQV9XVHFPC BiGg== X-Forwarded-Encrypted: i=1; AJvYcCUNUeJUL48AAMVMDOoVXFdwRDbc61MTszTNL2e/emN5LwGHCq0hrEGLpXRh+1I5SLcjttLz1PWAFEKY+dswA1sg2vI= X-Gm-Message-State: AOJu0YySVLt06P2lTnzd3KoVASCoTjvdU0Sg3i5hTvdF7Y8Gycl85lTn hYWo3e9anAlesLQTokH1ykMMvF+xkyFFXEylNEUsUbNWTcFvPQWh X-Google-Smtp-Source: AGHT+IF3eoTQgD9p1GZXsRa08ouQFunv1CReXF3z4bK+mnRZ/sst243Nva6MmFlH7Lv8JBr8KGEIyQ== X-Received: by 2002:a05:6a00:10c7:b0:6ea:e2d8:473 with SMTP id d7-20020a056a0010c700b006eae2d80473mr303558pfu.6.1711655201451; Thu, 28 Mar 2024 12:46:41 -0700 (PDT) Received: from localhost (dhcp-141-239-158-86.hawaiiantel.net. [141.239.158.86]) by smtp.gmail.com with ESMTPSA id k7-20020aa790c7000000b006ea916eac02sm1753620pfk.42.2024.03.28.12.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:46:41 -0700 (PDT) Date: Thu, 28 Mar 2024 09:46:39 -1000 From: Tejun Heo To: Kent Overstreet Cc: Kemeng Shi , akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-ID: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9FAB71C0011 X-Stat-Signature: 73uip3tya8fxspouy89fj1egmrcypaqy X-HE-Tag: 1711655202-666264 X-HE-Meta: U2FsdGVkX1/ae528b/3zMQPijam6vrW+Bpi3EBDdBAk67Ow5uvme2vfWkRqAzJEoeNZY3pdIhuWGZsp92g1PySimsqBquYYHClK8avXPd1yf4oCzRhoq/Teb2SXwfPJtkvYNAgxwMLry0ZkyrCroKvNVhPHWujfZPCvjFzdkwm9ZRFhYxCmTjl3wWHmJCCOK1UaWMIWf31lmVJbAC9kl86cKdCv2iodiHz2si4oTC3E4k79Kkci7RDfIuV2mLICCpz9ojmrmGPNgBiBXGyvA9DjgqIFajYggtInFcRq/WwabWlIMdScvn5DJWQM1vyAye2ueMK+WqaRQ/DWY86zK763wueuXi+5ymMFJsjzIFolHTfXajD4tfx6ZNtPT6OihRMnbz++yQTzYdOs1YjlgBNlpoiXXRBhy2HD5wcKqEOxRCCvD0j82n3bePXqqVkRACPmtkFSzyBAorgZJ+fdHuxiFMBVzKvxvUcVe3ydp1GKsLUMm3KttANtMF8VlOTsaQD4NDe1hGXqpC3FLzN1EyrStPUpEN6JUWmACd2JJcxMl2D+UJRk4qCMKwbMeQEcXC4e45ucbuWbQ70izFwNQWfYNDyqYzR7YHw8mXdQu+52FjytuYT6aPxJfINAqdDisEyJ+4MbkoGYiHtj2ohvaveFA0L0xRueyPYHRQbztzDZ4GaRtnj0mlCJpcyjM8jk07HfLSKyqrr5/OGWBbKIDfpPQ9RIyqTQZW+C40ae4XSBliDhCM+/dcsy6vhp1yCc77EPw9rc9dqmw5U/G1wu3YQfIUDnXLLH0kWTXeVmqP3JzeApMsc7B5poRWOVc6fRn6GacmijLm7VQC5WA4qS5Ik8JGxxYpu36GsRaPMaW1NIkymCp9ZNefnZ+yAzPrh44BYVuoYK3Z6LcYxC//n8UeIchXZqZ1Ds2n0BmbVaJA3ThXjTxVu/ZkaU8//GnZHdMbVzmO6S4IXqjGvjdUPj 54NhTOR3 r1aTB9kbWXQBh4szj3tzUB0e6GFYWpu8MSN2xMjOwYdFbaK6E8Bx3QTZKkEKnEDAdcW0OHuTK2IT9gJQ0TRoMqzF+886muSp7CLFd8r4+/eNgflpTELYkDFTJtZOiHN4A+IMNu96XDCCPwsHrbeHoLIdRtDLGd6PTsAwFKQN63SqxoJi83taA6mvOZCmlJ4rzvJZfCaW/ZacY0lx8ax75W4RDdcm8doH1JPnduL6Qs2h6MkUnk+kFg6sh4ION07YiAk6Atc20K10DzKDdRi65VfUVbfajLSzcx7KEakDNSZzuBuz7ruUoIoAwLRCW2kxyUbGsnFVo9gD51Cmu+nFGrWg01pYHmNBe4LmsR0XU1W+zeJUeadxewJRnflMRIxznwMmNeRSPyRBMRrRTjecgjqJIMHprZrOo96sEblTMp8J7rQ9A9oMi86/W2yaK0zH/KBCx99gbBIbqWDvRewzCy+qSdTr1XFkApnUgBfqZ+TFiusWINQRPAHvyeE1qxMM6vmYm X-Bogosity: Ham, tests=bogofilter, spamicity=0.043217, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, Mar 28, 2024 at 03:40:02PM -0400, Kent Overstreet wrote: > Collecting latency numbers at various key places is _enormously_ useful. > The hard part is deciding where it's useful to collect; that requires > intimate knowledge of the code. Once you're defining those collection > poitns statically, doing it with BPF is just another useless layer of > indirection. Given how much flexibility helps with debugging, claiming it useless is a stretch. > The time stats stuff I wrote is _really_ cheap, and you really want this > stuff always on so that you've actually got the data you need when > you're bughunting. For some stats and some use cases, always being available is useful and building fixed infra for them makes sense. For other stats and other use cases, flexibility is pretty useful too (e.g. what if you want percentile distribution which is filtered by some criteria?). They aren't mutually exclusive and I'm not sure bdi wb instrumentation is on top of enough people's minds. As for overhead, BPF instrumentation can be _really_ cheap too. We often run these programs per packet. Thanks. -- tejun