From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58976CD1288 for ; Mon, 1 Apr 2024 18:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D56F06B0088; Mon, 1 Apr 2024 14:23:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7D36B0092; Mon, 1 Apr 2024 14:23:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B20AA6B0088; Mon, 1 Apr 2024 14:23:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 83B266B0092 for ; Mon, 1 Apr 2024 14:23:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F687160457 for ; Mon, 1 Apr 2024 18:23:00 +0000 (UTC) X-FDA: 81961784520.12.EF4B2F7 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf27.hostedemail.com (Postfix) with ESMTP id D6D4D4000E; Mon, 1 Apr 2024 18:22:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g7jijbft; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711995778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YqcL6luk6kscEpuGjrpNuwg4YQx24thmV194uTw7GBg=; b=pbLbEWXzVPGkmDJBfSH/Hf09et/KwxLE23iBPx0CfS5SF9GCTxUwiPZA0sjZ+giKkPGaxr V4uQk+o7wysBGxt1CwHRfnC5dTqVhYxSSQ4SpGif2zNoi+BtZbGREz9dyK4TcoIasbephU xgcL0LIn1ibVVdOOPJJUheSK0MBRjeE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g7jijbft; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711995778; a=rsa-sha256; cv=none; b=VZBgjyX+m+Txgcib1j98VUNwI4iO8DrEiProfCWSNuWoCji8QtPySx8ACkcPRyd9Ktztr0 r2UENIz9zlyJMrkACzcVRYD98/ACn+vVlR88BbaOajFsdt+G9i2dp7ntvTDsPcUg6v+E/+ v5wel+MP3eqGNRH9j+3ORFGkJQsvs/Y= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so4128537276.1; Mon, 01 Apr 2024 11:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711995777; x=1712600577; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YqcL6luk6kscEpuGjrpNuwg4YQx24thmV194uTw7GBg=; b=g7jijbftlvX5yLlK3r2U32FmsNkFlh05p8ZLqiPHcZeap60uaAvlxdB1T3EJ3t6V+b GbrWxvTEa16LhJG09xsL+LZxnyUidfprQnjipFlwggZl9H7vh8HBJBtU2DYod+nPOn5x hOthKcvyeaFCdWv4G2nMIT/eIEniEMPnOEZsgCGpkHcuTtXclLdstAozK0vIErZGXxax IFLHHJD7epPJxEGPAYtAxiDYkLQ8a+zkzSGBQG2vt1BSPfC954Yub+Pdv1ShDt+2M/jV Yok0ZpgprgZytOxpdnim6+Rv47Qimltu6FqzVm5zIz8u48PTr3Epc3dT54xT6MWH1Twk Ipig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711995777; x=1712600577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YqcL6luk6kscEpuGjrpNuwg4YQx24thmV194uTw7GBg=; b=V8n2wEHOedxPUEMFTkAoQypGvKVy6ExSNpA0oIkb2waYBcc/upSOTA0+UdK8MyVBvX /CiqQa/obUU/GfOFOjGKEtBw2anlEh/smlSzisoeav7DqA1ej8lRtwvy/d1wlznZVj5A Ur8hv7AfuQiJuZy3PqdKJAkGEMxokVfqFJZQeywX/ZOrASYnlh8fWtmeSiNmcGcVbYEU c1dzOSVXF9iTnaDFBLSKipD5GVlUOV44bShMEleo0LMdtrno6tNBPa1ZngHUhJ8J8XnB 8/hkCzMHAlhGz+GyXyy3f81v5WlBvfBILCCWdLCQNfjQpfrnzqjPi2B798vytmtT0OV3 +p5A== X-Forwarded-Encrypted: i=1; AJvYcCW0f2dcU32HRwTlKaheroEtXnohmbMgDwW/wg1/0bKy0UvC6uwO6aRWY5751injGP66iU98mPd3/kd2roS/iPjEteCo9aGYswOHApMsVJerbgPEmOEpRaTiCwherrCqmlpINBLH3Pqs X-Gm-Message-State: AOJu0YwXb/XeDjl18J2ex1cLm1kyu1eP2nC8e7CMI4hnnU+Hxe0rAWhA 6cPB1hgUscexO/nJiO0PqDQiWOvJCOm7o/nHtLE/Z95JNE3sq21h X-Google-Smtp-Source: AGHT+IHxP2y4eXn/f8tnGNAOq5CveogplbH+cEh9XzTpR0SsDVV19XB03S8TcCwCWNKt7Q2mp533Jw== X-Received: by 2002:a25:bc48:0:b0:dc6:b812:8ab3 with SMTP id d8-20020a25bc48000000b00dc6b8128ab3mr8579699ybk.26.1711995776837; Mon, 01 Apr 2024 11:22:56 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::23]) by smtp.gmail.com with ESMTPSA id s123-20020a25c281000000b00dc6e1cc7f9bsm2138104ybf.53.2024.04.01.11.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 11:22:56 -0700 (PDT) Date: Mon, 1 Apr 2024 11:22:53 -0700 From: Vishal Moola To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, Zi Yan , Jiaqi Yan , Hugh Dickins Subject: Re: [PATCH v1 02/11] mm: migrate_device: use more folio in __migrate_device_pages() Message-ID: References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321032747.87694-3-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D6D4D4000E X-Stat-Signature: 8r5wft789xcewfhakyoso4nckf5zmst6 X-Rspam-User: X-HE-Tag: 1711995777-199314 X-HE-Meta: U2FsdGVkX1/yGfC9IzVCIXMZXL9QvPEY8NuLy0cdIEzhi09IvSwWqFGDN/5eBTmfDjNcaEeCdtI3XeAW8cnLwKWKBfYr/gb+rpb3DtgtT/7pghdz92jlG400XWTPVFBdZG1j2shUyPklJG+v0nVqv5PpAFAV8w8vY/KYkl2Eqyb7kFlVNQ8S9xq5D5QtI4CUAvtJkIYwR+h8NTiNXc1bXtGpoMHFHRu7ktdsELk2pFzPnp0W1yu2y8n9OAmrOk/ib0SSDawBJn+iBqBcPTQBt/o0QBWBrJwMkRIgjez2B+vHmLMysOsw4RydmcURWSYWbBfDIIY2x9ohyz2HJJHC28+nWVVm8R0KIzc2xp1KWUoA4bUx5utuZ06XpB3x1bpyt4DtIqtxUf1CHTYZHaVHck9T4v6qFrlEojGZsmj1ULR1Jy2H8OBVXpx4Klc4yTMSjJ1/pXtsW4MGB0Oas4gr1LI6v+32lluVvMSr8wJzdtxGAW6UmyqFnvkC0EZ9INJPtw+qttNos/5sMGK0I9SV1uWGM2+hdimICC2XzwefHTBFwRsfHOZnubBpy23ckxHZLYSPLcT9TIPDIwEfL1CB5dAeUUSxu3TpNVEfnFbjOtpcrB18bzPofISLiKKrHMKlHIp0Xh/ssbjW+i7eX3RqtHuUVZPQIjHqxvgDGG+aVrZxpi+IKNWyU6bnQndtXjMimMOWeYqFKuNNjXymg3/0PCDhU5HYMZ4iUuXFqGA9Rijuyoyjm+bYjr7+fN5W0rwzBSWDGIfYnZeSTLiEROnlULE9u52ntKA3xqKhstkovSip61gXcOT1QvCAUtSp0M/JngKUP8oQPRg6IBj9gZNtH/lo/zYJYv+yNeileVEv4F7DucjplgH/9nthykptOkbd6gRvKYHY+6thB3zEzrO0oRacZN5GHsOKTm2rNYMA1uaeEFg4Nr8avBUPsKVPV5CK8DxkCsHD3EJX89H5X5r R0uxQE2D RMbXbTHuMw2N4/8wJl8SobgkbIqigY2pm2/3NyzDuxoM7D50cNnX5Ttk4ef37EOjHXgFK4PQfsNFIgt/s4PpvDzA6Tv3XD0XTY26TQ8yjTJc0e87F1fcMT6YQr8wby17FbA47B1M6QWLcuqijs12FYza4/5EFx1y+upzd0PFOk+imcihT7VOt2MmBLzLEIe+dQGCAE+vLiIn2lx02NuH/j8cXkRLzEKZPYT173whd+GgUZ8GNWIZ/1fsfvgC3hLulLXqThHKIweyUekNaBBqJFeebIMZ8kSTTKvQVWdkVjc+qLR7wvIP8WdY+ngE/5jRCWr5xG4xLLCklZB8SnbpMpqoIGnlYspefB8YhjQ7NiUYM0mAKtEhAPipU1QjmyZJhTXQsK06mFgPWjfsAo6WcclSQDoJAbX6YmDHdK3WuUL2eneqySp0CDdXqX2Ial/BlNnSdnpeQOr6w+1F/CLMrmdGqCwcgqxOs/ZgWeAI0pkHJR8Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001364, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 11:27:38AM +0800, Kefeng Wang wrote: > > if (!newpage) { > @@ -728,14 +729,13 @@ static void __migrate_device_pages(unsigned long *src_pfns, > continue; > } > > - mapping = page_mapping(page); > + newfolio = page_folio(newpage); You could save another compound_head() call by passing the folio through to migrate_vma_insert_page() and make it migrate_vma_insert_folio(), since its already converted to use folios. > + folio = page_folio(page); > + mapping = folio_mapping(folio); >