From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0952DC04FF9 for ; Tue, 16 Apr 2024 06:13:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DCAE6B0085; Tue, 16 Apr 2024 02:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D0F6B0088; Tue, 16 Apr 2024 02:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6546F6B0089; Tue, 16 Apr 2024 02:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 357C76B0085 for ; Tue, 16 Apr 2024 02:13:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EAF3BA0887 for ; Tue, 16 Apr 2024 06:13:42 +0000 (UTC) X-FDA: 82014378684.17.BB5E68F Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 129FE40007 for ; Tue, 16 Apr 2024 06:13:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ko/FwRwf"; spf=pass (imf11.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713248021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CZ6ecSrVtYcanZSvOFQ1ox/50yBmtYgCGB61sRcLhXo=; b=o7Njfp/G2gyzirAV2DJLNbAPzSKJsqq3jnvxRZkdO0jW1chmdUqalOJolMdhOlvr7J+Oyx kSfLqvFNF3XRJ8EaZSVijmdDwInDCRltTE7fRIUj+Y7VYlg69RbG2Lxcss5QFUrACPTCJO ltG4Z2uUi4L4YYDfRP+8GkLSIcgITOA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ko/FwRwf"; spf=pass (imf11.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713248021; a=rsa-sha256; cv=none; b=Ee3stQyHb+DLJ0sEkf+vEDRZR/RR1eQDgE76YewcumkHgH3ILUy6FWWVi0GY683wQqYJDl wk2B1yk6s52kn1z1/jvRRp6MfbPcwZuJIIKHyQaqcF7kYdj4CUmNmtpm0DPU+E3Tnsv8/3 CwxGzf7EgRTdD9HOahP8gA3QcDi6PVU= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1e2178b2cf2so37179665ad.0 for ; Mon, 15 Apr 2024 23:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713248020; x=1713852820; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CZ6ecSrVtYcanZSvOFQ1ox/50yBmtYgCGB61sRcLhXo=; b=Ko/FwRwfBJH72wFxhegm03nfRk+1a6OpAB0pMEiGHhONo5jIG9bvofEI8Pe3/6kK/b Wh1OK9dhRRZWANc4sw+JwMSBl97oz+vV3bDpIi/bzwPY8u/Uqx8m1nW4i0N/thzKO7Te bUp8EcMDMzDBdcd5XLuWPA/k5QB4ORrwBKMPKAFlxmdkxu2FlC+49oraMEgZ0Z7j70KL ZWH9KMVY1sV+LH6N624CsuNWV3iKDs3BsK1Dm7CAXo97AkYOG2KFHbYk3SkW6nZyvcMz /P+Red30zrcqxhmoHmMNaZABaKH8/2+hFVJKnKRYoQDFgG9PGYOEyC8t51+0Ku3ZzgI6 1npw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713248020; x=1713852820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CZ6ecSrVtYcanZSvOFQ1ox/50yBmtYgCGB61sRcLhXo=; b=IigD85GxBpQrrqyebiDjnQjnxr2BSOlBHS9lIu3dAWwRADsV8Dmadp5Xcx6ytR8Izp FpLIWG01MEWIzw+dTwbmhFWvgapiU9IQGx7seSBz3dfsX0OLJiaU/dioQnWSIuxjkMqv /fO53a4cJvr5KLyTeEJvjBvvwivL66KiODzTOOYDQ6k1TPigAE+Pe5CsHAU7Q3rEu/ug jbSKQ7G/XOss7U1PulFKMvC1oJ+yue7o2qB1huvmbn+N4NQVgXz1C1sGtkkFmkIksuxH 1pJN4taBEP1tXEAB1W5215gVOY7Hf1PkCn3EycmiTzqW36yvNZJ4zm7+HmZ+l8O3bjm6 mpEw== X-Forwarded-Encrypted: i=1; AJvYcCV87XSkHwAiVxuw3ubgjEd27ZV0vTzFF2e5zzVUSXRcHW1KMQ/cZzR7rCe+E5ab9QAuIMVDiJSaEEjVpcvNQGhW6/k= X-Gm-Message-State: AOJu0YynR8eh9EuEuMG3BHUjtZAv0ZEDD3JSydpNe/ELWivai2DR0fyI XNBD3SeUFGrqB2T0txBHE6E+OGlEHVXGP72+XtqV3hxBl8aUKyLt X-Google-Smtp-Source: AGHT+IHo1g0xIh9Zq4tQT6ZgqBpNNX8qlCCYceyGks9TWejitkCg/+/KVWFWO9PgevyWpGP9p2ZULg== X-Received: by 2002:a17:903:24e:b0:1e2:7aba:6d0f with SMTP id j14-20020a170903024e00b001e27aba6d0fmr15871189plh.36.1713248019757; Mon, 15 Apr 2024 23:13:39 -0700 (PDT) Received: from archie.me ([103.124.138.155]) by smtp.gmail.com with ESMTPSA id n9-20020a170902d2c900b001e1071cf0bbsm8940249plc.302.2024.04.15.23.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 23:13:39 -0700 (PDT) Received: by archie.me (Postfix, from userid 1000) id A125A180F6DB9; Tue, 16 Apr 2024 13:13:36 +0700 (WIB) Date: Tue, 16 Apr 2024 13:13:35 +0700 From: Bagas Sanjaya To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck , Jonathan Corbet , Andrew Morton , linux-mm@kvack.org, linux-doc@vger.kernel.org Subject: Re: [PATCH net-next v2 14/15] mm: page_frag: update documentation for page_frag Message-ID: References: <20240415131941.51153-1-linyunsheng@huawei.com> <20240415131941.51153-15-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0I6/Ma35WnVqMhhN" Content-Disposition: inline In-Reply-To: <20240415131941.51153-15-linyunsheng@huawei.com> X-Rspamd-Queue-Id: 129FE40007 X-Rspam-User: X-Stat-Signature: 56kjg7hk7349crabqpoykrpxzfqeoetb X-Rspamd-Server: rspam01 X-HE-Tag: 1713248020-43 X-HE-Meta: U2FsdGVkX18YBPqcEqyuFhspW4aOTtdkRoPoAJCZeCuhzLe9gCflWa1ZZCU4JLRJnJB8kZfHK8mBxwhwf58u0J3VUYGRCCbN90PBEgODktPwDJZgk/QVxjwW6MO7RELCq4sDkijKr710fFFXE/hCAyA58L1YyTVRQmycyEbUA3BjJgJ/Xs+ncrBvhBiOlYUT6YWQYtWX7tjvSX+Pubfh7cp45/VIClpb4gShRJkK1PGtcVsjxhm40i1UfWN38gug7gLykuBE4LsZKBB2RgjYV0xx73LOtzmZT3XURVSAJigzoJ9+/t+E2B0obB6XBc4Oe72qpVPCFsoYKwBJKssE0AK9Rw0+m7LL+tDMrHFy+zqwQh6EdEqxcEcQsA576/n9FOm+BO53BuMhMpZOUBrtutj75T5/vCRoOPughhCd/g9BL+U1K2umNPg2u8/1K/d2ENG5+VgpGbm3Rd/QXQ80tcqACl0yNeD52mDpTvl0Pd6j67+usdaBBNvXQiGcX/nwmSppH9DX0E9vqdLWVmMBd43WbnmL6+Y3I4D0Fvwu6goQHS+WlHweZ9WPqs/AE0IrL6D+66+wbKeCZ3THDfYeZHzsDmytWdokseArqD3pa9qVW2OyzG9nsWxj/n4WnQKr2WlMLGfUaK0DfgJpGGO3KEOfa99IWqMVt3m0BN2sxADXpc7Ms45Ft159EzzLZ4csOkqhu/iKXqUQpu/qteLfix5mcMM5pNSjiOLXB6NbniM7pWiMuMXqG+2irffoWWOZTMv4UJWxmskI5aybe0V65Wiiz8HzM4pWk8ap/OYcVa3CUQqtkTXhPoLE9P0sXQwekuFgzMylh+kaq7ECniO/V8pPhHEnojzm78SfjArmk6HkILfDWdXL0dbKh6ZCsGM3u23rUinemjLbMwtnmw0wQON1P1fdfSJV9wfytH0G2Pykb6PT99mwOLf16LPSqdZIx7n6dyVqGkaF4BO57Ns yc4ZxgfG dxZIBt/yQOR8A/IobJ/bZXp1Tx+vEDHLNRHHhNjrz00QZ6YIJ+EfA+UuYFBTHMNwj+ypLuKyzwExbU6HeMXsnPvo+/M0wN1tTzPwMsRLiCjZFS8mkb9/h1GE4Zb8ypS3bUTY01BnGx+FG4+Cpip9rDsJ2JfGLgRuvp2L3FW/hjMTaDkkM1sQ1qe2n0kIQT5n9EVF/EMPh+16tmyMMv1DCoK/xFkLhHb3RYfIh6c2BjzUN8m+PmjwHJBtZOXZ+nzqPdGBvASL48BtOkm4KFhT3+Ji7DosjSWhzo6RJpcW8HMju+yaFqMajsi1eHDERjbZbkcTHc07qnyVcADj1GoB8ZrU1cJ20nsuJAMKvqP4UFFH2ieyb7lxK3olHr6RcX5c8qucpfgLLx4P208Jn5IyQ/ZG3/ll14jy4pSjYHOdQ4PFKsoUNe5noLyKKUaQVQC4GMWXppyyd+Bb4XOpWLBrq6meQK7ETrSCVtEBf+SKNkCwftA52sm87BwzW36K82hfUcYFRBkXuf0bwQi3aBqCvpqhrSz/UD2xIBjcGh8p38DJLt698wMxoeZjAFE6uChUrejDlLLiyZujUB3bYacT2VYn4YVYvw52Po8C0oh3dJm5VpnPVPv7E5+8G0SSnuX9eIztr X-Bogosity: Ham, tests=bogofilter, spamicity=0.099139, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0I6/Ma35WnVqMhhN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 15, 2024 at 09:19:39PM +0800, Yunsheng Lin wrote: > +API interface > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +As the design and implementation of page_frag API, the allocation side d= oes not "... implies, the allocation side .= =2E." > +allow concurrent calling, it is assumed that the caller must ensure ther= e is not "... . Instead, it is assumed that ...: > +concurrent alloc calling to the same page_frag_cache instance by using i= t's own "... by using i= ts own ..." > +lock or rely on some lockless guarantee like NAPI softirq. > + > +Depending on different use cases, callers expecting to deal with va, pag= e or > +both va and page for them may call page_frag_alloc_va*, page_frag_alloc_= pg*, > +or page_frag_alloc* API accordingly. > + > +There is also a use case that need minimum memory in order for forward > +progressing, but can do better if there is more memory available. Introd= uce Did you mean "... but more performant if more memory is available"? > +page_frag_alloc_prepare() and page_frag_alloc_commit() related API, the = caller s/Introduce/Using/ > +requests the minimum memory it need and the prepare API will return the = maximum > +size of the fragment returned, caller need to report back to the page_fr= ag core "The caller needs to either call the comm= it API ..." > +how much memory it actually use by calling commit API, or not calling th= e commit "... to report how much memory it actually uses ..." > +API if deciding to not use any memory. "... or not do so if deciding to not use any memory." Thanks. --=20 An old man doll... just what I always wanted! - Clara --0I6/Ma35WnVqMhhN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZh4XCwAKCRD2uYlJVVFO o85iAP0UEZ96bTaKdZC0FmSard5z0dMjRBPD69wzKG6rmE9CagD+LpsBRsgW1frt 81TmfyhS9gzn/HY0KhWP63uiPguKkQY= =zrUk -----END PGP SIGNATURE----- --0I6/Ma35WnVqMhhN--