From: Mike Rapoport <rppt@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/6] memblock tests: add the 129th memory block at all possible position
Date: Wed, 17 Apr 2024 08:51:14 +0300 [thread overview]
Message-ID: <Zh9jUo4cfbcmEMWS@kernel.org> (raw)
In-Reply-To: <20240416125531.v7we4lo222pgyr2b@master>
On Tue, Apr 16, 2024 at 12:55:31PM +0000, Wei Yang wrote:
> On Mon, Apr 15, 2024 at 06:19:42PM +0300, Mike Rapoport wrote:
> >On Sun, Apr 14, 2024 at 12:45:27AM +0000, Wei Yang wrote:
> >> After previous change, we may double the array based on the position of
> >> the new range.
> >>
> >> Let's make sure the 129th memory block would double the size correctly
> >> at all possible position.
> >
> >Rather than rewrite an existing test, just add a new one.
>
> Ok, will add a new one for this.
>
> >Besides, it would be more interesting to test additions to
> >memblock.reserved and a mix of memblock_add() and memblock_reserve() that
> >will require resizing the memblock arrays.
>
> I don't get this very clearly. Would you mind give more hint?
There is memblock_reserve_many_check() that verifies that memblock.reserved
is properly resized. I think it's better to add test that adds 129th block
at multiple locations to memblock.reserved.
> --
> Wei Yang
> Help you, Help me
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-04-17 5:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 0:45 [PATCH 1/6] mm/memblock: reduce the two round insertion of memblock_add_range() Wei Yang
2024-04-14 0:45 ` [PATCH 2/6] memblock tests: add the 129th memory block at all possible position Wei Yang
2024-04-15 15:19 ` Mike Rapoport
2024-04-16 12:55 ` Wei Yang
2024-04-17 5:51 ` Mike Rapoport [this message]
2024-04-18 9:02 ` Wei Yang
2024-04-19 3:15 ` Wei Yang
2024-04-24 13:13 ` Mike Rapoport
2024-04-14 0:45 ` [PATCH 3/6] mm/memblock: fix comment for memblock_isolate_range() Wei Yang
2024-04-14 0:45 ` [PATCH 4/6] mm/memblock: remove consecutive regions at once Wei Yang
2024-04-14 0:45 ` [PATCH 5/6] memblock tests: add memblock_overlaps_region_checks Wei Yang
2024-04-14 0:45 ` [PATCH 6/6] mm/memblock: return true directly on finding overlap region Wei Yang
2024-04-15 15:17 ` [PATCH 1/6] mm/memblock: reduce the two round insertion of memblock_add_range() Mike Rapoport
2024-04-22 2:55 ` Wei Yang
2024-04-24 13:15 ` Mike Rapoport
2024-04-25 1:38 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh9jUo4cfbcmEMWS@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).