From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9340C4345F for ; Wed, 17 Apr 2024 05:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8AB6B0083; Wed, 17 Apr 2024 01:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E79F66B0085; Wed, 17 Apr 2024 01:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40226B0087; Wed, 17 Apr 2024 01:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6E376B0083 for ; Wed, 17 Apr 2024 01:52:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2C859A0664 for ; Wed, 17 Apr 2024 05:52:25 +0000 (UTC) X-FDA: 82017953850.22.A820DD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 8F58016000D for ; Wed, 17 Apr 2024 05:52:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AdyB22eW; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713333143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZVabqpTlLz2+ic8H0uucIksYmj+AHepsRM/HQ4UviIU=; b=tfUhy/xr6N8H2alvzSNrURdX8NQ9Zifn5y//8Sqnt7+lPlCIjwNNuZxWZdrTE/GcO4MRjW UchKhP7cxOX0jxgXBtpu7B+SMdvQ/+kqu5VMIUz7une1jVLoiS/kGsOv/kQCtA3QD5dCSX lJ3BL3sWHcoz7Dog9K/8LpVc6Mm7Mzg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AdyB22eW; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713333143; a=rsa-sha256; cv=none; b=4pLuRWB6KvCbxOctx4sMfnVf2P6z4IwjXy/CBj6UqgfyvD23CQe7Y3ZqPQt3aCkZei6Ug0 XC6aVEEwlSGxvRE2FxX2vyTql8jWC+dILUbs+5zogt8cPrQiELuhiYqdgkTzt+btxGtcoh 1oHNXYXB7Mo9SK+mXWFi9DMzxYlkIKk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 90BAA61280; Wed, 17 Apr 2024 05:52:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB06CC072AA; Wed, 17 Apr 2024 05:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713333142; bh=7+LLyXhHWaq19ZYBLaUCJekOTBVF5OidAFwzO62H8Qc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AdyB22eWbqcLc5HGEtfOSh/sNbnApPwCX8P1UY34vgByE2qoIlfItGFYmZkKqvaxX xD7UmM/gsOqCx/Y4pguym3lzUYKFBAdtNLZOK41jjXlHJzVTgty2Uc/pf0GqsVwmFS GwJg5B/OE9zb8+EO8QFygf7NEouNVw6In8ftVpbQH7u07KyAONlUpFM5lqgYKNB364 uxfVUA0/f6GxYxMQBK9aZSbKP50+48ZiUEqRa4kW0BJLnjBcbOkC5kJvTwUEzRD97V G8IadoiUW8tWcsCW8eUNPnawIFb/xtmZgEAJ7zkMvs8uLnh3pxLa8n1ZuS29+qSdDe GrQHJEFgx4JdA== Date: Wed, 17 Apr 2024 08:51:14 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 2/6] memblock tests: add the 129th memory block at all possible position Message-ID: References: <20240414004531.6601-1-richard.weiyang@gmail.com> <20240414004531.6601-2-richard.weiyang@gmail.com> <20240416125531.v7we4lo222pgyr2b@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416125531.v7we4lo222pgyr2b@master> X-Rspamd-Queue-Id: 8F58016000D X-Stat-Signature: dfobra4cy46ft99bthodp58c7urw8jxk X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713333143-573050 X-HE-Meta: U2FsdGVkX1+rR940Y0pqTryst3vU2Ql2UEMR/uZhj9ffJFtw4PB5A1CNaIFEV6qreXKgw1wuvyiz8lKRbANNY/1QZ5ygtkdVb7lpXcqPDMah1NpKVbJI8CHLLn0L6ZRqqZBPmnGEim4q6QCynj2t44Nd8H4X+KNWcu5tPK2H1KRwl0/FDfZjjUYF9hjSz5o22r+NsyEmzBlmOMbki6lp/ZHtM6ZprpJ44wiE26jsGUXW8CO+LdGPT+nSbg/YMdGYBsRvCgU1140HuSsPep6kcI/ZcY7Zy7+PkGNfmJ/3neu0EqSQgHHrVjXNQh7W4YJG78RfKsIBMqLHD3fLNJmSXItR8iZInRZeb1SMOiowBVfyRE1kEpXrQZfbcQMfLGWLlfo6oL0IJK4rPvBOIw1qp3kf/gbYgS8oopee+ELwNIWqBMMcHlS121Yul1zWDGD8r8l0Xl7ennUZPyhEFTpvmCuZDhjjuVQzIkHBxaWXSr750k9fv9fb1/eKqq/oYrLewtQ2+Dnll22U8mp/wRmP7xftdIhFP8vgYOGJIlTSLYWXvb7JzLHRCOkXADm1AHu8vRP1VHBt+D2clQyHU+kVnPSAJ4IlExhpnDRmNpHR0zE/YeIJA7skv2RgPt2SK7yjT6UgfKDitQReFqZxTKgTco8ruiTbf67uSwGo9d47wchvJFKgszlGPgqnzo2TEwZwUzJxnAVjQWQlJq2GPnYx3I4+kHqJKZzBOiNSvdP50Rqqs1/D8W5fz369IA8XvFR9SC5eClTz7wK/QG2SavfTt0X27IT/QyD0arBgQMSnIDvtpUJ+WEW2haj55CDETUMEh/8UIDWq7TqwvyF/G11C52cN5nw/ibBGURzVlM5OdQKFlhS6636cebzkJU+s7ViSA/LW8+jPYS+HZscXk6AevPdsliXOpsty7lt3bke9J/TzqrQzfNelb3zEibLwFQ0TvTMb66x+vfvakp4/GKh BbP1orWj 1XP63m2Yww+bfo2Yg6f/jC6aG85hve4lPYfpajELm962UplOO8e6CtoSvMZDBCDEU3keeFV4BGIwSnUpmM9xHlLOM8Cmamd4hqKM99N2LLaISzI+/rNzFFsNFxwW9odMYxIzkLAuphjxUmVCXaFwxvlJk+iflo7J4cP166uwLdxKroYPDz60dLs4uTKem/rvzUxjt2rSQl97aF0KxcLE5k9PIKBZ9E1eZNKEM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 12:55:31PM +0000, Wei Yang wrote: > On Mon, Apr 15, 2024 at 06:19:42PM +0300, Mike Rapoport wrote: > >On Sun, Apr 14, 2024 at 12:45:27AM +0000, Wei Yang wrote: > >> After previous change, we may double the array based on the position of > >> the new range. > >> > >> Let's make sure the 129th memory block would double the size correctly > >> at all possible position. > > > >Rather than rewrite an existing test, just add a new one. > > Ok, will add a new one for this. > > >Besides, it would be more interesting to test additions to > >memblock.reserved and a mix of memblock_add() and memblock_reserve() that > >will require resizing the memblock arrays. > > I don't get this very clearly. Would you mind give more hint? There is memblock_reserve_many_check() that verifies that memblock.reserved is properly resized. I think it's better to add test that adds 129th block at multiple locations to memblock.reserved. > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.