From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D62C4345F for ; Wed, 17 Apr 2024 06:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A276B0085; Wed, 17 Apr 2024 02:03:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FA826B0088; Wed, 17 Apr 2024 02:03:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C1D46B0089; Wed, 17 Apr 2024 02:03:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0EB116B0085 for ; Wed, 17 Apr 2024 02:03:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8910514072B for ; Wed, 17 Apr 2024 06:03:48 +0000 (UTC) X-FDA: 82017982536.07.186EBB3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id E7563A0003 for ; Wed, 17 Apr 2024 06:03:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r1Y1CQib; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713333827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tNvRQM1D/O6G4IG5CgPTTQ9b7N+I3rUWEmG85qbitPw=; b=hdUw6BDWmd/wCklL206xXNE3IenB+yyoRjtYPvNZPK9eHi0iYIaGJG13xdHz1K3/CG/k2R YRg1M89dswJMJCfL7jNEvAQQOu023GwbLRjyj9pb+VHdMx4GURtjxofCBXfYLf+Tql/VKw hGBmI66xcLrJNXOK2cm5w425zOKFksM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r1Y1CQib; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713333827; a=rsa-sha256; cv=none; b=wNopOyqVPd6giY/eYhc+wznDUngjrfCXFJSWQOQOwSdADjMrmTZ9pKRT00Dy9L73IjpsKA gSeENCqcfYVrmynqTKmkqNF9cicWgDwG8aarbJY9vPjuGvnQ1EXNhuu9Z+LRkfRLr6IyN9 ZoPUDbf3Z7x1IBmRWvgARpGZy5611pM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDC5C61440; Wed, 17 Apr 2024 06:03:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC58CC072AA; Wed, 17 Apr 2024 06:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713333825; bh=+Eq3FWKGrjqS7seNZKXEpLlxTviRiT6+OZ9xQJRqG4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r1Y1CQibHTdcudeq5dwRUa2vqa/wiYnKE6l4s7SxAT9G3vk5VhpLBiKTYvFBMhJeP K8tGsbHguWZi1NE4p0IymTKorSlCRAz86GUra+tCkGeVW/LfGIzdzDm3tpePhvBjZn 4x67S+iZcpUHPVcAH03gFvPsIYznEGerpBYt+SQl4Oo/SvQCPzh8H1rwqaQgWKy+rm w5hfRMrDxD5sRn9UZW0xOhUJkkvub4lJYOd3DU4Acj4WDSaenNL2RKiWDBE9wJ5n/3 8ekXq+wxbUqdoKd7QVf8HsvFbahBuA0TUGx4KvLfXVnnMizJ75ZnDllOJpQz5O8K2A qC/e9wFfzWBQA== Date: Wed, 17 Apr 2024 09:02:36 +0300 From: Mike Rapoport To: skseofh@gmail.com Cc: robh@kernel.org, saravanak@google.com, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH v2] memblock: add no-map alloc functions Message-ID: References: <20240416120635.361838-1-skseofh@gmail.com> <20240416120635.361838-2-skseofh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416120635.361838-2-skseofh@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E7563A0003 X-Rspam-User: X-Stat-Signature: xgcanergutz85f8h3ffe9k65n7f44shx X-HE-Tag: 1713333826-35387 X-HE-Meta: U2FsdGVkX18WYrPNTmt5NUVslXKFuHEuhLEGmwARSFigpA+1jN/mYrDLuV/tOtdRA6U/+4PhpwYAJDA5/EYUKvPnHxyv+E9FxIZimiek/Ajos29mZQzNpwhztjMnVtjCHBiieJA9jv6GC8Q5Fu5UslVYsupgf99KCtLcpKk29+nFFlUYWQtwSsWIb1pmxrgMvgvYCuET75b7PoXW0QGncSIvxJaabGIBNiiZuwG1xET63hIXlqoafRI1kbQu1hIAToNLwA/J5N3e3xolj4lCTged4yJOlXuK/K2jG43TPXIVvcgsCTtgBT3qac0YmQq6tnEJDhV1HNe4daPzZgT2pePDxfMKPa71vZ1rqgpuAM1hm8qB0rgeT4ycAAPD//Uv1jyuLaJMuKqIbzYXYyHW23VqJ4qQRQkrkeEbaI2G/VgBo8xzxlDipRtLdNr4dN8yNUxhtW25SJkym5YbAJWDen/m6e82XkqXzZP0D0G2EyyakMr406dltbOUxGeo8jvWiDTEKMhhbUSQD1l/QO5NVhxg3zAZtydeM2Y8jJmf+B9G94sWPra4qFTNr+aFbnoUhsb2RpR4llDLC4g4Nr5AA5GCocgKhh6xs9jApZh/H0Puy5L4tuSkE3WH4mgaPMMUGTs28FhebhmbXZKDWu4LtaH6iQEVwB6peUuwDgA433N4xUp6PGMJ0Ua/BaPAvglWUdJUHuBbr4VAs/BqptzTCwp04Q3UZnox1taRs8yTLRcdd5JRApTD5F3fHtdtK41WaKJvLnIhImsgqvg1GPWeTmQDq+pWUv4I6pUXBrsPSyBExp/kagxJw1wZyutv7uw5W5mX0+zgEoAdG1NXcFT+8/FOsxP4K5xQv1Hwun8e3lM87G38DBXgbZz7xJx8C8Pwd8jp9siCN+FEDQqwRFDTgj8rvZ+31OWR9WxhXDwep1m8Gjd2XlOZpPbPIPQ1Ks3mx1cHS11TPC75W1+o4cy w4wpKVx9 O9kAObvvbiEA9bRfnOTqvcVoi8JeskYcGo/D+/H6ZZnn6kDyVAm3stvpq7TcB+X1LqW+7UIeHqScwAvDhlmpM9wZ12AV23R1VK2HxzDByVb5lTSzDr9tJwzXnhta3EDls5zhjenx80UimHCR+5iW4OPRfKdITW/OUs0ezGQnmM2cYuyH9p9s/DyUgTcewIGH366kG9FKCQpdD8GiYU+RTs4bLk8HSATDqtdUheraAHhYWOmQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 09:06:35PM +0900, skseofh@gmail.com wrote: > From: Daero Lee > > Like reserved-memory with the 'no-map' property and only 'size' property > (w/o 'reg' property), there are memory regions need to be allocated in > memblock.memory marked with the MEMBLOCK_NOMAP flag, but should not be > allocated in memblock.reserved. This still does not explain why you need such regions. As Wei Yang explained, memblock does not allocate memory from memblock.reserved. The memblock.reserved array represents memory that is in use by firmware or by early kernel allocations and cannot be freed to page allocator. If you have a region that's _NOMAP in memblock.memory and is absent in memblock.reserved it will not be mapped by the kernel page tables, but it will be considered as free memory by the core mm. Is this really what you want? > example : arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > ranges; > > bman_fbpr: bman-fbpr { > compatible = "shared-dma-pool"; > size = <0 0x1000000>; > alignment = <0 0x1000000>; > no-map; > }; > > qman_fqd: qman-fqd { > compatible = "shared-dma-pool"; > size = <0 0x400000>; > alignment = <0 0x400000>; > no-map; > }; > > qman_pfdr: qman-pfdr { > compatible = "shared-dma-pool"; > size = <0 0x2000000>; > alignment = <0 0x2000000>; > no-map; > }; > }; > -- Sincerely yours, Mike.