From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC41C67861 for ; Mon, 8 Apr 2024 22:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28B4E6B0083; Mon, 8 Apr 2024 18:52:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23B886B0087; Mon, 8 Apr 2024 18:52:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12AAE6B0088; Mon, 8 Apr 2024 18:52:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EAF976B0083 for ; Mon, 8 Apr 2024 18:52:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AD1B4401F0 for ; Mon, 8 Apr 2024 22:52:16 +0000 (UTC) X-FDA: 81987864672.09.77EEA35 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 86D08C000B for ; Mon, 8 Apr 2024 22:52:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MVB9jxR5; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712616735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pGI7WcWWeRuDVYJ9D9IxX/Ekzcw/lAoFAz1bjf6CkKM=; b=KE36V3U6w279JMnN1pQyDT67ZrT9wG08TYNgWGsQymFJsCY91GVCU09wnJxlWgN3L9Sg0O yhFOr75o6VgafaL0ofSy97+WWaf4k/0OF0PiL4ECQ0NlnhFuXw5up0M+NZ4YAQbnvGOm6M JZ4MYGaOJh0+Eo4HDze4JTf/LHDNYXo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712616735; a=rsa-sha256; cv=none; b=X14ErHduxl4jiJyAVNx4GJH2snC17l+v3fGWG3YtXb1HBfjOg4KvoWdJOaRtIj1Zrtw8Ti qNYjcWGJ+JTc8WAKirbsr8DoGAN0HdiTc2PiFDOguP2Z6fYLgCo30LsKr+oBGvjSBCD7yL E0yr46o70z90IdjbRgP87Ep65k1dZ58= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MVB9jxR5; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pGI7WcWWeRuDVYJ9D9IxX/Ekzcw/lAoFAz1bjf6CkKM=; b=MVB9jxR52GGjlrH863S8h2naLp VSwP44d928JSpDnTxVKmhXeATZ5Ews0Vev1C9bxaKJ+kYiA3FV1AL/2uzGukj0G7BcdCo0pVnPQF9 4WP7YpfNsFZ2+q1jHcblsoPoSgSqlg36dyMmkGX7YMjPsq1LZ1qF/Z2YSkdr3OOn2g5rbrO5sALyq iiLEu0fr5NgHjpOWVYDoLbSQ83LVN+i/fJVqrgdkdIAt+qfOuxkWhelKgKKe6i7/LgC3yr7uCAdPC M7LJJucDp1BRMHI2ZlGWVCBirlAbUnMd3I5nhvFuL+DXbj1Pa51CFJmch8X8y5JSxo9K8iO2M4b5x 7x0618LQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtxqU-00000000nVV-0jeq; Mon, 08 Apr 2024 22:52:10 +0000 Date: Mon, 8 Apr 2024 23:52:10 +0100 From: Matthew Wilcox To: Jane Chu Cc: Miaohe Lin , linux-mm@kvack.org Subject: Re: [PATCH v2 04/11] mm: Make page_mapped_in_vma conditional on CONFIG_MEMORY_FAILURE Message-ID: References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-5-willy@infradead.org> <88b8988b-5f52-4a2c-b4e5-71d828eb6acc@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88b8988b-5f52-4a2c-b4e5-71d828eb6acc@oracle.com> X-Stat-Signature: 9dy4drd8go3g5rnqrnyt64wbzt8ikz8b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 86D08C000B X-Rspam-User: X-HE-Tag: 1712616733-588422 X-HE-Meta: U2FsdGVkX19k7RGke+53aYJ6IAkuUm3HNmODDtjugMoG+Kw6mvE6ksDPEl4xqmFKHGckQ0prS/kG/hEbGMVuT0mH+RKJRKxRWL+bglEUbo2Z6e8+AzFVfo5mcyVTNqOpmGklheTW+xJANguNDvBeyZ1aipscKyr5udie/RtcdLe6aFwOhkRmkIUzrD6ntd9tnLNyACK8E+/JgZt+Wad9ycbjRKGVxlouppbvyi5ygRz0+68xIcIprwV3xtXdTP1asZYJzKtjZ4ivCr3/qF48KL0KsAEJQxwiHCtBB3gAy5BV8Rt5FHxSC4gcBxwy8vSA/AUANvp5/TJdfNSH3+Ek7Df4eBxpZESBmMGe7PGnrnw1YOReccvDUlMJ6sk+XDhSoJxfPDre0GQPgjOL6gNQ47UhVPCQcHRvWWV4sFboKmvLEGa3e/H6+Bh4gFgkDLeBTDk6k5DStq2bVH9Lg15kKMCn16zj+4178GaKj1U9tQzFUBhToBcyM7Jn0z77e0sTDqKPSp7eE0+p7eA5pVglACeDS0U9xBs9AQGA71lH51EdgGwmMg9BX+/TneFKuTCLrFBDKDrbPokR8p64y0/rs1S8mbPmNjOLKyViYMxMp4RMfciE1AWjsKDB685FrQDdsrABBDNuafpztIRl7ML4z1mRNoA5/n0pltzLV/pC9BQWxvI8cvOpaU7+m1Q4/ju9XdYEIyX2rXOL5ZtYefuGAn/oDmym2lNafQt62lt35xWZNtr6YDg7Z1udogFUEPac6IIxa7eJ53lgyPBeGLD6G7DVMHpvRMfleeU1/70pIVepIDkKTcZfs2id9cC2uHe+WRpQcSSNLVYJZfTNSjdF/fFtXw1eSGYgxSKxQQTTaMcsFOAgK71ySPMEDw73t5gbe1VJHC2Td7iwI8Pt7f9VgnFAIGpDALOwkEhLg3OWP9XfkQ15LkBg+Z1AGUshbNpc/psrcM2ZV3H33Qsk7lG 8u/dj6uk 6LqIJgul03khhbU5QpfwKTvdKp0SpBLmMzUtNzIjSx61EHn0mlGJTqxed4cDSnBICZJrgsWeHeuOBtfWzYfleEg41QB+WSNxY+0EM4HbkjAr9vQ0UqsERP0mvyMVhY7o4wzWKNO0IPxxcSK9zz5K3r0iujgKCD7MHSMSTZwBKS1ATeiLp1AbOdznuvUoAWreJx0N/ZUJ0kVsdBa8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 03:45:37PM -0700, Jane Chu wrote: > On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote: > > +#ifdef CONFIG_MEMORY_FAILURE > > /** > > * page_mapped_in_vma - check whether a page is really mapped in a VMA > > * @page: the page to test > > @@ -344,3 +345,4 @@ int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma) > > out: > > return pvmw.address; > > } > > +#endif > > Should below be put in the CONFIG_MEMORY_FAILURE bracket as well ? > > include/linux/rmap.h: int page_mapped_in_vma(struct page *page, struct > vm_area_struct *vma); I don't see why we should; I see no advantage to adding that ifdef. What would motivate you to add it? > with that, > > Reviewed-by: Jane Chu Thanks!