From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F93C67861 for ; Tue, 9 Apr 2024 12:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 524F16B007B; Tue, 9 Apr 2024 08:11:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D4846B0082; Tue, 9 Apr 2024 08:11:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3376B0083; Tue, 9 Apr 2024 08:11:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1FF0F6B007B for ; Tue, 9 Apr 2024 08:11:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 873DAC0375 for ; Tue, 9 Apr 2024 12:11:27 +0000 (UTC) X-FDA: 81989878614.14.FBCA474 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 55EC110001B for ; Tue, 9 Apr 2024 12:11:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m3SH9WMG; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712664686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUod3MVL5jER/bWKwv/+ZmwPWDNQiTa3nIeT3UjYsD8=; b=4nqzEu4vFsPCm+kp24jUOsg6KRsFRn+ojYXNLVcLGhNNDb+9qyY3vhGB5OP6fRZ7tlWNG9 JwtRKwIhfq1H5hMvP8S3/ay8vgwi978q87Gzyfbt8hwuGy7pgI28CuOv9auKK5P1dUGTmY XQ0O3qP+jtnuHCmP9zKBiAnz6nBFRg4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m3SH9WMG; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712664686; a=rsa-sha256; cv=none; b=385DH28HtuKJ4WByBYrtUCZ312nJGArxfH6c8+PvEWhp/0hwwGf3xtpk/1wYJot11an1MX QvuZUGnlr5NCfxSGltvub7gMx2t+Jh+QPQofS3HBc9O0KCKVjys5S0j6GNnFFIDN67fGIL VOSYn/0gKbcvxVvnUptLvTaWwhA3r0g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=XUod3MVL5jER/bWKwv/+ZmwPWDNQiTa3nIeT3UjYsD8=; b=m3SH9WMGSSRDc1xxtTF7fUjqK+ VIuj62oh8rEFO8iKOs+F4dfJle/tlITdwv29p7AaG9zz8zUBYfogUooo1crK9tbZygPH/+tyExiQe a9dRUuDvpfG2UirPLp4vcRwDruz9/rbXAfL0USnGZ+ITwMhrOgKvqcamr57azpu+L650ae0pC3ZEb mlgncdwFXAILhPohsgr4va4FxOuWfT8JGDFrRw8iB1f8r3XdoX6A9IbzDUYuTSjt8A6DxQedzjkfQ +oJEYxp3lSe950Ib5Ol3KkKHKxO5eSmSJrZSbuTvDU7mkMv309DYZbaZeK+SjCwmYpQftP615EIpy +W+m6ALg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruAJt-000000024w2-1LbJ; Tue, 09 Apr 2024 12:11:21 +0000 Date: Tue, 9 Apr 2024 13:11:21 +0100 From: Matthew Wilcox To: Jane Chu Cc: Miaohe Lin , linux-mm@kvack.org Subject: Re: [PATCH v2 11/11] mm/memory-failure: Pass the folio to collect_procs_ksm() Message-ID: References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-12-willy@infradead.org> <721459db-1a7d-4b39-aa42-723624e718a8@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <721459db-1a7d-4b39-aa42-723624e718a8@oracle.com> X-Rspam-User: X-Stat-Signature: 749pnzygbr1a4qxfmsbei36x4szucdwr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 55EC110001B X-HE-Tag: 1712664685-780199 X-HE-Meta: U2FsdGVkX18NFvsKSV00RgHiub/v8ED17Tks3qujv5STBifEn5v04+OtdRn+LAZ5wZWrgnDQvidqqu52tm4hxIBAoqefV9yPqKPs2WilVr06M2gvy9YnWxUTW/cXA0r0b3Ot4n5mFnHXWR3k1lPD+2DtSLEBR4IWBB7XfGYyuILyn/kEFHGgZ955tx4I4kEzHtKT9MwXbqChW7mOpqUBziix3I8Ndrq+8r3Klzyag7C8Lq/IBrRXkuqQuGeLUUtDHb7oAKV7k7AEEwvNN/QkR1vfHVlnxovq+ruIO4VHqI2/+Sj8MszvEf1EnjA328s7D0RFMBn06Dxs1cBPCD/rFxs9+cl7Nwkf/riY6wtW4kdeFoc3SJKnry+UEbITnkAqkkHHcmQXIC7YZ/ORc3EzptmLTSiETxvCdbnq3P2j9M28eeCHy7MLWGUgAWn2WAOVEyGBpnu0D2a+23uiKZObXKa12IKbpTByffcAEkNDZkUjxO5krPHPm77Kh0X8WqvN2gQJETpSXR5cX/lqT/JPY2VkqIHljTgt4gPj99/3GtTkSaRn+hA5V6ix1JNBYg32jZbC3OenXo4Cwn9XUEoF+457Q2nLWxoUw6eF9NNvBSUlqUv/w04bus4C54qSNxH2zdGYvnLoyo2RUa5BtE1xxG03qcx4D0JvCV1Qi3enoKGhbWsymyX2rlsttLKQocQ/PD2NtiikCnWM0tBNIifreB7Ix6gdmU8or5Ns2Q8lrXPEaga6mbR/TGHSBu4RkXMHzdsioICa7eUpIEGvDA3zevVdmUHtbTeKGSF/Cl5q5Ig0JQchTqm3uzrIf132qpV6sQnZ9tNdi9ETkefuKQD8jD2IwzImITOyNJyVu8gkEs059CKN0LngfTsLI1BHwdBl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 11:27:02PM -0700, Jane Chu wrote: > On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote: > > +++ b/include/linux/ksm.h > > @@ -81,15 +81,9 @@ struct folio *ksm_might_need_to_copy(struct folio *folio, > > void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc); > > void folio_migrate_ksm(struct folio *newfolio, struct folio *folio); > > - > > -#ifdef CONFIG_MEMORY_FAILURE > > -void collect_procs_ksm(struct page *page, struct list_head *to_kill, > > - int force_early); > > -#endif > > - > > -#ifdef CONFIG_PROC_FS > > +void collect_procs_ksm(struct folio *folio, struct page *page, > > + struct list_head *to_kill, int force_early); > > long ksm_process_profit(struct mm_struct *); > > -#endif /* CONFIG_PROC_FS */ > Why is the #ifdef-#endif CONFIG_PROC_FS removed?  In ksm.c, > ksm_process_profit() is defined within the config switch. Yes, but there's no need to put ifdefs around function declarations. All it does is add a rather bogus dependency on the CONFIG symbol. There's no harm in having a declaration for a function which doesn't exist.