From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0426DC4345F for ; Wed, 17 Apr 2024 16:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E0A6B00A4; Wed, 17 Apr 2024 12:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B69F6B00A5; Wed, 17 Apr 2024 12:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358256B00A6; Wed, 17 Apr 2024 12:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 135F66B00A4 for ; Wed, 17 Apr 2024 12:14:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B589FA07F4 for ; Wed, 17 Apr 2024 16:14:22 +0000 (UTC) X-FDA: 82019521164.14.048D370 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 9B7AAA0002 for ; Wed, 17 Apr 2024 16:14:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cygt0x9f; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713370460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zLXbEHaPuRTXl8YXU9P1QgIbiqadkPO+DuLjekRXSPI=; b=q5yXoBA35yg0eP+ZBYiFiCjSYRxciKp34FLBrkbNY4OJbNjhPLyYCzHYsapeF3OqGT0sKe bPutZgGjmyMGCzzCSh0MKgFK6s2oFeLnf4Gd/9IuX/A/aFv4PYDiqMDfS7sXn9WkZOLxeK OASrYtVcsWU+rSnHGEGpzgv2C9Db85g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713370460; a=rsa-sha256; cv=none; b=07gyWdyJok4TgsiO6rfnIG/P7mp6t2nI4KUO1E0OHbwkUnkUE5+caYLYJUPEMvAfjJ8raF xqnId8v0JRUcD1jFlDp7uKXN6S8QEGgmYInskhgS67fQpg639od2ZHkUMyxu5IuYVyUTxR kwrLBKPdo96g8nUbspkvlsPfSn3jw10= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cygt0x9f; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zLXbEHaPuRTXl8YXU9P1QgIbiqadkPO+DuLjekRXSPI=; b=cygt0x9fgIzCrMhVZMNKpXHHel 7pCa+WLpZxMgmqPhQg58IxvWWGRDRTOaMbRJpHd5nCts5Zon3Vi2rLCq9xXzNDvZpOidlCo9EPac0 N1k0Ipi3ls5TIEDhd/T4x8RCzsf/sazVkPSnQaHH3PbWJeYoVfTlYf719WSG4RUHNFcshWiMb2aSB L1ucvLHQb9CGuhREtnCKebK0TcM2HLw8lPf6Te1ktugbGikmTvcK6QxMaR+BXoAZXMR4xdk+/i/Ag W2l5A6dwEB1G6Z2o5Sqyw0DKXEX8U0zycA4o1b4vlObdJ1A05G4486c1BHjKdc5Loji6qh03j+p5/ SeJLDaCA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7vB-00000003GV2-1ZBN; Wed, 17 Apr 2024 16:14:05 +0000 Date: Wed, 17 Apr 2024 17:14:05 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: Re: [PATCH 2/8] nilfs2: drop usage of page_index Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417160842.76665-3-ryncsn@gmail.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9B7AAA0002 X-Stat-Signature: y344z6u5jxbcynazo8ob5sh918d11uo3 X-Rspam-User: X-HE-Tag: 1713370460-921212 X-HE-Meta: U2FsdGVkX19KIT6VI1gTBVV1orVfDq53eJ1EJIKigMZtsSvaM9D7x3cmcWqemsRfvKu9qCnUtKPz+smtxbYgXr4ZISnCp18Sa0xtdbyQAaQQykNhD35jGnMq+BFUGYtnbO/FbTbV6DrpXWQQxg4paiNp1lcEggMDENrMpi6SkStQ6OEv+mGIAPQB1S6OJLtUe1hjsO7m0lvhaNr+qpy2VyQGT0PQQBRzer265aCyOp4GSqoTcw55m6ogvrGMKvYaZ3llhyZTjVufeoqE/Ixgq+L0sZNYInS5sFtDimL29z4cCJvXO6pdQqJFrLPrt5roGYcgnMJ4ldSKxm8VrQVCwVZMz99SMw/xiSia03UH/nU1vCGy8JbSFEqQXMGLdekrBpSknKf8ZBe0Y+8CbBKeTPngVmuUIvLHA3wr93E6eqRmzMQ95vAdGzS6iCx/XZWKYuqzj2GnKIY4pdBgp57GqKXe/Zx8vyjIynv1sZoiWxCbgBb9ygj9+6dbBbyCGx7iNx4c3jL0AoJw6adsdZXlGkg1A4rp3woL7RWD2HAYKWWXoTMZNecB/7jHFOb6Sp13ibxrJ1zdMyr6Cmxcg9yLMkc8g/s0STQe+7DZ9vTUMv6AqfUpW8vIoQgmikQqV+EtDaw2z+8OFxZH4CIKntKC9fvmEvrIIHbXDAGlYXYhr7tkcVt1xTtLB3DtwuySIvnrO4KZCZSJINEdREprTQY5jPdl59DnvUraiOuaL6u7dQh6QtmkRjvGbTdF3YpwmsGZ9gXe9UprM0nmgVt/8CvmjGvRYc/YEZyRe+1WCZ9gMiWDrxa68eo/bdit5GfHWESyCm45UaD3uPBhT+D0r46xTrnMBSqiPL54EYB3eqGiMWylSv6H8m41Oxc+A5xD1WlArt9U3rNjprJfo2RnHVa3H7jej4+Cz8ijGppXOepRKsLwahHyhImkdhXxmEo0FtbtDWFYMwG03Ac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 12:08:36AM +0800, Kairui Song wrote: > +++ b/fs/nilfs2/bmap.c > @@ -453,8 +453,7 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap, > struct buffer_head *pbh; > __u64 key; > > - key = page_index(bh->b_page) << (PAGE_SHIFT - > - bmap->b_inode->i_blkbits); > + key = bh->b_page->index << (PAGE_SHIFT - bmap->b_inode->i_blkbits); I'd prefer this were key = bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkbits); (pages only have a ->index field for historical reasons; I'm trying to get rid of it)