From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D32C4345F for ; Wed, 17 Apr 2024 16:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8C086B00A3; Wed, 17 Apr 2024 12:25:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3D416B00A5; Wed, 17 Apr 2024 12:25:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904F26B00A6; Wed, 17 Apr 2024 12:25:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73A266B00A3 for ; Wed, 17 Apr 2024 12:25:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0D0F11C0E37 for ; Wed, 17 Apr 2024 16:25:41 +0000 (UTC) X-FDA: 82019549682.29.42F5C0B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 70BC514000E for ; Wed, 17 Apr 2024 16:25:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jtNNgm+1; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713371138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FNOr1el/BueGEYH9ReRV1YHomFZKKuDkdYF/EDGjHU8=; b=RV/t+QXovXQYqAYmNFzkQ/TFwS7o5b4BjadjzjXvsKmbcYSr5slvRo29BV1aOH2EjYYzm1 dqZFlF1PWaHtk0NAtgrws5bgyPqIocZMnjRSS6Wv5+Pd4DilQETaVNNjFGIO1k68Dx03xN gkXV1mgprEVEh3/1MgiL8jgjvW5yuC4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jtNNgm+1; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713371138; a=rsa-sha256; cv=none; b=SEKTr4HCwEWZ/SLrBzF1lnOgHEm458keOhDW1h+3vHDWOeW+x/zNMW3x9Uo0CC3RYyEmNN 1r5aeYxZo17QWbxXjGYj7oaVXRCEIgfTVEe/yUucv5cI0+ksW90E11w62eIpci4I6SJfup cm5bmLhGaCVxS0UMfvLoVmuCfD1UG4c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FNOr1el/BueGEYH9ReRV1YHomFZKKuDkdYF/EDGjHU8=; b=jtNNgm+1Q1LqYI2cxmrIUJ02KX cuKxf9DRcotpjx6YqaIlJ4fymrsB4qadMxEWhsdlLa5G8wGM7Lo8s0h+QJQrTHxBLnkgyTOG84kP6 yqK9xBICWXAns7Hn/iDzVqnwkiBeh8mJVxI8F8BKoTFnkakyWLTmzaCPps7K+anem0en+YLJDC+0z lZ8iNCaWkNmfjtSIhxEZqggsTfGqA7wsRa83CJLKl/PVAE9icnZR2IUfXu1drhlmmbx+SNJQnz8uB YuemtwEdPZ++E5FwlwFWpQviq+DfouhD3Fc9RsjsMMkeJXevHfbdaix9sGhm1qmhCPBsvx884HXGh b5UD0HHQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx868-00000003HUI-12g8; Wed, 17 Apr 2024 16:25:24 +0000 Date: Wed, 17 Apr 2024 17:25:24 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Namjae Jeon , Paulo Alcantara , Shyam Prasad N , Bharath SM Subject: Re: [PATCH 5/8] cifs: drop usage of page_file_offset Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-6-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417160842.76665-6-ryncsn@gmail.com> X-Rspamd-Queue-Id: 70BC514000E X-Stat-Signature: inon33zwd8wykyeqkwjekm1fabtq4nf4 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713371138-143230 X-HE-Meta: U2FsdGVkX1+VvXpNEd5I4MWscrczmWnbyFtLer7d+VYia85I6lrKI1thEXUSdVCTuNxYweyACnxbuvFpgjSwqfAfcYI/Z1M7XI0xjyeQX9vjoz2mnI2W4PZUI40KUV5nXR4P5nSLYrQDxhJZJh88K6kQgWKBsXW5NrkdXXlvUZ5WSdvEIXHD7CDBxchXlHY8rMF49Cj9PPe2yQv1j4xnrgvp16dD1ohrh++Hog8g8wMRlLPL/A4DHRG5AWl7B8yT5CmaY6/a6WdddEKXk/7t0EvAFuiwJchv5G6RhgZOs78VTvdz3TGBZADbbDoNGlVeuAw1CNrbuK9TXDLvgZcIjp4CjSRZESxuGDS4gxJZ2141ikRV42XL/kNzzL8YHAQDyPNsDJi0q+jjdc6a6PT+HEAA46pKM5TC77Q9VhDvwr6gE0MnZ4E5Ut/YPq9phQfKoSBJ8OB6LERMkhqVS5ADwCgip2AAxtxLVA8FmlR4qgRt+5J88HUWInA/RdOBdL0GRAeqhimjx3MZ3a7aWyePi+YVfUbz9YAlGQZbvMKiKqaVUUwlaerUc937mddhkjpb/RGOFLWELoUgu1j7bZ19F945RpzxnIx9ZjCZMKULnEyqgTfe+DnMatqeIYVMdVRV9za3b/5crW2lwW1L6Ej8Iyk7zJUDvF9Vg5GUplTfmJS6q+x9coDoUB2LG2klyZMbAvnUwVdg+BkJpYpKSywk2i2x8kntTw9DeHr2eIDbph0TgJzWx/WmkHdyUSykEW8Hy5kfF9EJZleHp0mTdNRa5dgt7Hk6LKzGEhAw6l06Ahiy07dS/SmKCMP27520jjwEMbxIRsv/jZGborLtr+jc2KbAkdlAumWpWxq/fNkdI8NSvAVsnMYWGxyqsWCX11oT8J5dcyv25Je9dE/ReVuqJ8amDvqKR6IE58ZCyOpywX7kLV3zsLzfKtousxAcZma6qo18PNPPqEG5g40HB4T jsd/zHry vVAmPAt9sVLtEptXb1bhSkhm3r7suUKsH+JJo6KXpdfWIIo2X7XPfVA/ia5RdgDPXOSjensv32kXRDbMpCEN1SOxd7Eeucb8gI4yMQsTtjap+/zDHfuTiiXhhLXwL+ojdmuBLlvF4gE0HoBU92BSl/KOc9RvR/Leri0hqCQYQHx8La81ZYx+/2OB/HgeLLTIvGEHCdwC9Oh8CIx4F9KK9pMz9jA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 12:08:39AM +0800, Kairui Song wrote: > +++ b/fs/smb/client/file.c > @@ -4749,7 +4749,7 @@ static int cifs_readpage_worker(struct file *file, struct page *page, > static int cifs_read_folio(struct file *file, struct folio *folio) > { > struct page *page = &folio->page; > - loff_t offset = page_file_offset(page); > + loff_t offset = page_offset(page); loff_t offset = folio_pos(folio);