From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B1BC001CC for ; Thu, 11 Apr 2024 19:42:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 157896B0082; Thu, 11 Apr 2024 15:42:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 108616B0083; Thu, 11 Apr 2024 15:42:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F111E6B0087; Thu, 11 Apr 2024 15:42:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D3D916B0082 for ; Thu, 11 Apr 2024 15:42:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2C0F1120C3C for ; Thu, 11 Apr 2024 19:42:26 +0000 (UTC) X-FDA: 81998272692.23.5DD8AFB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id E39FF40014 for ; Thu, 11 Apr 2024 19:42:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p6WjKA9G; spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712864544; a=rsa-sha256; cv=none; b=nNy8/oIclNB94O6iaUn5s3agqgerYwofyrPlRU/IrbE9LiDzKkEfDS0/n5jTbBltN+HI6C XuV6YOvwfW3H1Iz9GU2NzaXFBF3BfGIGyArmpTSlqdoQRvGbHdZM4CuzAU1ObBQ6I4k4/E VP07nj6+MfqAKrwC8VSip06X1jyRf5Y= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p6WjKA9G; spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712864544; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GLmQ6OAiLByfHZ0eGe8X2lInPvVUnYvYGHLtnSFpmng=; b=gRK302UKQvBgVjy98Y2otuJyKHzabbJGWQ1vt1bYwvK/cW3ynLv7TIm8koJyOQ10r/vVS9 xPrX1oHELSTBqkYEb1yD+O8Xaewxx57tSMFxXjIWxHSm0s4wSWZuLnC3gFL6T6VMO0q5KA ZtABbViZ74puRFefFctKF22fo5FzW1E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GLmQ6OAiLByfHZ0eGe8X2lInPvVUnYvYGHLtnSFpmng=; b=p6WjKA9G6dX+WyDufUHAVMvzmt TEEuKUVS+thzRELnqAjvnH6i10dz570nqrjJL9ZXGf4bZS1nXuY4F57S1i8sknzzTiosXrRMWtwja Wl2QVyKMVPgdD4djWPDJyYc1qh+eRSQYF6g3SQ+FxVhW8CjBgW1dMrDQA2/rPtVx22R2m4mjZa233 XbfrF3KCbxbV4a2eULYCR2JvTK5mnLn6In5XBzJIKJGJJDaTbAKriC0c3xg5TIewrOd+koQ0lcmWE yuu9PAFmPro1hKpehzsdur/j+e2m4dzk/qfRpBgrPaEio0j2aD0jKKMt0SHDFcdZ3PlSFQUBMlTG7 n33Z/seQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rv0JB-0000000Dvah-2hQJ; Thu, 11 Apr 2024 19:42:05 +0000 Date: Thu, 11 Apr 2024 12:42:05 -0700 From: Luis Chamberlain To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240411160051.2093261-6-rppt@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E39FF40014 X-Stat-Signature: pjsxs3dod3t4i3gh1riuh6n7rnyn9gzp X-Rspam-User: X-HE-Tag: 1712864543-945267 X-HE-Meta: U2FsdGVkX18U0wUP4B9O/w5CFT/n3Q2a5q/rhgm4iiRanPP8xp5FFvZp9X54czHVD69GXU8okES0Hfrn6VLOUJl4vsHSdjgQl8FTKI/1M0Fb4d3RiE7nYC0yMpQo6SjhWqlDeXo/vLdRWD/nxDU8L45XzSBlEPsnel1XKRuzzjYVia3H8tmjYiauJA/s8OrOVhDvA5BH3aQH13D5lYDG7T9Ly1f1LaJTq8BDqKLpIQSehM0u4TV1/QoiaSppsv1VLzsjRgb1iv7c7rvZqg5TBz1aAvDdchCYppN661ff9v4JGtbpjuFNV9TOPoYmsU5BOdBWwh+Tkze/ORKlZN+YtfUOAsz34CHveMbLf/Dt5lsjk2HH5ccVJWleA/Itf6jZrzEGvNVE/5A+QxAloZJ8Gu2tVg5IW7oGQoW217XSxqgFh7HgK3iJMgY5+ndTTeEGO44h9R8UuzkK05OCqm0VVFBXwjpuugBRGDKAIYghWqqXv3AVdeuIRa7VJaVwGDqk9jQUYDVzpSt5SSzL6Bbpxju95fkBJrTItv65KguyDyx1dTKLx6urCbGlysmuKRL/1r8MARjmp0Q0JXDBCA7HkIBhtn/l7e7BD5GtGmsKIZztRxUGBt3AW6hJ46zbpj0JlQU0QKLIC5ZJzhnRk5DWMrqZsEV67eg50XUsGxkSOGsMpe18gLI+kj+zS819v4XUqXBEjZXcWoaJ65g1vyx8WGnMla/SSNcR96V9AnXsawPBKsYZxwbDLpyrNqs0Cd9yd+/jTiO8f3lZXJ4PlEoPKXI3jCr5FdUIruxj0cXDtaN1PiWE0z5I6qKg4IO+HYnoiIpouLbV0O/Z0HOaWqksciq3mbFkHuExltDoYLzjVMApzn12lZJ27xSZX9fjKrcjZ/bs2pAqX83+ABetSkIIEh/8CANbSVSd0/I1/DfEHGkpkksZyOZcspIOvldTdag6x+XIuXVnIcp5hjLS1R+ bpE0KXJe xN3zUla4u+b/UFq7p0MD/mUx/j0yWsQ/cgz40gjShsy4OEnRD0Nck9DAC+jxRA2lSE69g2+P/eiJwDbnGzJFRX95VfcQc2K1F+A3afg+bqP4Pjoc7jVWUlWJhm31MBCTKFFMM3ty9I3AVZW/Bl+vSrRVZKjgZWevgkLhTMz+Ykpxou+j923X7Lc9yHqQj/XBBJw1Ea0H8mFBfLiyTRuK6Hw8/EVRlL8q/JWovrnw5mCKinSXCpSa263/pZQ3SSVKk7J0XvZKabcycbl7+fJs8eV10svUDk87efejynd1DnnxBHyeL52SONQDZebk1epFlawjUoc9g9vo2568a2Y/+XwUEzTI+2pvmin+Cey2DvdX/haTkNZjNx7zXE2Y9H3IyU41UsolwyD7tPJdoqA961pgOJwA21gJ03V5+aORGKO9R3NKTj0bUTsQcO5krpJZZq3xMPpPm7XZnji92wV1AEi2/wEWxeRKpjPuHiWZ6OF+ZhBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 07:00:41PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > module_alloc() is used everywhere as a mean to allocate memory for code. > > Beside being semantically wrong, this unnecessarily ties all subsystems > that need to allocate code, such as ftrace, kprobes and BPF to modules and > puts the burden of code allocation to the modules code. > > Several architectures override module_alloc() because of various > constraints where the executable memory can be located and this causes > additional obstacles for improvements of code allocation. > > Start splitting code allocation from modules by introducing execmem_alloc() > and execmem_free() APIs. > > Initially, execmem_alloc() is a wrapper for module_alloc() and > execmem_free() is a replacement of module_memfree() to allow updating all > call sites to use the new APIs. > > Since architectures define different restrictions on placement, > permissions, alignment and other parameters for memory that can be used by > different subsystems that allocate executable memory, execmem_alloc() takes > a type argument, that will be used to identify the calling subsystem and to > allow architectures define parameters for ranges suitable for that > subsystem. It would be good to describe this is a non-fuctional change. > Signed-off-by: Mike Rapoport (IBM) > --- > diff --git a/mm/execmem.c b/mm/execmem.c > new file mode 100644 > index 000000000000..ed2ea41a2543 > --- /dev/null > +++ b/mm/execmem.c > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: GPL-2.0 And this just needs to copy over the copyright notices from the main.c file. Luis