From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF20DC4345F for ; Fri, 12 Apr 2024 09:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AB9D6B0082; Fri, 12 Apr 2024 05:08:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C4F6B0087; Fri, 12 Apr 2024 05:08:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3E936B0088; Fri, 12 Apr 2024 05:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D83936B0082 for ; Fri, 12 Apr 2024 05:08:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2D6E71C1305 for ; Fri, 12 Apr 2024 09:08:08 +0000 (UTC) X-FDA: 82000303056.29.1CE9133 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf24.hostedemail.com (Postfix) with ESMTP id 671AD18001F for ; Fri, 12 Apr 2024 09:08:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lb/5ero4"; spf=pass (imf24.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712912886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yPUGnUPFGvIHpfCf2GVNK2vLyHGdD2DrkaoFCTmwcrI=; b=fEq/sj+eOSnr2lzjac7TQEqb1Eq6y48BbR6a/YKJNCpATEZ7fXjwkUBmU/46WNget6BGI7 LvV/OjBUqAVgwcjh0oaXOOLR3RzbSJ/ZF15VWOLHrCffNS8rbjeD6fQUXrs4kMeXaUH99M zLVh5JoCokGLrtv7iskLTbnE6sjV9QE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712912886; a=rsa-sha256; cv=none; b=s619HO9Zt/pNMylniwjx40bEkVA/t4Xr6l+aZWWyRvPoey/I6p1dWS6m84a/Gu0YLl/kRi uIigYm2D+KBBSHH4z1Vq4r2cIvZWX+87NAk65SOafrlyVNboZ9nQ4FeryQH6E8s9G96kG6 rmFodSkeciUZqQJtjHa4t2DHlzQBfQU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lb/5ero4"; spf=pass (imf24.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a450bedffdfso81258166b.3 for ; Fri, 12 Apr 2024 02:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712912885; x=1713517685; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yPUGnUPFGvIHpfCf2GVNK2vLyHGdD2DrkaoFCTmwcrI=; b=lb/5ero4AEa4gWyL5/uxNfmhoG1F+IccvXHuhWNvWFiSzAGnWDJayCh066Fxj5zbtH 6ww10IXJxKN0mCBWBOU/qgkfFW4CcZp6lJu56gsNz4qmM1TjQgCD1Iu3oYBVIek/gzLq Nduuj7mNLT4GFnHGrZrnqmcIFwVJhINR5xJ99Ov5ke9OjohLIIIaUbTKv7xL8F/yjKt1 cfHv9u0200h8eIwzbskX0Tr3vAOeE2Ut0gwx9K0c8zEGf4shFigsBcG1W67DFb/wekK5 xZzXK/W+4iOlutG1iH2Z8lA3RZLsj832d9k4ptlV0y3a1lQw6pD7H8mhNiLr6or+j55S b5xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712912885; x=1713517685; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPUGnUPFGvIHpfCf2GVNK2vLyHGdD2DrkaoFCTmwcrI=; b=eDSGBgxE+KR2F8OKKJUWZRmk39uuRLd2bkRvcdFZNeiJWnlbkYnxOyuAGRwlY5jE4t 5qhyHBCcTXSfC6wZTXkcH2KpBrsdUkaNv0UZVU68lwMp+IHpHn3pSVPT9B+w/TpPb9Gw HSdaeP6h7U4S7nzH0FX7MixJY12kmFdq8ly45iF/8ZIH8WLSQujKrsNHMvvO4k25auFo sQKEQVgBiAEY7yEZiYTNlRxOARCd8a6lfHBwb9+B9G0mTrRoUDIUWuR1AD5CmCk++hZA 2R/ZoBHOoYuL7bY6zmJvt1SZC1sRf5VoTCstVDGMc2BJ++jlP4tW4WtFoycWWiIAiRCi 0lSQ== X-Forwarded-Encrypted: i=1; AJvYcCWQu44nlZ6o5pFjAjTKDt4otitK2B89jmGf2klMuDS7IRxV4g25fIxNdEW73CloFYf9FIamOW6/PSMTQxJ6GFu2jRE= X-Gm-Message-State: AOJu0YxLA7155URTq/Y8TVwmPhtFnNY4CTdZoEPsutbfFYOcYTJ7AIpQ ICvqhV3n/skgh5NAJuxuQUUgAoSpA6KA6cC+B8q17pg3PrrPQT3R X-Google-Smtp-Source: AGHT+IE1JXTG/LcQoI+lnHKGTMryNiPMKyUlJP80kVd4eHhaWi8p2N8JmnjvJqW2HLQ210FFl8qPZA== X-Received: by 2002:a17:906:345a:b0:a51:80d9:56de with SMTP id d26-20020a170906345a00b00a5180d956demr1236428ejb.5.1712912884326; Fri, 12 Apr 2024 02:08:04 -0700 (PDT) Received: from gmail.com (1F2EF1A5.nat.pool.telekom.hu. [31.46.241.165]) by smtp.gmail.com with ESMTPSA id zg22-20020a170907249600b00a51b18a77b2sm1572994ejb.180.2024.04.12.02.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 02:08:03 -0700 (PDT) Date: Fri, 12 Apr 2024 11:08:00 +0200 From: Ingo Molnar To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240411160526.2093408-6-rppt@kernel.org> X-Rspamd-Queue-Id: 671AD18001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xofkhabdye5omjjpigspwf5t4b9ap6xk X-HE-Tag: 1712912886-522388 X-HE-Meta: U2FsdGVkX19oi5KV5kP4xToPZbSv8uPVS0Rw0CgxHsJL1NCnoXh0OmhBFQdm1iBvFMd2xT938paxMn6g+bgvzuZeX0gcPRni4XzzxymuU+1yB3C7ZXXkl/L/S1eK1W87RGDQZ5Ke6dPExQcD7o2VdQ8u0hDw6MLsfBDP8srT09pCgQmp5mqYkYuOVInUeMKlFwqJe3vYKm25bLHRuPLQsVysGcjgyj0heA9fcR4neQa/Muq95qSZ2RbVv/qrkdAryb1TpBG4vLaSniOyZ/zVk4UI85rzcBr7GNhXGtGR0tEn/KRcgoaa82jjjbjiomKs3PiqHOLNVqEHvZCMsAQwJxPJKkVH76i51o4vifG4NQV3+eCMuPEMk40BjJ9dx26/syuds0wR8Vpg1+c1Q+1YQY1m53MSJ/ybvQD8k0feghT1Tbr5bQexjqTyWx1PRgM1EYex7KKKSY0p+CQvVpCz42/2ywMeqNoORF60jITXzid14n4IecB3gn0lfEdTYA/Cy5iBlwZKSvi5UTYdSlNqVhDQ81RTQ6m18bTt/cRbc55JIM2o2joW7d93mk1em7OCoPxPTDifG9/ztxJ78JWpfWfmE9TjlXv7miwQ9JZaSKv/J882Pi88zOkEgWgYoTJs/3OtEHt40cj/VEv+CuJgp3x8ZFHunnzv8Zi5dh7U5R9fm/jJ+IjoJaIteKOlztohPNpLIbuG7kImLdAGhngBn5+QhX7ithRrF7uyTOf4mXx/oRpX13cw99MU52whvCBAI/Ldt1fLQMa5l8hqugg5NaXM8Ka9/5ZcL2GEXa9bE4dKnNuMA08Um9UzW3dVOMOVE0H+ZHh8jJb9Lft6XzxMZr8lmDr+N+q1A0gYtn3L60bz13IGfJRR4eF2r1zqdVCwF1+s7YvkBsp/ma5bCabksFSo5c3XVdvLiFDh8DEuo0nnE1QxK06b3XbSVsmX1yctOGEcF9cHhq1JdJRT2cj seQebdb2 E7ziD1pHYO+kKfoCojasMOsypbputzxODvep8ep+kQDpEdDrJ6T4eAsTcnM1aeGztQNABhQwTeE67aISa+2nykGCJSZxANCZ2PlDYrvTNbUzCGVTPbHwe9X5BXTo5Nsk7o7J3NwZ2IlWXgwfOiVkM0M8aTv5W98EHi/O4gxPqjYBqP8SPIVeMxDtglNVHyqj2N8aWsIjagK9JsAGNka8wgDjqoCR+K8sKZ/idkWN3pnI+Mde5/IF33MXFWE7/H9jWhizk9zqut3np2CRWutl7HYo1teHxJN6h/0NK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Mike Rapoport wrote: > for (s = start; s < end; s++) { > void *addr = (void *)s + *s; > + void *wr_addr = addr + module_writable_offset(mod, addr); So instead of repeating this pattern in a dozen of places, why not use a simpler method: void *wr_addr = module_writable_address(mod, addr); or so, since we have to pass 'addr' to the module code anyway. The text patching code is pretty complex already. Thanks, Ingo