From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF0AC4345F for ; Sun, 14 Apr 2024 07:35:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E69A6B0087; Sun, 14 Apr 2024 03:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 796916B0088; Sun, 14 Apr 2024 03:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65E076B0089; Sun, 14 Apr 2024 03:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 469D46B0087 for ; Sun, 14 Apr 2024 03:35:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CE30EA02D9 for ; Sun, 14 Apr 2024 07:35:20 +0000 (UTC) X-FDA: 82007326800.26.DB39635 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 803E9120003 for ; Sun, 14 Apr 2024 07:35:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CkZX4pyV; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713080119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7bVnsILqFonb9QmaQyRWpUsqw3kdZE1JbY4tH0JteAc=; b=cqIwf3JFkWQQrOQmUm1ieh9Cuhj5LQinNyliy9EMFnxMBc49rUoXQ0nKAWnPkP2xpjpgm9 pZp6tKnrr7Ya7PXlR9GFVolIxLtkbZC7GBfNZQQMCDh0mQyrJ/RFDLojzxeypqFGNfFYA9 gkbOJqgWRWgpZMlXSE9PBNd90O1n/Lw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713080119; a=rsa-sha256; cv=none; b=X+Ato1L84fLuTuxfwqSbWLs/kI0/qTMOpFxzGIM1WLENt2brOlPmCLBUd1D/ZzGFX/0yeW gGnEK+Wjqm8QTEmP4ycwxmuY/orQ8XcUpYjDWHkqXYq6rRxu6MokX2MUJIbDO09YULXgMb 4ttAryyuKM7aYqnhqxLIfmsrmWWeHTw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CkZX4pyV; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7DD3FCE0660; Sun, 14 Apr 2024 07:35:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E552AC072AA; Sun, 14 Apr 2024 07:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713080113; bh=3r6JYrqvdbon9DEhTY1H2+qNf7eZiRWdkYsZpzrESPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CkZX4pyVmQMjyHu1MkWMG+OmN+DpitNdvE+8Vnnpv2LwAkTUvDzAFWuF0QZM39J6H Ds3a5kvcM/VK28fYIC44oLB0Bdn+zUbgRasxe5aCWB4xUu/RgLtSeh5qZWnq/2e8FJ rTnb7E26SRg3O/Hr8+YjRqZvnQzlbsBhEdpfwJTzRcQc4vzX1fY1+RLch4UM3gsvOo lhHc3rEpR8JxFCgxftuFbGO+Ys7pTermVZbhFSEMwu4SjmoAKErzDXHDO+V07uYXeL 1NKQmyuzEhmwb/N+lOun0QbkHzR0Hj54fWIETmay8j375CiTaSdfa1+arS37433DN9 Fj6dSalTyF8Tw== Date: Sun, 14 Apr 2024 10:34:00 +0300 From: Mike Rapoport To: Christophe Leroy Cc: "linux-kernel@vger.kernel.org" , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , "bpf@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "x86@kernel.org" Subject: Re: [RFC PATCH 2/7] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-3-rppt@kernel.org> <9217c95a-39f6-49ce-9857-ee2eebdb7a16@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9217c95a-39f6-49ce-9857-ee2eebdb7a16@csgroup.eu> X-Rspamd-Queue-Id: 803E9120003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: y7ebqz5a59ecw1sbdcqsag9s5mcqaspb X-HE-Tag: 1713080118-129675 X-HE-Meta: U2FsdGVkX1+V1Pntk0nYUmeW2x5cP7qmS6psMaBRGYnpwDi6JEsC7S1sRk7AFhImK36Pu7VaEtZj0vhfRN7qIPlzvsFB6K25hEBA9065LMoJR7J56H66QtS9UVSsgWGYJLiDB3V4i8MNdWpNPyr/GgooPzqohTbg+Sf9WTpZkeH7m80xKrvPxZEFQpvTAHF48q1ZBsyxQdMSdrHJdTtODuO7gbpZxId0dV/gjOCG6psG2Mz6AeYKvtaqrLeWJyaiH+sW2wMszQROU2IDs6bMXGM8RKTQQjoXfWwP6ucd8qqo6RxsLMv1hDqe2Xv6j8ujog0hNHosemiqnfhhNiZzfYHD2OJhJQIyfxQ+A8f6QwhoiUdrAFEWJs4mpESjgjJxABcADzTz8ud1KmlKQh+oOdjaUYggwzsaZHUyC1Y3PWakNZNXo+nxqV5P7x10wrGFDEhPMqGPc8tOKn2IffTjAPk2e35vblpnVn0kXStgV2WqbvueZ0R0J+k1/cdBoVrkVBqtu4zwc60Qq1sHWPK1VJ8l69jwrSJ0x+lT5cwTta0epD22N670y9OKvdn4sDreq6UlHT2WiHdT/XCn4WPJjAOHyX+96p1nVsUc9gYsk9nOSM0ds3QhdQ0PgyT3bOFgrB0jgviWpuW7TV9FeR/q1nft2runC2YCmLGseNL5to51SAHULIVO136slZcneCx1Klym+WrQBAEkjxi9qm44wnhsCkGPQdazKg2CEswd5VbPXJ1DFFQZzHx3y8CM4Iqq3B8oehTIJWeCjfy0MjCH1swiksPqUM4mF8kTyiKMuMvaocqNiFSZWoOXCXonCIZBgN/003s453edzc+229+8WAodA8XzFLeIOFRhX3bxWvXAjGJtZxXYBm3tHDrhoeN2NBCV91LyVxQMafXXVXu/Bx9SjmAeMsV2/MbqXGG4mqR0P1mNeTvbFdVcXu2B6YrqhwRsWBSXIM90JGt67aU Tvqpzlsp MiiIWo2jUzsZXWcq9e1xHZdrTwXxIeVjxfhCg+1+WG2+l6Zzezi/2zyK+aE70Wa5gGLrIr6zMwXSdX6cvztrfko0xgeLThyBWfHIx4MsrPMRa/YfCcAZe0tuwhJv+oY8w0oWxVdtUmek9sQVrnCaNOXP2qC06fmYnmBQF1m5xQ+tAIZ00ijg07DfD5WJURt1mtgGuHLTx5mqDLXpByOomksAKiSTdqVAJWlCyl2UN97aoGpGdCRva5sWxKBLLDN7OnFJxPx6dB1B4f2zramSdpDtPIwqNMLwZUMdyIFZ6mOjIsk2Ox6lxwbZ5VGyFgsyNiht6ZItzP/VlY1VZbVqb8jQ87eX5BZbFM5lqhtR+Y/hV6uo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 06:07:19AM +0000, Christophe Leroy wrote: > > > Le 11/04/2024 à 18:05, Mike Rapoport a écrit : > > From: "Mike Rapoport (IBM)" > > > > vmalloc allocations with VM_ALLOW_HUGE_VMAP that do not explictly > > specify node ID will use huge pages only if size_per_node is larger than > > PMD_SIZE. > > Still the actual allocated memory is not distributed between nodes and > > there is no advantage in such approach. > > On the contrary, BPF allocates PMD_SIZE * num_possible_nodes() for each > > new bpf_prog_pack, while it could do with PMD_SIZE'ed packs. > > > > Don't account for number of nodes for VM_ALLOW_HUGE_VMAP with > > NUMA_NO_NODE and use huge pages whenever the requested allocation size > > is larger than PMD_SIZE. > > Patch looks ok but message is confusing. We also use huge pages at PTE > size, for instance 512k pages or 16k pages on powerpc 8xx, while > PMD_SIZE is 4M. Ok, I'll rephrase. > Christophe > > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > mm/vmalloc.c | 9 ++------- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 22aa63f4ef63..5fc8b514e457 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3737,8 +3737,6 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > > } > > > > if (vmap_allow_huge && (vm_flags & VM_ALLOW_HUGE_VMAP)) { > > - unsigned long size_per_node; > > - > > /* > > * Try huge pages. Only try for PAGE_KERNEL allocations, > > * others like modules don't yet expect huge pages in > > @@ -3746,13 +3744,10 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > > * supporting them. > > */ > > > > - size_per_node = size; > > - if (node == NUMA_NO_NODE) > > - size_per_node /= num_online_nodes(); > > - if (arch_vmap_pmd_supported(prot) && size_per_node >= PMD_SIZE) > > + if (arch_vmap_pmd_supported(prot) && size >= PMD_SIZE) > > shift = PMD_SHIFT; > > else > > - shift = arch_vmap_pte_supported_shift(size_per_node); > > + shift = arch_vmap_pte_supported_shift(size); > > > > align = max(real_align, 1UL << shift); > > size = ALIGN(real_size, 1UL << shift); -- Sincerely yours, Mike.