From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3972FC4345F for ; Sun, 14 Apr 2024 07:37:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A588B6B0089; Sun, 14 Apr 2024 03:37:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A07FC6B008A; Sun, 14 Apr 2024 03:37:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D0B86B0092; Sun, 14 Apr 2024 03:37:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 701D16B0089 for ; Sun, 14 Apr 2024 03:37:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 05677A2144 for ; Sun, 14 Apr 2024 07:37:02 +0000 (UTC) X-FDA: 82007331084.12.590E38B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id EEC054000C for ; Sun, 14 Apr 2024 07:36:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pmbOtwx+; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713080220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9GAl8KEQWWDciDS+mXgmUfQFnQ5he89apNrOueKCTsE=; b=g8VgzBZsX9vrXph6xGoukmrw/Tldgz9BxrixyWV/Z/1a8LXW8S0FGtR9QDWD5XA8Jiia3K Utv3bXJ4wDzR47c1MuLZ0l2wtIa37wnB5irj+fJuIQNqIHkRmnXoGvamZ7fWdHUBI3+Z/2 DaXpLem6nxpexZQDyv9mkB5wjZJxLT4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pmbOtwx+; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713080220; a=rsa-sha256; cv=none; b=GdBp+Qt9NVsT0C1P1yVOECT/o3D5jznrqgc6a3AP+MP+UdzrR2upqWiAneK4piFgRx/Ald +mOgegX2SeGpd9xsJkXq6MwxeQ/Vm1/lrPojeDv00dbLGRfUPD0G5KvpIZSRdPV8PsGbMa V3HGR/frBDSkPHytEm9V13QwYMcWR3c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E1A65CE0660; Sun, 14 Apr 2024 07:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AE94C072AA; Sun, 14 Apr 2024 07:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713080215; bh=BR4ur7se43kPXCUVLf6Y0OP7MVR1Rv+aJKN+ghbILUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pmbOtwx+uhP9H/utYH9BcUL2xj/Ka1KVJK6b6TlmVmh5wUN7RShrmZqV3fElednNr PLo23bk1pmangeGEqKrrJDDbzSUKdOzPxLiI6z2Iv0Oqmq0sxdrHrCLrAzh28co+BJ bbmel8ioD6s7h8xAsEjrBLYjbfLdAea51klVDqMWT34WOMNgeL1cFP32fZOxdlRVJd dArt+DeqqoJkVwora/vo+eApqnXKwkDrxmR4m2ImVxkqhTucJm4Z8bchhp91LsvSAl CS1YOGLHOkOTp2BnI7lfvt/mhQnS3DMYKllAZRqZvCg/EMbqu21/uaEQilGMpGUDUw GnSi9UsVWFWxg== Date: Sun, 14 Apr 2024 10:35:43 +0300 From: Mike Rapoport To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: EEC054000C X-Rspam-User: X-Stat-Signature: 9scynzf6rrtbs3sjm13psiiq4cqnqx3u X-Rspamd-Server: rspam01 X-HE-Tag: 1713080219-936814 X-HE-Meta: U2FsdGVkX1850DeClMBsN5wUOtNSj3TT8rawgp4iy80EqbX8ccxRWt/h8z/V37+/QBCk9tW8vkQsjGZo3UCCiIDNCWYuJVyprwon3Wo8UwAWmb1IVCth2UyBQLrjZJN10apLMbz6Ez7NQCh1ECfaRLzFqpnWfFGrtGubFrDb2SJOnMUvD0Vg1F8Dg8FTPatVrdJienYApHkcMzBAwu0sf4V10GRHtJGmaz9Zn/cf30jhJEHZ7mSFYUs1A5Fe1AeYY5H96apQcblBzJHgSllCaTpewveU+AyWqcvoVRwFplrpfMceabPTiRRcNrMEvzMKpBX/cVSMeQfEBveo+sP2MCihVWxV+J12pSOhBxfrBa4HrizNd6HW5UOE8Ck6bv+JeeTGr6/UfgJ8i8MdtH23eQzu+Yjdt343kOwv6OOSMXIcvuwkzgoXpEjvZv/H9S+xqVifIJe4Ays/gLzGnuTGmt9SGMSylO62ZeL4TdI0fFMWMWNqbhVJ/MLhwYK96sMaNw3ldM0lFAQsIATpYWUu9fBF8NSZVonx9hzLQEiA/CJJYwXA9eShv1HSy07fecy1D/yQ23TBGCbg8A/EKZJ5zRKSDjwFqYcXpO4wJnNKjYTCMEeYNY+DaX0AxvHTEj3WOl5yGshVaIROfUfVYMAFdD7Zvfsbe/gs0wx/rENlCUJv1WvEpiOFXwsafg7EcTiiH4LcpFIGZtohpjdM47FzbA4XNri+MpdZcB85tgCK8zp1lxZsd3QUcEWk0+n1wwK3QYnAz9zOqSbB5w+fk1rfWw5xoQ8XB0uNtwxaukO/jQBX6aNCfrxzcUgVtb8wXFd7E7Vc20nmHLf8kC6Y6NkHR8nsOxpbjWDa+7jfYkKeQbfkpVp7oqP4lRNoRgPLBWW/ZBA2zZSsx+wlZEzTT/cI+ewYZ2j/gDBXMmoxhDfSAGogNAasWu3aCb/G/J6+OXuCwLZrUSvXjptGpf2STgj orkqcGMI ehjaF24BFbOMicDphY49jOmJLhWvbY7iFxea2vZUVWm9K3WldbiXk4ShZ7sj4zsnWJ5yHmSTMG63/HKo3JPhC1iYzqIJ30w/gL+4DxSxQ5yyZJHKwxxIoPbOG1ByqFREtPkUzuV7I0tavWGoNCZ4LkN1P6vuwZ9+bCQLImJq3Sno1UzJd15V0jbXqHD6pxXTi7R4peGdly1PgeraNCG7HELzzmF/uvN1aP44Z3RSeEyww0/A7P0WqnkFnIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 11:08:00AM +0200, Ingo Molnar wrote: > > * Mike Rapoport wrote: > > > for (s = start; s < end; s++) { > > void *addr = (void *)s + *s; > > + void *wr_addr = addr + module_writable_offset(mod, addr); > > So instead of repeating this pattern in a dozen of places, why not use a > simpler method: > > void *wr_addr = module_writable_address(mod, addr); > > or so, since we have to pass 'addr' to the module code anyway. Agree. > The text patching code is pretty complex already. > > Thanks, > > Ingo -- Sincerely yours, Mike.