From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB93C4345F for ; Sun, 28 Apr 2024 06:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 639DE6B008A; Sun, 28 Apr 2024 02:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EA2C6B008C; Sun, 28 Apr 2024 02:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1566B0092; Sun, 28 Apr 2024 02:45:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D7D66B008A for ; Sun, 28 Apr 2024 02:45:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A0BDB120DC7 for ; Sun, 28 Apr 2024 06:45:18 +0000 (UTC) X-FDA: 82058003916.19.2FA32BB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 14D0BC001C for ; Sun, 28 Apr 2024 06:45:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kSlAhmbZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714286717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5wvI+MwwId8QS0rFwROV5TFWjxHDUqF/7F9WN38je68=; b=XN4GYAtsfZSSUpajqdIi8r1q3i1PEHm/0Y5w96m4dWcPoHE4WuKzcQvy//luYi7SGkhwC4 lVMvEpdk/v8YoIXrfkwLRfkkHA5iC4tuySAQoigsPdAL6nGp9+/dOjbdESExqZQKNFHB7Y NH9afqeA3zdyMVn1GFd0RhZ4JODyBrk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kSlAhmbZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714286717; a=rsa-sha256; cv=none; b=zb6pWz+Ri/dZSi6lt0cE8o3ujS+eoFvSJbk/RHjH8flY8S+TthRn3P243SVW9pXN8t8war ldK+ndGQlJTCOUZ8HwdIG0m/EO3iXv+kVf+nlmv164dmeeFWYZn+0/cYltu0nl4FzKuSSh ltL83D8zkv1aZwZ5SR4VMUScRorVn+M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 188DE60113; Sun, 28 Apr 2024 06:45:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35A5CC113CC; Sun, 28 Apr 2024 06:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714286715; bh=W6ttOCqRQrolOcOGS2CkdBg3quoxo5qTEM+1FCdmEcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kSlAhmbZ1jXicWOvgJBfr0shy+yK5uHmPYiFYKULOIVBl8Or2YQLoZ1v6HWdPgAQW 59Dxpy/TjgX2tNPEMBDVV5OKoNpBMCumg6OrwaWAfHKuLxN0V0p+b8eDfncdt8n7EO OJqGsC2FzuDL0x+nB8BqW9v58W73CIGVvnGCQ4iFs25w55UyAquJZYTYlJt9XoeQEw pJpvD5dKlivPAcf5pg5e+5PGjJ/x1emZigyFhRM/bwoUV8+UlkjIhjSXZ5owvNQ0PN imIGARqJr9wk+1FdWh40si0QpmJs0fNcY6HY8KovGM8oug/TBMEg1IIA7zWPbN0w/f 1HPmw3GptEukw== Date: Sun, 28 Apr 2024 09:43:54 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 3/8] mm/memblock: fix comment for memblock_isolate_range() Message-ID: References: <20240425071929.18004-1-richard.weiyang@gmail.com> <20240425071929.18004-4-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425071929.18004-4-richard.weiyang@gmail.com> X-Stat-Signature: wktqyheb8iwihro6y1d6y7hfg9yxrxst X-Rspamd-Queue-Id: 14D0BC001C X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714286716-679236 X-HE-Meta: U2FsdGVkX19UxKNAo9DBTwvPZ/leOnG6ac6D+JhXCTgQqQ9j7vS5fZFnxQgafSgqn/Nd9bTzLqKaD7TiJbk6kAVEmvdiqVmZkJ3uRclm3paM8R9ZW0XtikfOJJNRGB6bzfLJ1n2w7Kl47s//wgDKPeCN+01AvWP9SLJe+z3ugUMkxtLcdOk1ThJGD7w7P0iCfE6vs3LJ0yzqaS+Phl5soyztGKDQ8uWvB8v3ZLCxVf8nQ8vU0atdFAGYpHppK7/HkWya9lfk/kCflQ5g0ilZ/wVB47YXpGvUzuPR0TzyWSvkgxrV0ZBkoEY3z+/2/vxOjNgyOqRiJvdfMpDOo4DSUggp11qN+sIePUlIVzTYd5A/TvDp6SAHudHetZRIMpdv8Ktw83iyrvzwrKY40DZGWCAvEGyh7RdnewWvyGrZBTMyufxkvnSst7sHqV8T6U/7Waa+eyxqZAEy8Q7fZJxOXJX5r8sdBJ/T3yDyn7dDALVgjEKEcZ1Mu8gJiqftZ8BVB8kh8z+cose21PGtdsB2abIFimRU0p3xq/PRbd60KUThW9sPsGlizMnTN1EhOM1rTSf/elQ+38KjmT77PiIU/GLtyjSo1vlHQJs11lo3kgaH1L95h+MrNBRdT2TXM0gCVEg4efpA43CgE7LNfMpJP0VrRNd2ZTixnrJu9lTaEQtN6hyb2V0QwHze0aKrcpFGqYQgy5t0genKc8ALCFu5wbYkWEdwI1QrbOgJG4rDhuDWm0sNtIWgihseGaxKU6bUo9PHERvuNz6/p6DJXKMpOPXZvY88cyXUN2VOAO6CTf8kX9YtWW2qiwXD3o0weQRb63SRyzE76dcr1E68/+6SA9/10Ig5Hh+RF6+nutf4h7MWMSZ2wrAGBU7dQgZcx8m21bQX+BLsrWgeAm/VZ4nRgeh6+pOmgkOg7XFwt9/1v+4paaasqPSdgDWeYsE+P8bU8tUcZerHkZmac58KYDn wlJCyIH3 k4gkDK9f9AmIq872HDa023a1msZlE28jDEA95v/XX9387++WThL7Hq4Adeu0n5wEs5tjF4qRuZcSE8P4EUeQCZjSz+ygOk6b8Y0+6l4bZv/QXzqf/zuxwVBeZK8UpsT6HrOWL29Pz3TxtUmdmHhcv9Q0q5oMvTxfkoKr7SAysdXYz1yfzZLdZf5zePpRgtdusn/AHVuiIEKTdYcf2y8tfWyZoSG1Cl40J1e8Lj1Sc1nOJoN9Dlptec/GrtB5U/a0pWWbpyNNpZQKQSInOdpWnJDIh+YwCPvULNHnD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 07:19:24AM +0000, Wei Yang wrote: > The isolated range is [*@start_rgn, *@end_rgn - 1], while the comment says > "the end region inside the range" is *@end_rgn. > > Let's correct it. > > Signed-off-by: Wei Yang > --- > mm/memblock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 98d25689cf10..5a363ef283d0 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -772,12 +772,12 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt > * @base: base of range to isolate > * @size: size of range to isolate > * @start_rgn: out parameter for the start of isolated region > - * @end_rgn: out parameter for the end of isolated region > + * @end_rgn: out parameter for the (end + 1) of isolated region end can be inclusive or exclusive, please let's keep this line ... > * > * Walk @type and ensure that regions don't cross the boundaries defined by > * [@base, @base + @size). Crossing regions are split at the boundaries, > * which may create at most two more regions. The index of the first > - * region inside the range is returned in *@start_rgn and end in *@end_rgn. > + * region inside the range is returned in *@start_rgn and (end + 1) in *@end_rgn. ... and emphasise here that end is exclusive, e.g The index of the first region inside the range is returned in *@start_rgn and the index of the first region after the range is returned in *@end_rgn. > * > * Return: > * 0 on success, -errno on failure. > -- > 2.34.1 > -- Sincerely yours, Mike.