* [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list
@ 2024-04-29 8:28 Christoph Hellwig
2024-04-29 8:32 ` Vlastimil Babka
2024-04-29 9:33 ` Oscar Salvador
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-04-29 8:28 UTC (permalink / raw)
To: akpm, osalvador
Cc: elver, vbabka, andreyknvl, linux-mm, djwong, david, linux-xfs
Otherwise we'll generate false lockdep positives.
Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Changes since v1:
- only pass on __GFP_NOLOCKDEP and leave the other masking in place
mm/page_owner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c
index d17d1351ec84af..428c1ea8b4579e 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -170,7 +170,7 @@ static void add_stack_record_to_list(struct stack_record *stack_record,
/* Filter gfp_mask the same way stackdepot does, for consistency */
gfp_mask &= ~GFP_ZONEMASK;
- gfp_mask &= (GFP_ATOMIC | GFP_KERNEL);
+ gfp_mask &= (GFP_ATOMIC | GFP_KERNEL | __GFP_NOLOCKDEP);
gfp_mask |= __GFP_NOWARN;
set_current_in_page_owner();
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list
2024-04-29 8:28 [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list Christoph Hellwig
@ 2024-04-29 8:32 ` Vlastimil Babka
2024-04-29 9:33 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2024-04-29 8:32 UTC (permalink / raw)
To: Christoph Hellwig, akpm, osalvador
Cc: elver, andreyknvl, linux-mm, djwong, david, linux-xfs
On 4/29/24 10:28 AM, Christoph Hellwig wrote:
> Otherwise we'll generate false lockdep positives.
>
> Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>
> Changes since v1:
> - only pass on __GFP_NOLOCKDEP and leave the other masking in place
>
> mm/page_owner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index d17d1351ec84af..428c1ea8b4579e 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -170,7 +170,7 @@ static void add_stack_record_to_list(struct stack_record *stack_record,
>
> /* Filter gfp_mask the same way stackdepot does, for consistency */
> gfp_mask &= ~GFP_ZONEMASK;
> - gfp_mask &= (GFP_ATOMIC | GFP_KERNEL);
> + gfp_mask &= (GFP_ATOMIC | GFP_KERNEL | __GFP_NOLOCKDEP);
> gfp_mask |= __GFP_NOWARN;
>
> set_current_in_page_owner();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list
2024-04-29 8:28 [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list Christoph Hellwig
2024-04-29 8:32 ` Vlastimil Babka
@ 2024-04-29 9:33 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: Oscar Salvador @ 2024-04-29 9:33 UTC (permalink / raw)
To: Christoph Hellwig
Cc: akpm, elver, vbabka, andreyknvl, linux-mm, djwong, david,
linux-xfs
On Mon, Apr 29, 2024 at 10:28:28AM +0200, Christoph Hellwig wrote:
> Otherwise we'll generate false lockdep positives.
>
> Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-29 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 8:28 [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list Christoph Hellwig
2024-04-29 8:32 ` Vlastimil Babka
2024-04-29 9:33 ` Oscar Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).