From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B8BC4345F for ; Wed, 17 Apr 2024 23:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CBAE6B0083; Wed, 17 Apr 2024 19:46:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A636B0085; Wed, 17 Apr 2024 19:46:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568EA6B0087; Wed, 17 Apr 2024 19:46:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 37FF66B0083 for ; Wed, 17 Apr 2024 19:46:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E0132120E89 for ; Wed, 17 Apr 2024 23:46:45 +0000 (UTC) X-FDA: 82020661170.27.7094871 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id BE337140015 for ; Wed, 17 Apr 2024 23:46:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D2a30PBp; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713397604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GZu6N4Ih5Zf7eZjzMh2GB1Dsou/X46+ClOTdb83epCo=; b=w9Ulsp+zkygk/EG0aHq6bhQ1CLkr1UA5eZcKl8MBXP7g7luNRUtryFYLJPsS8yiwoG7Nnm 3LK1Qp7N97uU23V/2f75qIdo/gqT0XQwtxGw8hDg8xAEOnD8w1oLWerfNOkqwn5A9OocGP YQXFRlr808IaSAeKufP29dRbMxDbIQo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D2a30PBp; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713397604; a=rsa-sha256; cv=none; b=b/RadMgM0bd+UKUIplu5/Uw/b5qm3mKwIahjiP9NB6PKB9LPsybnZegYMMEGvqx8+IQMiM /JbhGIZ4M556S26PykV+aC6X9lD4NBsgwpR9seUBeLH7hl/yucwxb4ye7nsTwWb8CPqjXq iyfByixXDaHoNQDuo3w80RbJpZcMmFg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GZu6N4Ih5Zf7eZjzMh2GB1Dsou/X46+ClOTdb83epCo=; b=D2a30PBpa9rj4n1CfscbGjxtKt kntJY7McTn7wXqkSxV1gU9iu3JqahGQvflzCONtbu7LFqk4O6+0nEYsoda8wqPCnaCRs06yYYdxrr mgVDLovCE/VqS3AWNbx3s0wk8KXks7R8XHR9i0kngDIbYDY89VaUMCmw4WaCKRzahFiCLf+/OUEoe WAI4Kq+XnQ2Kf34Ww+Z4umeLlPw2y8djEwoK3RYElHZ3D1j/Ur1h1exCuxkGsyb7MO5Dl9iTYOz7d qbtGaaKQI5rmROAMJ3axZ3acB+x7xY29hrY+gTLD7G+aBT5901DbFJqoULdwkRkp3T8IGYvzTc8xM tGO96a4w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxEz9-000000043XQ-0vlJ; Wed, 17 Apr 2024 23:46:39 +0000 Date: Thu, 18 Apr 2024 00:46:39 +0100 From: Matthew Wilcox To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Mina Almasry , Andrew Morton , Muchun Song , David Rientjes Subject: Re: [PATCH 1/3] fixup! mm: always initialise folio->_deferred_list Message-ID: References: <20240417211836.2742593-1-peterx@redhat.com> <20240417211836.2742593-2-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417211836.2742593-2-peterx@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BE337140015 X-Stat-Signature: kzitxsscjosgch1cbw4rx45gjy9arwa5 X-HE-Tag: 1713397603-554456 X-HE-Meta: U2FsdGVkX18OPmPXK3iw3DYeW1gH6gmJCPbPTCXYW5ks6tX4fjfPwBIqTgPJD21qQUczzpv7hOR+4pZRHMo9nNsBJkaUGhlSnA0Tw2anJDEtgZ2DU5llYUa8GoQniCLD9mSykcpQfsU0jZ5rVL9B9+ZuGu4mqMU+LsnXyNvGvDkFQ7JuAs4Nvqu38A1SZuUQTs9wTSpK/67Un4kglyf3GFE02AxmfdA4ivDwHsA7a+ox0wfFc1pr35qtUXEB4+OwteG+xs9cr153kdufBkSkh8wvqcF3LPwVuGQ9LXsZ+pL4+WhpH8RJzIsS26BEMAPkToAy1+HLx+24GDw69mHYEYIkZQIXu+HGcBqdxDEIWjODE31P082ywv2TthiXfjOTkPLQuE70dfafjfpwQx/wZr8JY24D8CDC0UmQkZ0SjM91Hr6WycXi2wKBZcoHBQLO7ifRnUyYREtQmQ2s6c4/eLKDdjaJVv/DJE56suj0slrRQ/NW/NWrAffGtSyg6/6D2KVHAZYxrTHqrXKicjpY0T7JQbgJhKYOXFVAmM0SinwAFhVO6yZEprXf4esAN/vWDaCEc4wmTSxY0Ype+1eYzjpZnhVoP/u7kes9Sr+zAI1wI1EavPUFORHkoe/UWqnUazp3xgIFHdIRh6ByAq5/61eagw6gGsA3bcCxfkCiM1wSKqG92iEYUg1wQZn33vNfU/sDRwZAS90ypdwrT2XT0yIgy1FyAjB0enROn09zTk3SvP383EWwSKlYyB8frIUQN8b2fjHMBPinndhZH1Y2JAsniCLvAqGyEYOPhuf5l4n4I+zkHDNT7G38f+SfOVsM3+y7pNBnoE8jGarNwoPOPDbB+sO5+6osz1i+vjM1HSB6nrqsnkVKBdFDJGoMFp411QptSeDCNglPyTiUKGIRJET8CeMlf0cj22oHyPanBM+q6xtvBpzMZW5inR9/CnrYqtKsE4OBMOoRN9lEhw9 nP76ot9B NI7BrYiAcU3Z1M7IMD1MSwC8aP3k+WmuArktt7vGbP4QDfwQ9r2PnZwEIJ4bhnvV8QnEBjXPepUgfTaCagwOp4i3yg9K1Rw3dz24uHSb6dE/tQVONJdgPrNMQ1bnwA/UWZt0QYxDbTZ5iJmo98slgF7zTnYLzkvC9BepdWUuklTwfOKatejRWMpMAHH3Lx4NVI06cU6WEz7E6IWRRWhc65ItIFTL27LDBQWTZF6NzgnKavTaNMNR+rdh3XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 05:18:34PM -0400, Peter Xu wrote: > Current mm-unstable will hit this when running test_hugetlb_memcg. This > fixes the crash for me. > > Signed-off-by: Peter Xu > --- > mm/memcontrol.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 1840ba4c355d..7703ced535a3 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7529,6 +7529,7 @@ static void uncharge_folio(struct folio *folio, struct uncharge_gather *ug) > > VM_BUG_ON_FOLIO(folio_test_lru(folio), folio); > VM_BUG_ON_FOLIO(folio_order(folio) > 1 && > + !folio_test_hugetlb(folio) && > !list_empty(&folio->_deferred_list), folio); Hum. I thought we didn't get here for hugetlb folios. What stacktrace did you get? I'm basing it on comments like this: /* hugetlb has its own memcg */ if (folio_test_hugetlb(folio)) { if (lruvec) { unlock_page_lruvec_irqrestore(lruvec, flags); lruvec = NULL; } free_huge_folio(folio); continue; }