From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B6BC4345F for ; Thu, 18 Apr 2024 03:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8A616B007B; Wed, 17 Apr 2024 23:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3A946B0082; Wed, 17 Apr 2024 23:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C01DF6B0083; Wed, 17 Apr 2024 23:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A38306B007B for ; Wed, 17 Apr 2024 23:31:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0DD4AA18B5 for ; Thu, 18 Apr 2024 03:31:06 +0000 (UTC) X-FDA: 82021226532.25.FDDB512 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id D9159140018 for ; Thu, 18 Apr 2024 03:31:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f5uJT8NK; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713411063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zy7IR3Gvl36ziw9sf2woAp5XWV/QSQ6BNNUf9k7Ge6g=; b=RoIRJ5RQubOJfDpa34D1CTIut2lIfoaXhLtVPzk6fVubh6y/oPFkCMsgoTKdZxJbE+UrMM Q+7nnif2tXNtZPwfB53SDeLW45S4YJz4d+fGdgZYlxLHZjwEJJvfqHiR76M3zZzrPcp6Mw d6i7EIfZlQP25++ndMomxexuHK673TY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f5uJT8NK; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713411063; a=rsa-sha256; cv=none; b=NmwWyYKIlm3dkbzTKNbrD4pbLqpgGGQFX2omgEZO3B0av2yjLdfu6bn3xWqjtkoXjA1IDX Y8qPVoQ9imH/G5OAQ+UQiJ45bsnwlhXmo8TAVnxaCwRM03ziZBkMCbZUqoMX6m6d9TaijM nU85jckvQ2pCQBL9UrfbfzxqdHv7WUo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Zy7IR3Gvl36ziw9sf2woAp5XWV/QSQ6BNNUf9k7Ge6g=; b=f5uJT8NKu3sNkh/Q0cLgqRlT1O nHg8ZE4rhHPBZv3pwx4O+QYR/31LKzoQkSYScFKaz3jCP2Ur1DlocSMHnCte+iJc3csQxO2sNFY48 B/tr2ChVHbWEwQVGVj9vMsMZv00KnarOc0LAQnr+lnkVgryFI2PNK0/xkZbCGO47UP85T/m3YsKF2 G4DRz3S4nluNFOWMCQnPENCEduyiKAq9gfQcAuiImfdutsxhxW6zFly7KBRR6gKQNlwhj75XKPo1c x42ra0Nyw3kSYLwx965aQP0JMvGZtEqVa7sqN9OJA4BeY9J8eoZDVLM7ty26WZql/8SEl8yclNwd1 +AHw60TA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxIU2-00000004Q7V-43uq; Thu, 18 Apr 2024 03:30:47 +0000 Date: Thu, 18 Apr 2024 04:30:46 +0100 From: Matthew Wilcox To: Barry Song <21cnbao@gmail.com> Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-8-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: zkjhhkcbm9g7ehg3rc6eo467hdbawc61 X-Rspamd-Queue-Id: D9159140018 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713411062-88454 X-HE-Meta: U2FsdGVkX1+Grj49NTCIBE1iENPaRtl1b/lJSNQPnJPiIcp/deog1gEAo1PXJleiBpziqBnQtVbXjwK9FXt6vUoChekTedTcmGNI7rW8X9Vcz3KPV663F2VX0SY6w4z3Rovw6YHysmoU3lj7wLhDx1Ti9P9i7UiAgxr762tfGI1UUh7IiQkqzBN1FJJX3NK1MDHTNwS1TT0YM68/UThiLEq9wuQZrA3u86QwFzYpzB44MD6C0ErGFYQL0ALxGGOl62R4jIDyj8Ild2Mo9CovBOxKbqJtUCxqDrMvN6HxSPecjqGftnXdEBtR0CgmB8Spijk2KJz8jn30rEa6qQc2/OEzE5EpUCS8ZkI5PxNwkfm0jP2ii8wos/Xqgup20x7t3JBMdsbhtPOQb5u8VukS73Cah5T97VN2ajKxuQfVIvzN2qQwMJxKACBR2AqDIyU2Xb889KGPbs+Juurf84wtMVuwbWbpY6YrMiFJ9+WVZI/08zRwLiuDGP2g+R920xvEzeZl/wbMAPtSxr0lFb24wguIT2kENKLCipRQx7d+HGFQ6dWAxuvuwf0DanRzvac5JyA2W0mG42g96ixQQNskh91jJvrdO8E5W89qh6goUcS6UZPExzr7GCHWhBpL4VdKTH8c1eAhQTCWiA7GiJ/tlydMWgdyMQ1o4zJLl5yinoSfxn8T7+hPiBsxAZWpplfd/jPhJAGTuyV4zlyBylUqVU/vwOawpUedsjjyiHAWGvdnAIogTAS9acW+Cu17jBbR/7pf1HK665pSh/3udTBGgqrxPrv/gGkydmcXSh7Kksql+D/PkkT+Waqgj8Lp1OC8oLepgLF5Tx2+AXhhjqZRq3ByPE36HBsXS7KZDwX67xnNf7YnAz6J5OrbPkhth0NoO8r3DDMLUAN52Exn0i2FOyQERvDHZ9TuVY2cbIUeG2LD8ykVOLOMZHuRRFXw7WcJyETm9+THv7qS7HQ1Gmt 6yTZ/6V3 5wEITQVkA6E1MszXpcbgQgoKPvQxRxXKXvyo7EoDBx8PaCt1zKASrnVarFaXhNJ56bXNvgzo1snf4RbBsX7nx5pzz5AxkY0N5BZ/OJy0IWNTMZkkUugcGQtAQnDHsqRziJlK7bqkv0F4AMdAIG8eDtNXrh3h/zrYcLlXQ3thAW/CBiCxjmnzDT0owTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 01:55:28PM +1200, Barry Song wrote: > I also find it rather odd that folio_file_page() is utilized for both > swp and file. > > mm/memory.c <> > page = folio_file_page(folio, swp_offset(entry)); > mm/swap_state.c <> > return folio_file_page(folio, swp_offset(entry)); > mm/swapfile.c <> > page = folio_file_page(folio, swp_offset(entry)); > > Do you believe it's worthwhile to tidy up? Why do you find it odd? What would you propose instead?