From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4556C41513 for ; Thu, 18 Apr 2024 15:39:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17E966B0085; Thu, 18 Apr 2024 11:39:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 108EC6B0087; Thu, 18 Apr 2024 11:39:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC31D6B0088; Thu, 18 Apr 2024 11:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C88C06B0085 for ; Thu, 18 Apr 2024 11:39:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 527C61C19BC for ; Thu, 18 Apr 2024 15:39:26 +0000 (UTC) X-FDA: 82023061932.01.8022185 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id 107CB4000F for ; Thu, 18 Apr 2024 15:39:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Dhagt/Ds"; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713454759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WgOF53jdDU/WmRaQuxCUC8tFuIKqA6KqlxEAowN7EYQ=; b=4P+qxe/YWWoE834DAeuPdGYDbWeKeQdVQukSiZXqQ9v/nAYKpgEGJwrvc7rLKCNe7JQedi 1QVP0bRgWZnhs91ClVB3ka4IU5cqXkmRYUtpl/+zgym5+sOwXRc6ykffqoYWdcLAStPR95 TZvnmKsFhetZjiFLC+f77T9KVGdAUuo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Dhagt/Ds"; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713454759; a=rsa-sha256; cv=none; b=RUQVWB2QrkSMJNMLXfLoFxq2v5gQQz62EuigPJBhBW/1OgV8msJyhlmvxCzLikZXUYxLxa 1rrx7DNrVxT2S6dgMrgIXRqqKZ8xSfEp0L1SuRZLjR+TmbXzXwlI1d8sQ/i3okoXkq8+RE 3/FVi/yx22/tZsYjlfGE2uZmoUuGrRw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CD174CE188E; Thu, 18 Apr 2024 15:39:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDB10C113CC; Thu, 18 Apr 2024 15:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713454751; bh=poikjUesrlZvYhdkYUVTGKAXtyh6o27VwcY88bzAEGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dhagt/DsCV508bBCSM8PQFh0KZ4ChVYVPTqwgApoowoaluDog1pdK/qIVJU1bAfJ1 yTHdqpTqCwsTRyfpVzaQYmToVgTGF005G8P5bcBRn51+TfjO6upp0QzeXZdpRVmP9T DyDQSEZc+G77sXhvEvzJVgEwHd81+hiEegtvxJRrNRYHrUsgJx5AWmHmLJX+3OoPI9 DgUEekwf3Gv6AvfsAJ1j1lmBPCAVlRdxF5BEqB76VwjdS5tGiPR4UhLWWIRbIEiDfd AIVB7M07XTdJ0VLvAnDkmSjg91AV2IlHsKb94RwxZ2UFTajWhnfg+q+QMNKv4wdsDX 0LvSLkPCKaqng== Date: Thu, 18 Apr 2024 18:37:52 +0300 From: Mike Rapoport To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Message-ID: References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-15-rppt@kernel.org> <20240418061615.5fad23b954bf317c029acc4d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418061615.5fad23b954bf317c029acc4d@gmail.com> X-Stat-Signature: d6z8tonsq4zaesq1iq19jd7un769omtr X-Rspamd-Queue-Id: 107CB4000F X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713454758-874767 X-HE-Meta: U2FsdGVkX18AvMtV1UIEvv6SDnTpzbyA2jQFB90Pt9xelEf+C8kC8FGgZbK6vUmLJozhlQL773D+xEa1xoNHVdG6/Q4/iH/kw7wC+KsMUTcDzXyPm0+xGvl3UkTIsB0Z0GzYCYYRNrp+sRJdy3Wt87fWGC9GrUrVvjq6zUPscKHZQF4H2mG8fNbiqaKdNDBA/Q8OXdKU/wQVLkFaF5xi+XYqGKWwJ+L/LAAwYJx4dSnQkXgbFMTfTsv7EpfpUpP4mK8MmDvEgJOwnFTfiie9yTBQBwgQMDDvxz16RVf7W9kRWD1CcbEkyTNxo2XPjVZKKoPlfeSDx69ar9tw8hJykKdLVBt2Tt+e7teWLmrtY2QNLLP0m0hDLj2cs5nr2Agg4hs0PH1kPd7E2oREU8p3fCgaZSs8SFiB6fDmdbLudk+A8WBUhXRyRCwhLKoqmuUaE/JNoWvnv6Ra6PTXOuzJHLppnr3wYJD4A1HkpNyCjwTCeWZ2e0aqhQ8OuU+5jrxuKESLuv620oOLq0VU9mzM3tkF6F0LDzBwk0M6c9+FDz9NND+Tlshq/BXWDYaYQ7FxDqDkPihwjDbvhKMNhGJVAYEkSxuKxviUBh7Lnic/7r300xvJvQuyC2yTP9fVY+AqqKDQO2N0YKJ9dnbqy8QV5N1FEBiq1o2RGE7wG5C48kbiucLZvhY9Te+lxdgnSsMubfpaLbBvxp75k+G6P5LU9c/EEi29lEpqy3NQQdpbM0NbYFTaaRSIuvB6gpTA9e0fkTP4OxqBVJbR+zE2aHHAdYfVWJhCACsCndsALWKfvVbJnfsC51a0ZqVTNMMlbbZxAajXFNkH/yNmpE/H9FxnTgTvD9lmyOtuqfNkfI9HEzSXu+YpzFvJMwdFl1F6N6vi7VIrQKy5I3mzuot6e5zu1Yck2GpNzwhplXOS9AhVjaO/CaAZ2/91tC+nYKnOzuorAtjyGAM7yHw9tyg9jOk C4oWkQCk VbZUGh4fUEUClM2jIvWzC2h+yI3IefbT8DTaS0Oo3GdmyVvENnbQNAp25pKkCUm0sLR9CqezdKkFdGE5nqg8/YvYMFDfYx7QEawTKMTYOVLOy5o1sfj/RhywrK8V8MOpaOANxOu+0wqWP21zGrVSDjxdPXcoDGkXupo7buX+lc1/CWR66lASoA4AIrwIz2mXL4xiouH9U0M5uT5mIj3TmhSFMOsUDJn9fRQGfh1AM3KuiP7H0fMeP01gBy+xnaL1u+1+l8XFQlpZAmgoCwSUBBHFIzQ8dltkOj7woy74dvgF9L+Kv6R6i2vrflNPh/H4fwrlG2G23thFGgiVOlGaddm3pf4FEXF/KJ/KLV09GuAn9goI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Masami, On Thu, Apr 18, 2024 at 06:16:15AM +0900, Masami Hiramatsu wrote: > Hi Mike, > > On Thu, 11 Apr 2024 19:00:50 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > kprobes depended on CONFIG_MODULES because it has to allocate memory for > > code. > > > > Since code allocations are now implemented with execmem, kprobes can be > > enabled in non-modular kernels. > > > > Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > > modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > > dependency of CONFIG_KPROBES on CONFIG_MODULES. > > Thanks for this work, but this conflicts with the latest fix in v6.9-rc4. > Also, can you use IS_ENABLED(CONFIG_MODULES) instead of #ifdefs in > function body? We have enough dummy functions for that, so it should > not make a problem. I'll rebase and will try to reduce ifdefery where possible. > Thank you, > > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/Kconfig | 2 +- > > kernel/kprobes.c | 43 +++++++++++++++++++++---------------- > > kernel/trace/trace_kprobe.c | 11 ++++++++++ > > 3 files changed, 37 insertions(+), 19 deletions(-) > > > > -- > Masami Hiramatsu -- Sincerely yours, Mike.