From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88D4C4345F for ; Fri, 19 Apr 2024 15:50:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B8B6B0096; Fri, 19 Apr 2024 11:50:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC0E6B0098; Fri, 19 Apr 2024 11:50:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83EB6B0099; Fri, 19 Apr 2024 11:50:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B911B6B0096 for ; Fri, 19 Apr 2024 11:50:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6E25FA0313 for ; Fri, 19 Apr 2024 15:50:47 +0000 (UTC) X-FDA: 82026719334.30.2CC425C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 4CB7FC0018 for ; Fri, 19 Apr 2024 15:50:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OHj3fHUB; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713541846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yusg8BJM3bAIRTaYiOE3/SVhzDGu73eOeqQRgqQfMzg=; b=z5Gga4gfarrf6F4B7+RtTNU94VSDUU5ZT76dqAPM9jB/XAMcGiu3oEej6Hv1Va3PVZqneo C8A32d7dbcyfk5trxu1lgODpeqYNWdI2/HS21TAK3vlMzbZFyTTRZPXV3xCAXFAtRlbcg4 NJo1rhtKmUHYDd3pEkYD9QbEHW7S+As= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OHj3fHUB; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713541846; a=rsa-sha256; cv=none; b=LXk5KfOC+/kUe2d90NT7Fvy/DwHIO5KRbc81xjM40wa9y0S2ZYlgwkWhTwnZXDBF58bsMg gl+DM2rHW1Jx9JCeEa+PFjVaaMNQpw7yPfZ+SY5O5F1BTeTPX6xbBujre20r+cHc2FmtTn 81cu++KRCrcflhDpLs3Ne1q+D1wwAH0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 52AA1CE16E7; Fri, 19 Apr 2024 15:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B33F9C3277B; Fri, 19 Apr 2024 15:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713541839; bh=4syrMVBjLG+mqSAuWdu45onjerLE6hugRcJZYIbTm9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHj3fHUBZ5oW6uWZr153zLjsZ6q0yv8DxwxD0Zy4isctsEWry5XXGSfR8Vc3hMrh/ vizLT7qFrrEF533kmJCP3HWtZ7Qzr6mVAw251VXfA8O2WlqLyeSYgvuFfPALuIdv03 8KfWQePVkfruiceot7yZycnjNdoMZw4MifC81l3AU9dBYam0QRDoIaUN7a6lFYb8MN K0Whze6qtl25bkJdh4oiv03gWibiSz5LhY9l5mv+w3PTDhkRKRk4JGDzV2xKnexhV7 tGBMGlG1WEFnNmkggVGWaWOAgxzIa+Avjitv3Mny3kNElAG5XpvzSHnQsEDp7b51Tm Ziw7Ozh3aQ/+w== Date: Fri, 19 Apr 2024 18:49:17 +0300 From: Mike Rapoport To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Message-ID: References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-15-rppt@kernel.org> <20240418061615.5fad23b954bf317c029acc4d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418061615.5fad23b954bf317c029acc4d@gmail.com> X-Rspamd-Queue-Id: 4CB7FC0018 X-Stat-Signature: 4xoef8nusp6hyxudmx1byyxzma6f5dbf X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713541844-240048 X-HE-Meta: U2FsdGVkX18TezRy4iVFd3Wwgboznr5SCCpgzQcSYnsGIy6NtDI9JL3RSDqrPjgxyEsavcZFvi9ySZcwgqgnPuyrituGRuahB+h8BahhQr8DZ4Kdw+eda4lxBF6q8pzuyIHozcZL7vO35ufFKbA22HNMs++6BFv2PlCBoI8/04BB2BSZlOr2CKzAOs02nYlwkY1qhNcFTFbM3Ue719SppvxYZixHTiJFpKT+A2FOCoRuqBIAm0aWOgNxrB9kvbRwftfjHOQY2pvJdmymwpl/Uu6qs/fyiSEs/dZVjpJ5kkK5yADURfMo4UZA37bCN6APInXwRwzoleUxc1gHh3gLYfO2S0q+RXpqYRO8X/E+pw4Genw79ZpwElj5DF+mtxWvj+m3Dx+xBMoRdwmlAQrmz62wWwUzyf3tjy+7QuMcnXuF2KnY7u6EvN8bZYVn9eoQfxEtlBw+Imdg0s+m0BiZ6pMp2EiePNI1/xw+lz0wRt5dp7Yd2PGXEB7a4bLfjsEugYkCkTigJOAlckcJiL8q1Quh3b9f7daTUWNEjGQYMJDNOfK2b1BThJl5jPWa9nq8MF40MaSUrGvXWQ8QhqeuA45j55utNiCyV9Q7eRztN0hbYh8BmtjlZ40UkSpozksmWjsx18u7vTs7MfSwSSqsoG9ki0UlAHDA8l1t0VIkA85KHxosVTAzpGE8pkSV3FY2QWJlXBEt6fQ8zK24TqxzFWT1KuxzVnInIBC3DeTs41rF/tB+RgPcGaPfAFNkaO+5QP+RqBFP8sdWFAlgJyB5KGMMjyhEKZ6ArJixxwok7LdbOr8l9F4HuNQ1uM9+Q4ZPfRXdN63qeYtgfmBr5GgHAXAY/ce2qCFKcZSz+yMmUBdvCJCjj7kTBk8v3vUMFD/0TV9eoeb/mPzn8Ohpyjk2v0JA6mhWvnPbR7509tHrQ2Q3GQP99WmfQE8Wi8FsoPKkHNTQuj/1soOShravsr+ KT5KPoPA IN7Gy5lfe9wVluW+fRYOC8pbdY4BedATuyyos X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Masami, On Thu, Apr 18, 2024 at 06:16:15AM +0900, Masami Hiramatsu wrote: > Hi Mike, > > On Thu, 11 Apr 2024 19:00:50 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > kprobes depended on CONFIG_MODULES because it has to allocate memory for > > code. > > > > Since code allocations are now implemented with execmem, kprobes can be > > enabled in non-modular kernels. > > > > Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > > modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > > dependency of CONFIG_KPROBES on CONFIG_MODULES. > > Thanks for this work, but this conflicts with the latest fix in v6.9-rc4. > Also, can you use IS_ENABLED(CONFIG_MODULES) instead of #ifdefs in > function body? We have enough dummy functions for that, so it should > not make a problem. The code in check_kprobe_address_safe() that gets the module and checks for __init functions does not compile with IS_ENABLED(CONFIG_MODULES). I can pull it out to a helper or leave #ifdef in the function body, whichever you prefer. > -- > Masami Hiramatsu -- Sincerely yours, Mike.