From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EE5C4345F for ; Sat, 20 Apr 2024 10:53:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F1B36B007B; Sat, 20 Apr 2024 06:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1256B0083; Sat, 20 Apr 2024 06:53:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7419E6B0085; Sat, 20 Apr 2024 06:53:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 536696B007B for ; Sat, 20 Apr 2024 06:53:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B38F68051E for ; Sat, 20 Apr 2024 10:53:54 +0000 (UTC) X-FDA: 82029599988.07.F692C49 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 66D02A0011 for ; Sat, 20 Apr 2024 10:53:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X3eyeiLy; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713610433; a=rsa-sha256; cv=none; b=YFbQMNxzwOce+DcNlET836X8MPVehDXa3sdEBEU77As+BjhsNlDkr52uNUg9hGxxDYOpQj rs/LWsGczjqMmzTNqfn+GO479hAdn9CDeftj1niwjUcckjwfqNrdy+0GD4Y3mgEzZGEikj XWSzNsBsk00475FGFpQmVAhuyjDbYZc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X3eyeiLy; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713610433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VuD6rCvhxOSch1QmW7CafX0+vUh/pKa95M7G5Tk+xlM=; b=tBzB+EkbXNS/Q8u38Kn/8mE72e+gte5hr1RdFH0OwwrFSQ32/b/ta8VIj9fFoRse8BFP4y QQqI3fPhlGX7Y47lbSyBPln7+NmJ1YAAGL0mQUMjDSWljg7SFpCMN4LVhO61+NHgA9CHds 7gkPxHG/spfqEccibZK4NIYCZUH5S44= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C61C0CE19A9; Sat, 20 Apr 2024 10:53:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F744C072AA; Sat, 20 Apr 2024 10:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713610427; bh=SM7VfRahGBLcoMQTiuF9XwON0oAIQm3UPvX2eiqyDXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3eyeiLylPAUkLSbyyrlGHXzvYV/bgYpLPhV7vw8xijwr2D1MExbuRdRactesAT8X zdt7h71F5DqBQu/eRbhv/5Y0Rre5yGM+3/QnKDXleUxYNRTZmWf1Vo3WU+1+o9lafL JRP9zqL5lB14IFxVzQv/2Y2x11fPGHO1UTIDooMmj7MCyEzwQSZ7FSoL/8Q352iA+B xJtavt8SFXQQ13eBr6UXoSA7CP3oDA+2zBywG990wKdhsiRvE/zNe3PUQwDEQ+0Y6e BUuBnLZ3CWf9tTcjXso+bnm9SeKBHDu3KkkjgF+H+J+dCs6K3ICndd93HsxM2BWoMW e8kLY5pax56uw== Date: Sat, 20 Apr 2024 13:52:27 +0300 From: Mike Rapoport To: Masami Hiramatsu Cc: Christophe Leroy , "linux-kernel@vger.kernel.org" , Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , "bpf@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "loongarch@lists.linux.dev" , "netdev@vger.kernel.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Message-ID: References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-15-rppt@kernel.org> <20240418061615.5fad23b954bf317c029acc4d@gmail.com> <321def3e-8bf1-4920-92dd-037b20f1272d@csgroup.eu> <20240420181500.07b39c77f1ca086e8a5161b4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240420181500.07b39c77f1ca086e8a5161b4@kernel.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 66D02A0011 X-Stat-Signature: 1ininztfpxu737c7tokmuncyfn78y759 X-Rspam-User: X-HE-Tag: 1713610432-718952 X-HE-Meta: U2FsdGVkX18gIzK/96ESZjaREyq5uQOFiE4EP+XtRqb9UHULjrXjGW2DR1h0tUauSMDMriZjWG35zrwidVV9W0ljRHQrrrvM1cre2gUHPVs0ae+nHoHHBT1/tkVvfN4LH12cf45HVux/TF2MACQwpUXEE+KLRyV3xFe+5tZYqKVqcFnS9o4NJ44RHlZhjiOKHmw5pwkWTXS6XgCG33tULnihvV4OFmiQBTweHx+4MoFXPlfZqhvCClTg+j3hYYY+ukyhAZJjp89WUAp8LLiNhDvV3FMukt0vVwiLzgO/Af9Oy0qziWR7pBg49q1Zw7oYjMI0KdL9UunvaHpQHBsIM3IrDrR2YFlP3C2S560xIKuuKg+c/DtV1ON6lom5b55kWZn3596bexIcm6EJowo8hLhT4BHL5irbBEzJpidcui19t0TatW3MUIb76RGtRv2RdGga1iTuU5ckXr9d8bOPxmDgbOQbK29RryZKgkQsgEzS7JdcAAHGIyXfGYKdjVBPIgwl0NDGhlfb1uMq14D19SpCVeBQxrxWbIfneqNNIJ5mHzTxHWb6eLoIkDsvw7eC0Cw3lmyZkLRIc/+79GqqDQ30O2sTrt1OkFfJcZWwRTR0c1J4hCXC4r/grkAIFGYxyjIdQSuFcKUgCm0mt9pNd+hZz+XbkatZiKTSmtBCsBswNLe0rIgnJzXXVrsp56DJbI9cYT6x4qNoK5LduQO7gv+r5Z6fX8w/yeJ3DHS5/OoWHL1+oKHr3VmpQAqxrTyDvYfWyBrZDfdxF1CdiBEv7CXSfhGvmcHJ0B+y+2lOSaKex6SLEY7HMu4h4to2bJCC9iNMKpy6uOS7m94Wq9JDehlZebHGWw4sHBlsyqVO/I36OFA6GQ8Xf6HOILNyokmCov5TWQIbT+thLzbNmt8lVl8KbX0D2bVTPHVJ9bRICr12lddU+ksEwoi61thDfx1E6Fd1bm9vfN8PWhmD4CF ZbTWVrXn OluzNcOgTusiZBxP8dVsTyr7OeYkKk0he43RRM8JYzr06cXx560wgg9+STMQHy4qHeAyGXTWBOLf3xkpQAFrk19lPApvIiyUCir4BKTzI+vi7zExXz1tEKGzbrlWRERAFgAKhz/7Qf3VxuCx8BSGvHdDwrDFSV8pYozFhgau8qvXJFQccZnmw+gFaXvGkWWbT4uuHGz/s7OSqrL1dsqPDncLB/eP4KmDsu437NIi6GRpy6hP1iMTgYnxD7DhLsgDFesWvTb7SgyiEFTcV+Z7H92qCEjvSdvqODTbBBcL8UkujdV1ZuzgEvhoYivkfx5nuXUxxed+Jv4eIGnRCq9fjgEv09pq+DHA7JC6YZmLYsEkG7AhonLjgkcCP9h731mROQNITVHckDS0AI8rpJPB3QCD+EQCWD7/EkzVfBsuBHvHV9pRMfFxnk9Oddg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 20, 2024 at 06:15:00PM +0900, Masami Hiramatsu wrote: > On Sat, 20 Apr 2024 10:33:38 +0300 > Mike Rapoport wrote: > > > On Fri, Apr 19, 2024 at 03:59:40PM +0000, Christophe Leroy wrote: > > > > > > > > > Le 19/04/2024 à 17:49, Mike Rapoport a écrit : > > > > Hi Masami, > > > > > > > > On Thu, Apr 18, 2024 at 06:16:15AM +0900, Masami Hiramatsu wrote: > > > >> Hi Mike, > > > >> > > > >> On Thu, 11 Apr 2024 19:00:50 +0300 > > > >> Mike Rapoport wrote: > > > >> > > > >>> From: "Mike Rapoport (IBM)" > > > >>> > > > >>> kprobes depended on CONFIG_MODULES because it has to allocate memory for > > > >>> code. > > > >>> > > > >>> Since code allocations are now implemented with execmem, kprobes can be > > > >>> enabled in non-modular kernels. > > > >>> > > > >>> Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > > > >>> modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > > > >>> dependency of CONFIG_KPROBES on CONFIG_MODULES. > > > >> > > > >> Thanks for this work, but this conflicts with the latest fix in v6.9-rc4. > > > >> Also, can you use IS_ENABLED(CONFIG_MODULES) instead of #ifdefs in > > > >> function body? We have enough dummy functions for that, so it should > > > >> not make a problem. > > > > > > > > The code in check_kprobe_address_safe() that gets the module and checks for > > > > __init functions does not compile with IS_ENABLED(CONFIG_MODULES). > > > > I can pull it out to a helper or leave #ifdef in the function body, > > > > whichever you prefer. > > > > > > As far as I can see, the only problem is MODULE_STATE_COMING. > > > Can we move 'enum module_state' out of #ifdef CONFIG_MODULES in module.h ? > > > > There's dereference of 'struct module' there: > > > > (*probed_mod)->state != MODULE_STATE_COMING) { > > ... > > } > > > > so moving out 'enum module_state' won't be enough. > > Hmm, this part should be inline functions like; > > #ifdef CONFIG_MODULES > static inline bool module_is_coming(struct module *mod) > { > return mod->state == MODULE_STATE_COMING; > } > #else > #define module_is_coming(mod) (false) I'd prefer static inline module_is_coming(struct module *mod) { return false; } > #endif > > Then we don't need the enum. > Thank you, > > -- > Masami Hiramatsu (Google) -- Sincerely yours, Mike.