From: Matthew Wilcox <willy@infradead.org>
To: "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] mm/slab: make __free(kfree) accept error pointers
Date: Mon, 29 Apr 2024 19:34:24 +0100 [thread overview]
Message-ID: <Zi_oMFn7HxwC1by4@casper.infradead.org> (raw)
In-Reply-To: <6406512f-12de-1ab6-05c9-4583c0cb01e6@linux.com>
On Mon, Apr 29, 2024 at 09:29:58AM -0700, Christoph Lameter (Ampere) wrote:
> On Mon, 29 Apr 2024, Dan Carpenter wrote:
>
> > I've always thought freeing pointers that have not been allocated is
> > sloppy so I like that kfree() doesn't allow error pointers. We always
> > catch it before it reaches production and that teaches people better
> > habbits. Personally, I like how free_netdev() only accepts valid
> > pointers.
>
> kfree() already checks for NULL and ZERO pointers. We should add these
> checks in *one* location.
>
> Maybe issue a WARN_ONCE() and simply treat it as a NULL pointer if an error
> code is passed?
Did you even read the initial patch? The point is that this new automatic
destructor path can pass error pointers to the destructor for completely
valid code. Warning would completely defeat the purpose of this exercise.
next prev parent reply other threads:[~2024-04-29 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:26 [PATCH] mm/slab: make __free(kfree) accept error pointers Dan Carpenter
2024-04-28 20:20 ` David Rientjes
2024-04-29 3:03 ` Matthew Wilcox
2024-04-29 6:08 ` Dan Carpenter
[not found] ` <6406512f-12de-1ab6-05c9-4583c0cb01e6@linux.com>
2024-04-29 18:34 ` Matthew Wilcox [this message]
2024-04-30 12:09 ` Vlastimil Babka
2024-04-30 12:50 ` Dan Carpenter
2024-04-30 13:12 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi_oMFn7HxwC1by4@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=cl@linux.com \
--cc=dan.carpenter@linaro.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).